From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GsGfOJhG4mk96h4AWB0awg (envelope-from ) for ; Fri, 17 Apr 2026 10:41:28 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=mOELMZCo; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D326C1E0B1; Fri, 17 Apr 2026 10:41:28 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3CF831E093 for ; Fri, 17 Apr 2026 10:41:28 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 41F284AA3946 for ; Fri, 17 Apr 2026 14:41:27 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 41F284AA3946 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=mOELMZCo Received: from YT6PR01CU002.outbound.protection.outlook.com (mail-canadacentralazon11022079.outbound.protection.outlook.com [40.107.193.79]) by sourceware.org (Postfix) with ESMTPS id BE26A4BA23DB for ; Fri, 17 Apr 2026 14:37:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BE26A4BA23DB Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BE26A4BA23DB Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.193.79 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1776436655; cv=pass; b=ioQlOkLOHarkxDARHQSYGtAsXVGZAf3tyC5y7XzR31fF6OyWhdqPLpIQx3UEiq/hK8dZg2RNCm73f618S+GXT0Tj/bMCbOOrVJvjRRUjOTTMXiT/PWwzarfoMeohFSul5OspOrHlPHNyWPmFYvxLZ7ZJjuIFZ1WuExiUYWHLqhA= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1776436655; c=relaxed/simple; bh=dicz+1O1S5FtO/JWLB9cf6KYmJ+1FohI1+2VWFuZ3TQ=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=t9c4nDQRZkhEcwt0+dbBgQMRNAZgbwbZwblb4easCEDCZc/URgJLw/g9qI41ihDT2CjP02V5vNDXcT1oebqaVRtHfk1pPPdZUtoAvLtsigml2mPlH9jr3bLUXUekSIrtwhXOf9eQB0w8THFonLJmEsXAtBpJEkQ/gbXbL5cH958= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BE26A4BA23DB ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=DHmQVK3CGlHk9UqIRz1eA0d9SgXuor01jdHfYqDtsL8dffU2/+9+vKDxuVS1EsqiTx2eIKtRVzfKBWCkED+qDi+dvAMbPkSJnciGsKR5DCj6Ot3sinm0y21XwzZOnuV/anjBy0glDhOKFLF/54Jy7G3BAd6Fdklzvl0yrZv6OdxJQPDORxTiLto41pQBVDNtKvahpnW0cTnFAgea7cDDWDJXOmgUdiN2fv/LnDiHv1FOGBq/IckB2cEYnUqN6RAnKkCox7dmfqurd+AGXOWsRvFPvf2pfYrhx2hU1F093GoQnN3ZAPcHtZVTdLTBDBKr3QEi1BgVGfnaJZrgXXYwCg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=qWjqEiFfOytXyPdCQhc3EWTDuv2Nzu1Mtizo3Epf0EY=; b=PSIdSay+o+xtnUquISsS+lKHzndig3PwZhOlXP+q1r2D/3yrWAzFSBf10xWjA2WPhxtq95kASZvjGjMLtesdYBvf6qCSSXNBdnaXdrGfMj9ZtZOUdzRrrcAv5UrWcTJnePZ8sToZ7RLTif4wRvpCWxLuEJRIvCb65OqNwX8ssnyCeYkpVZbmOQgPx9RGyBAs3JwNZKX6waOY/OYJnWZ9HlfiaZFxbm5GMUiWiXR4DvlWWYgnff0AL/kAarL3ax8Xw4JiCPR8Ggzj/74mpgUlI/UWl4lGc/mpkXIUUKFZFkTGmu1tB68hddNCt6cnfQWpuE/qRr4jJcf75/YKxdmklg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=qWjqEiFfOytXyPdCQhc3EWTDuv2Nzu1Mtizo3Epf0EY=; b=mOELMZCoMyC3uCUlb3itOLCFWD5LUiontZsO+rHEXJeITqs+rCg+lFtSStvU3Q2S2zlPE/6fsv8jKgsRROjmonLRd4flZvYrEnHKTjcCTE7NSGg3SdXo9BTjjlIR0lcL2wS+PtVywdHfxOddBoE082YzezuNH+3UHmvL1KnRCtNFEvMFREyegqo5DVY+gHTCxYVCxreRts/I8kS8XgkT9kxzYG0QQxqrSFwbiWU96JGNLd40ytUAB+mhOzUDMl7IYgBhaech3QUvSJ11D1IXbeqLJsvu6HhmSDSkDAK7mMWcbhz+ydCQIgly3jjQ1uYGJs+2LN5Z9EvGB1WXgmtTbw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) by YT3PR01MB6209.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:5f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9818.25; Fri, 17 Apr 2026 14:37:29 +0000 Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d]) by YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d%5]) with mapi id 15.20.9818.023; Fri, 17 Apr 2026 14:37:29 +0000 Message-ID: <9eb08263-d230-47de-9d49-1cf03a760c30@efficios.com> Date: Fri, 17 Apr 2026 10:37:26 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 04/11] gdb, gdbserver: make iterate_over_lwps_ftype a function_view To: Andrew Burgess , gdb-patches@sourceware.org Cc: Simon Marchi References: <20260416202408.422441-1-simon.marchi@efficios.com> <20260416202408.422441-5-simon.marchi@efficios.com> <87tst9etde.fsf@redhat.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87tst9etde.fsf@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBP288CA0024.CANP288.PROD.OUTLOOK.COM (2603:10b6:c01:6a::28) To YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5418:EE_|YT3PR01MB6209:EE_ X-MS-Office365-Filtering-Correlation-Id: 4480bc7e-75d7-4849-2965-08de9c8ed9e3 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|1800799024|366016|376014|56012099003|22082099003|18002099003; X-Microsoft-Antispam-Message-Info: y9bP14TW+yl9VN8V96HPYH7flKs587bc94NvtGbvDyUvfFtzTxlkWRaMmhfnIbx7wBhR73oy3JyxIH0J/vbKNWExWc8NCuWMdrKnS6wN5coH1031OuPQjOImFUqJYmKpqR/9duc1oqPmzGKOW9EQa29/Pq5EeUH9gBgp5k67ixj0o5nExeusuN455ikgynrAwDlAVXlAifabpRVtR8wfdmKZRg1SBYBTi60j6309M1zOur3Cp8rbmAXNlYL5xmXo0KtzOvT5IN+ms3ahLTPDFuAbACHh0e0/VMZHXLTCIosPlmr+twpq/Hx1ijjwphn3OQ7owy7hssCEHwoIAMM9uleiv64mtHpeNF+tRChZW1mmxHmyNkvvm0KyktqB/NORg3VNOOGGInY/R67r6Gf1iPgptjwYF7ZMWZD3wMkDI++UpTrnKK/cFwbN96TFhmZKrUbHQR+zFA6pGqrkid55Zad5C5EfVnqtMe0td05s7oZcPwfsFycbkTFeFF6SCwj9qgaQx0dnMZVta3F2dixMUxVsjUbbDDzda2dcmsEMvgLz0vIhFJpwWDuBedMBTxh5X6owqLx7+Ay/SBQzROuJsmOzfkdVq9mB5j/A8fLkbpIxcnIUk2CctEi+lOQzqEbRBtvmtwAgCvCeXHC6pyBvh87LNfLjmGNkUPXSgjdP8zK5ZbhQdn0/4RkuuRMRYlcrLIKc6YTpGzlXOPwVR8VGLCDSJ4CSKJF+649xyUkWwis= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(366016)(376014)(56012099003)(22082099003)(18002099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RlpTSlRFcjB3dTBOeFRoNUtielpYZ1MrcmJUUXp4bFVsOGRJd2Jta1FCWGUw?= =?utf-8?B?TDhsdWpzeWFSU1hEWEEzRGNYMERMN2FaNDVPVzNTN2VyYVgxMDVzL3FHWlJa?= =?utf-8?B?K05lYWx2Q0J6ZHJ6TTJKZHdKNFdmd1FacXVNUG5wZXBNV0VEUkQvR1U0QlBT?= =?utf-8?B?dHVQZW43WmtveXFDWXoyNFhNOFc0ci9hUnVjeE1LZXZNbi92dytOeGsyZmRC?= =?utf-8?B?ZzV3azNNWmhHc1FzKzR4MWRQVWNPZU8xNkJBK01vcjFaL295UDd4dlEvVUQ1?= =?utf-8?B?U3FqaTJpeGo2YUF2dFhid3NjRGpmMHhzZzJUYVZFMEJ1bGU1a1pmRy9hYmlp?= =?utf-8?B?UXg1b0UzYU1WUE5QYU5oZlIyK0EzZVRwdHAyQ0JQejBzT1REcDhTaWkxanRq?= =?utf-8?B?Y0pabjJXYzlGTG9Fc29FTHBxNGRmbEJmbTBuUlRlQ25VV3lxNTJTZFIrT1M2?= =?utf-8?B?aERrSGVIZGora2t6Z1NMY2Z1NUFJakZlTy9uTlRZcGpHNU1vZUNRbEZBN0tu?= =?utf-8?B?U2c1a0JIc2RHMW5SbWlObEp1NC9US1o4K2J2ejJTQ2FBU1plb0ZteDFqS2dm?= =?utf-8?B?U1ZlVDRLYkU1N1dRdzJ1eTZiTnhkWTRXZTNFV2VLN1FjK3BZSHZ3bU1xTkJz?= =?utf-8?B?MG5Ra1RsZFF4aHdsZ1RjUHNUcFpqcmFWN2luOEU3OWxFMEkxVk5uWUdZb04x?= =?utf-8?B?UXV5cWpzNlZVY3R3dHRiWUs1dytNdVRUajErUzV5V1ZqRFJKSEVraGtrRW5i?= =?utf-8?B?TExiYm11L0xpR3ZQaUMyTXN3SEpENFQ3am1ST1g0QVVQTGNSMEd1KzdSNlhD?= =?utf-8?B?RVczdm45V05CNEliN1Y3MEhGVDFuaHZtV1dTeHRoZWdBYTdTbG5DVDlLa293?= =?utf-8?B?ZmhIRms2dHcyNVVtWUZHN3NsVTdNREJ5eXlXSU9zOGFKeDFHb2xaY3Fab042?= =?utf-8?B?UU9qWkJjWHV5bWhSRytFdzNlT2tFamJQR0JtaTNqYW1tZjlRT1B4ZUo2WlJt?= =?utf-8?B?UXJXQWowZythcXArb0cwTTZlM2xSOVR5Q0dQVTNDMkUwbmxUZzhZQXg5c2FB?= =?utf-8?B?RWdSVmRROXlkZzBGVW1HTVJpMEtQUmoyRHhKaXVOdE15Q0I4QkNYZTF6VTJs?= =?utf-8?B?dVRaS0EwL2RsT3o5Y1ZRK2w0eEtlR2dKZUhhZldUZzBVdktpWFlEeC84WkRq?= =?utf-8?B?RVljSU5VZ1VxQ0lWRDBWTGM4QXZLaldYSFZIdnpvdjMva09CYUhlQVhyWll0?= =?utf-8?B?d0phZDFZQXlxMlpSV1pPeG00OE84anJvcWpSZjZKTnBUZ0tCSkZyb2tvdE1o?= =?utf-8?B?VHZGcnRKUnhTMDA0bUtSY1BWaEh0Z2V5Z3JESldPUVVRWFZBRWNVQXAwYVhh?= =?utf-8?B?TW9VNHFBWmU0TXEyZlMrc1kwSXA5QjFUNnBoRnMzS0ZBVFZpaWVmS1NqVTAx?= =?utf-8?B?QkdHczdDWk9wS0YzaFNlWUMwZDNFWmdNenJ2dTIxWGxZVG1KcWdrNmRPSGZz?= =?utf-8?B?K25TY2JRMkJYYUorWlV0QzdVeHkyY1h3bUlzRXRNTkZoSW5CSjFOUDZteHl6?= =?utf-8?B?bHN0eGtiVzVSZjBlbENJU2RCaThwMEJsdWo2ajFVbW16SUxQd1lpbVVrM1hT?= =?utf-8?B?by8wQngxS2dlbk5hOFBRYzc5OHdOYkZNTGZ5L0xYNHdUUUM2czBWTEFKRThJ?= =?utf-8?B?WEZTenk1SDlScEh0MStoZjkvTkR6WVZPa3RKNmNHR2hCLzVKa1FUTVdta1FP?= =?utf-8?B?QzgxNFNkQkpWZVcwbTdBbTU2S3VqbmVlS1ozMzdxNlptUnBkcFhZZi9WOUoz?= =?utf-8?B?V050N1lNZHdBa1ZrR2pnSzZUdHNxRE5COGxpd1JOS3c4cjh1N05jK0M3WkpW?= =?utf-8?B?RHRHbDlPWjMreGU5dHdoMlIxRWhIbmhpSHArN2lxblZlWTNreDA5OTFteFlL?= =?utf-8?B?NTczUnFWQmdVQkUwOUNoVFBFL21JNTF3eW1oQml6RjRvVzRDbEJaU3BPMzdn?= =?utf-8?B?b2d0TGRSVit5RVlNanEvNk5JbkhMS3BHY0M4aUpWWjRpS2hXblM5UGsrdE5C?= =?utf-8?B?NklUNEpiREdXcVAxYXlTa1kzY0ZrWWJHL2F4L3ZzK3JhYUxROUtSVmxmT1Fx?= =?utf-8?B?Y1lqcVQrVVM1aVArQ1NDbndHR3Z6eHlhcDZZMWhoR2g5SytjUXg0L3VvTzdH?= =?utf-8?B?UTJjcWRQMU0yU1pvSHVGak9wOTVFNDhGTnlRUnptTFVuR0dpY2xNQVA4RDVO?= =?utf-8?B?R241MEUwNWVrdTAxanB0TkN2QXNHMXhBaFFYaDVBeVFMSUJDUC9GM3BYc2ZK?= =?utf-8?B?K2tnZnYwMWJvRldpWm9hQ2pyMVIrTk5pbVVydTRkVGljRWEvekVJdz09?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4480bc7e-75d7-4849-2965-08de9c8ed9e3 X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2026 14:37:29.1623 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +cJv5uPVNJqeyxYPESo1gTL9UgVMymHQO+MnxNyYfb5NPaZ03BS0hB0fp74ic5xG0uoDSHY4SNw7qqF0k45Ejg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT3PR01MB6209 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/17/26 7:09 AM, Andrew Burgess wrote: > Simon Marchi writes: > >> From: Simon Marchi >> >> All users of iterate_over_lwps_ftype use it within a function_view >> template. Integrate function_view to the type alias. >> >> Change-Id: I3eb23aa3dbc1889072a5d4654e861b00942d6c3f >> --- >> gdb/linux-nat.c | 5 ++--- >> gdb/nat/linux-nat.h | 7 +++---- >> gdbserver/linux-low.cc | 5 ++--- >> 3 files changed, 7 insertions(+), 10 deletions(-) >> > >> diff --git a/gdb/nat/linux-nat.h b/gdb/nat/linux-nat.h >> index 708990acc4d9..42c0467191fe 100644 >> --- a/gdb/nat/linux-nat.h >> +++ b/gdb/nat/linux-nat.h >> @@ -47,7 +47,7 @@ extern tribool have_ptrace_getregset; >> extern ptid_t current_lwp_ptid (void); >> >> /* Function type for the CALLBACK argument of iterate_over_lwps. */ >> -typedef int (iterate_over_lwps_ftype) (struct lwp_info *lwp); >> +using iterate_over_lwps_ftype = gdb::function_view; >> >> /* Iterate over all LWPs. Calls CALLBACK with its second argument set >> to DATA for every LWP in the list. If CALLBACK returns nonzero for >> @@ -55,9 +55,8 @@ typedef int (iterate_over_lwps_ftype) (struct lwp_info *lwp); >> LWP immediately. Otherwise return NULL. This function must be >> provided by the client. */ > > While looking at this change, I noticed that the comment for this > declaration is out of date. This is NOT your fault, it became out of > date a while back. But would you mind fixing the comment as you're also > touching the declaration? It changes completely in the following patch, so I don't think it's worth doing. > >> >> -extern struct lwp_info *iterate_over_lwps >> - (ptid_t filter, >> - gdb::function_view callback); >> +extern lwp_info *iterate_over_lwps (ptid_t filter, >> + iterate_over_lwps_ftype callback); >> >> /* Return the ptid of LWP. */ >> > > Approved-By: Andrew Burgess Thanks, Simon