From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60007 invoked by alias); 19 Jan 2017 11:56:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 59919 invoked by uid 89); 19 Jan 2017 11:56:31 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:909 X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Jan 2017 11:56:30 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id CE1EE1555E; Thu, 19 Jan 2017 11:56:30 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v0JBuT0o011145; Thu, 19 Jan 2017 06:56:29 -0500 Subject: Re: [PATCH] PR threads/20743: Don't attempt to suspend or resume exited threads. To: John Baldwin , vd@freebsd.org References: <20161223212842.42715-1-jhb@FreeBSD.org> <74b6668b-e98e-6034-99bd-fee9834fe9d4@codesourcery.com> <20161227164329.GA43600@nitro> <2893581.89CAWbS1EM@ralph.baldwin.cx> Cc: Luis Machado , gdb-patches@sourceware.org From: Pedro Alves Message-ID: <9eab9ae5-2ca4-6370-cfb1-33a3970f598d@redhat.com> Date: Thu, 19 Jan 2017 11:56:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <2893581.89CAWbS1EM@ralph.baldwin.cx> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-01/txt/msg00376.txt.bz2 On 12/27/2016 09:03 PM, John Baldwin wrote: > I added the assertion for my own sanity. I suspect gdb should never try to > invoke target_resume() with a ptid of an exited thread, but if for some > reason it did the effect on FreeBSD would be a hang since we would suspend > all the other threads and when the process was continued via PT_CONTINUE it > would have nothing to do and would never return from wait(). I'd rather have > gdb fail an assertion in that case rather than hang. OOC, what happens on FreeBSD on the gdb.threads/no-unwaited-for-left.exp test? That test: - spawns a thread - gdb switches to that thread, and, - enables "set scheduler-locking on", and "continue"s. - the child thread exits - gdb should not hang. It used to hang on Linux, until TARGET_WAITKIND_NO_RESUMED was added. Thanks, Pedro Alves