Re: [PATCH 3/3] Avoid GDB SIGTTOU on catch exec + set follow-exec-mode new (PR 23368)

[Pedro Alves <palves@redhat.com>]

On 10/20/2018 04:38 PM, Simon Marchi wrote:
> On 2018-10-20 11:13 a.m., Simon Marchi wrote:
>> On 2018-10-17 1:04 p.m., Pedro Alves wrote:
>>> I think the "for both inferiors" part is what's dubious here.
>>>
>>> The process lives on in the new inferior, but we lost its
>>> terminal settings!  Seems to me that they should be migrated
>>> from the old inferior to the new one.  And then the problem
>>> sorts itself out, because then the new inferior will have
>>> target_terminal_state::is_inferior state.
>>
>> Yeah that makes sense.  This crossed my mind when I look at the issue,
>> but for some reason I didn't went that route.  But now that you say it,
>> it appears obvious that this should be the fix.
>>
>> I just tried copying the inferior::terminal_state value from the old
>> inferior to the new inferior, and it fixes the problem.  But
>> actually, we should also be transferring all of the struct terminal_info
>> associated to the inferior, is that right?
> 
> This would be the updated patch (testing on the buildbot at the moment).

Yes.  Looks good.  I think you could avoid the
copying-with-garanteed-deleting by adding a "swap_terminal_info" function
that swaps the terminal_info and terminal_state between the inferiors.

Thanks,
Pedro Alves