From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id hXETJjW+qmkhuxgAWB0awg (envelope-from ) for ; Fri, 06 Mar 2026 06:44:53 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=fCY2+Qwh; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=fCY2+Qwh; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 7DEDF1E08D; Fri, 06 Mar 2026 06:44:53 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id AF5381E08D for ; Fri, 06 Mar 2026 06:44:52 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 342964BA23CB for ; Fri, 6 Mar 2026 11:44:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 342964BA23CB Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=fCY2+Qwh; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=fCY2+Qwh Received: from DB3PR0202CU003.outbound.protection.outlook.com (mail-northeuropeazlp170100001.outbound.protection.outlook.com [IPv6:2a01:111:f403:c200::1]) by sourceware.org (Postfix) with ESMTPS id 7D7B04BA2E10 for ; Fri, 6 Mar 2026 11:44:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7D7B04BA2E10 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7D7B04BA2E10 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c200::1 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1772797459; cv=pass; b=J3SQ2/ELKhB3JG4kQXrFgUX+NiZrno6sVm6fyv6u8w4SZJjmcJ0KuBEFcEnecb5vW0mZ0syGSRL4htDghH1vtohcDEA5JM3V37NvAm7uPLAFQ+KrvT5FlnHIZ18OOfEFjQvyPurxgAK/ji9fEs1Cc19JDMrr7FD5N8zKIpgWjyc= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1772797459; c=relaxed/simple; bh=MXcuRxOX96QCGaDRqomJ01r6rQoJE5lzeocTaxF/p40=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=pCeu/tamVhDmgei4GO2G9ztpelt1MgAtlDcHv7mFKTqucQcRTbqa/itexPH46p5iU+lqfbChZHZNMVNdJOYsz89jVOrAeiMoYycRTF+EhZAni6/LuR4OBtazdJiIGN9+YNbEhTQPBLCAq/+x4p0OVYbuevjoKz6Iut0yIJEtsVc= ARC-Authentication-Results: i=3; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7D7B04BA2E10 ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=xR2hsXA1cG56YCj8tepWbW5lwYUTKTa+4bB0Q5ROD/53+HD32T93I8ZzyexcVQu4X4ujPs4Zae7rlWswWpZGZxSGdPCCreA0biVUBz5xHtTup5wR2vUm/+zItg/sUmrMFz9AFUQLYgJjg+/m/HUHMRiMwixrjRHbEpovYeqsu2bKNmLP6vVO9w7IdiQuuO2yVp8wxLextqArEPvOGdVI77XTgdlNaS6WswQGgfAVlHUJxn9XvW475wbPwHXtb8+rR2n+4BUFcrHmiXdUvu2HKEbATcT5S8ASxnXAJ50KHmRzdo5ZXuRVV00TkGA27e4D1HnXpWmj+XAFYxsE+irwvw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vfjfQSdtg/XWkkKSnls9hdZrG/IgPJMWuKmU00IqTsE=; b=g1xUMARG9FgcrO7ilLm2/IfDG9im5iwcu666NPCvo7iDb3wOkE16+P+Z1q9cazoI6h1v0n5OsbAUjFotpnAAozz72HQWHEBPsBMfna9H1TDY4B/p9ETN9fl3E9WPULWdMUEp60DpjFQRjpyYP9cyCQDOKZhnX18F1RjlqEm3JBUEYbn+Juj1Vogc3d8wq1sqxksD4u8CamplaiNLjjWh5okZuiU+zw9WGoMvbBZQIKxhDHayWsWdjwzOnMILr38jo2QmNDX7GlYRlOzG1bi+QXy/zWq8EGPEMJF2UtnIRIJwXyH4XLg85CAXlqTS1ExX1aDGb9r14Qs8eo80OrVzfA== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vfjfQSdtg/XWkkKSnls9hdZrG/IgPJMWuKmU00IqTsE=; b=fCY2+Qwh+QilOL3OR6AM4z0Zv0duj7d8oyTwQsNWODXLQZT8WQ43/ir90LEE3i7usbnJarlxioYsyifiYfh8sISc1I6BlWtsnkbB51aYijlhGqnsXiWP8wHmc2SCWtLOL/HEVy6/Xdd4dbjGBk76bXu8c9XkNGSNnt9AGKM+sKQ= Received: from DU7P189CA0028.EURP189.PROD.OUTLOOK.COM (2603:10a6:10:552::33) by PA6PR08MB10647.eurprd08.prod.outlook.com (2603:10a6:102:3c9::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.22; Fri, 6 Mar 2026 11:44:13 +0000 Received: from DU2PEPF00028D0D.eurprd03.prod.outlook.com (2603:10a6:10:552:cafe::14) by DU7P189CA0028.outlook.office365.com (2603:10a6:10:552::33) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9678.18 via Frontend Transport; Fri, 6 Mar 2026 11:44:13 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by DU2PEPF00028D0D.mail.protection.outlook.com (10.167.242.21) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9678.18 via Frontend Transport; Fri, 6 Mar 2026 11:44:12 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=A6bdiEmcMAX7KGxDE4KlEWtXNFcuV0x6vWDLNu2/yiXXcaCrNBbC6npK03Qmw4/Y38PSzp2dhUpZBH3rNYJE6F2+v1hxe90zujxOu9rk4SD5cY5SjEN4N4IRhaLtLBykyBrET8G/0+bu7tGo3sLidt0IDqNNP11ciRNnMJO3ONJchYmrRAAs+4CllNV/O3vzBDt6POVQUg6badDjHqpBH8F6BPD6g6F2hCIJOa9x/GLFhU/P1O209Qoz/hTMl78yruZ872TB42WRhSqzqlSMrE2gLPpjQJNlOLrdkLAdMQFvpTR7bW1G3B+6JRtaKstfDvU6nWrdTqouBP2RyNYK5w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=vfjfQSdtg/XWkkKSnls9hdZrG/IgPJMWuKmU00IqTsE=; b=DXE/ikq/dhPibn+JBxE79KC5UcLFJKjgXkl1iTbzW415AFdmZBOedrD5iytgoj784ZyQ7oCBLa6lt/sFKSi/PQwKii8sft06vJVNAZ7ZGMcssFFPqYsgLI1JKDYIsDiIUCTY8ghcTHDHk7ufYeTyIB4qA/nPu+3eDOElNxD8d1/k1XuQOlx/3N6d0tVg1g8ucRFjVKBU3/r5P6xditrd3g0q9d13otP94SSyqpqstp60gOuFY7Zn/6MRhP407rFGCYeKk4QYQZrAa2Y7RGsWjvHP+61xRZoOjy1G6dkV2nx/M3eU3JnrMWECN7zvNW6QriRHfg0wBV7nmgB70rv5Cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=vfjfQSdtg/XWkkKSnls9hdZrG/IgPJMWuKmU00IqTsE=; b=fCY2+Qwh+QilOL3OR6AM4z0Zv0duj7d8oyTwQsNWODXLQZT8WQ43/ir90LEE3i7usbnJarlxioYsyifiYfh8sISc1I6BlWtsnkbB51aYijlhGqnsXiWP8wHmc2SCWtLOL/HEVy6/Xdd4dbjGBk76bXu8c9XkNGSNnt9AGKM+sKQ= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DB3PR08MB9010.eurprd08.prod.outlook.com (2603:10a6:10:42b::8) by VE1PR08MB5869.eurprd08.prod.outlook.com (2603:10a6:800:1b2::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.19; Fri, 6 Mar 2026 11:43:07 +0000 Received: from DB3PR08MB9010.eurprd08.prod.outlook.com ([fe80::f37c:c9c2:6d9a:9543]) by DB3PR08MB9010.eurprd08.prod.outlook.com ([fe80::f37c:c9c2:6d9a:9543%5]) with mapi id 15.20.9678.017; Fri, 6 Mar 2026 11:43:07 +0000 Message-ID: <9e55cebc-d0b4-4ea2-95ef-0acf6eeb2217@arm.com> Date: Fri, 6 Mar 2026 11:43:06 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/9] gdb/python: allow ref_ptr::new_reference to accept subclasses of T To: gdb-patches@sourceware.org References: <20260303161659.397427-1-matthieu.longo@arm.com> <20260303161659.397427-6-matthieu.longo@arm.com> <87v7fcrd2x.fsf@tromey.com> Content-Language: en-US From: Matthieu Longo In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO2P265CA0435.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:e::15) To DB3PR08MB9010.eurprd08.prod.outlook.com (2603:10a6:10:42b::8) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DB3PR08MB9010:EE_|VE1PR08MB5869:EE_|DU2PEPF00028D0D:EE_|PA6PR08MB10647:EE_ X-MS-Office365-Filtering-Correlation-Id: 50f5864c-4835-48bf-9213-08de7b75b01d x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0;ARA:13230040|1800799024|376014|366016; X-Microsoft-Antispam-Message-Info-Original: p+3cEx4ba9wheovpGMFdljTF/cYRc6cjjr9296VmrVA4nrYNeN0o189ue8bJwusKE4eUile4S8clXSS0aK9TFu+gWPbvXN2Udl813T8MGgkC/v6xoS/6cP48nRIVlxUdUagQiE96wDEDPJaiDGBvyoMeOuPhhmNSfEYWmEgxH1lhugaWpwYeJhDQZb8tbRJiw4vASDTJJGyIwTl2vstAQSpLhWbZrpin9GxSwoWcgQxPH31i6AvLx6AxHGv5hW+sqCeZVF3kgUHtOjTpH6P4tP6AmbpedyyfrFkt/COy3SpaYIIvgp3Lb8q48d2EaPQOWgNykrOViABqXqJLDgHTATDZTsljS5qDk8oNHSt5DqmnnsTUVZtO5c8iik7+ZfAqO1YpotBJBFqk3TnHaIoXrlgkX5yFfhcHjjY9N+ZXY3ct/A0NF3gr3IHyzAaHvqaH+4lWkZXg+lNOf0oYmpwJhb+Kj0xMnLA1ipX4FSExYSYkeAC+Az6SIaQFjPPqGNhGFPxTPnl94YIgfliVEXc5u1ILJB4jdtztfepFITYzSYu3ketDdkJOM41HToN+FhRCaiY7xp245UzOl7NS9sZ1GID6XO91E6gp3QfPlI6a9RG6wRkDJK7sQZXjplbCa0z03cf/pOR3E0yDEj1dO3eosWSk+Enu96wFtDRhsW0ul1vmK6z0nMPxdbUsHeHNu5i/9Pvv34RlOV5sW/7SFZc26xj8ccnsUx7Qz4yxI6EwrYw= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DB3PR08MB9010.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(1800799024)(376014)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: VE1PR08MB5869 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU2PEPF00028D0D.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 1c0e5c8c-d35f-4aec-4b97-08de7b7588d7 X-Microsoft-Antispam: BCL:0; ARA:13230040|14060799003|36860700016|35042699022|1800799024|82310400026|376014; X-Microsoft-Antispam-Message-Info: 98ruoFjzWLbT4efMYMc3JjSAeBaEIQbUlkJEF9zMv94Ow2EgBe3WYZ8604wHmztiCh9cHD/D+JlV3FOfRo4HQH8a6lSoUPkQY8W/jO3ZwSMdfUlR0BVQA//QMFzvQlaroZvlMMOkFqwGISjUoh2CHiFsiPpOkNlLXcsCKLdwqfhknx4H1Txqrh3dHtXvYynJ5WDZSwG8a6gQnFNbCuQKEupVdU03ZGo57OV7wlEfflHCzUHwxAvsbCLa9d6HCy2+BjYkBDJ3apHkkqtJGNy2nelJDYT5ceaJn8401G+WBn+yN+kuivslQROwDXyuCz4bLj93qfLaRm7qw67x9fJWO6z/0yNYvTHtNTP62mnxX+7TMq6uOiTNowwPo14Njm9tf9IRostCCpdYjWm0L50dlypJBU2ikeX3rTslGHaP07//4omXDTUmGkKyi/8PTZWDKzN4DaTvRMP2JilhCI82y1u1VzpIOB0cucHxuQjVZyC4hyVxSGCD6oV6Bemh2keVQicne8fNjzpt5USVcUprmju5TAOkA0BaABywob7IvJZn7/a+8CrPNVPo4IDcmNWwwBvPxdcv/GW+FXJF5Dw1wUhg4/dPPhtW57eFDOqdaqV6uCz22sGkCvSKtanljpn0MWnNFyg2MzK0oT5UN/VsajXpEhSVTRJXCXj8ux/Pba7dyuMKvSa5LEUxFbjSBaW0oT7Af3waKKKcfxRgGDXYNCwRlJzVWldkFDZMqyMhKOnyHVw4FgPthknSq0vLEnL6Hxh8+by+hONq43moeL8kAg== X-Forefront-Antispam-Report: CIP:4.158.2.129; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:outbound-uk1.az.dlp.m.darktrace.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(14060799003)(36860700016)(35042699022)(1800799024)(82310400026)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: phEZA8Fnl5qrzt7szj5WUGJhWe2pFO/x1JMRUJFQHcKA/VHz1BM8oA2aqxEBuEcvL+M49/8DzRHLPrz4udfFE+Eutvh5kliE7ucxKQc9iZ9w4NJB7ovopmdatCOye2NmSldVL9s/1wyOvrnfg4UcZFcsdOQQXWAmcSVa2kUuC0jbngIGxzAlrNsWMIq05nguyluHOOWXdSOEPmxxjVnfulKaalW/fHK9UfvPyw/VCyugIfA40zTUZPuuP62j3ZW/daAkuRHq7ZMkcx9xOdjE4KG3j1OACzx5hM37Sy9XwKfLo68GsTCh1kfRFq4c5KFx+FcekWq0/iX2U+2VTQZjChSF1LqNdeCM2VUFpSaB8X4XkCPo0HbnHuYL4L5eR+hN8YpluUwAzNdCDqlUFebZ5VRgHFOUSiI6rd4I5nqRf3kJk95XbB6Mdtc0KYd84Gm1 X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2026 11:44:12.8937 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 50f5864c-4835-48bf-9213-08de7b75b01d X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[4.158.2.129]; Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: DU2PEPF00028D0D.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA6PR08MB10647 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 06/03/2026 11:37, Matthieu Longo wrote: > On 03/03/2026 18:18, Tom Tromey wrote: >>>>>>> Matthieu Longo writes: >> >>> When ref_ptr::new_reference() is specialized for 'PyObject' >>> (i.e. gdbpy_ref<>), it currently requires the argument type to be exactly >>> 'PyObject *'. As a result, pointers to subclasses of 'PyObject' must be >>> explicitly cast before being passed, making call sites unnecessarily >>> verbose. >> >>> This patch makes ref_ptr::new_reference() a template method >>> that accepts both T and subclasses of T, performing the cast to 'T *' >>> internally when needed. This removes redundant casts at call sites >>> without changing behavior. >> >> See this series >> >> https://inbox.sourceware.org/gdb-patches/20260221-python-ref-simplif-v1-0-5b06f48d3096@tromey.com/ >> >> I can land that this week if it's convenient. >> >> Tom > > After a deeper examination, I am not sure that your series helps much for this patch. > > * Case 1: return value from the registry. > > PyObject *result = (PyObject *) cfpy_inferior_corefile_data_key.get (inf); >   if (result != nullptr) >     return gdbpy_ref<>::new_reference (result); > > If I had gdbpy_borrowed_ref available, I could replace the code above by something like: > gdbpy_borrowed_ref result = cfpy_inferior_corefile_data_key.get (inf); > if (result != nullptr) >   return result; /* assuming that gdbpy_ref<> would have a constructor taking gdbpy_borrowed_ref. */ > > > * Case 2: registration of the new object in the registry and return the value. > > gdbpy_ref object >     (PyObject_New (corefile_object, &corefile_object_type)); > ... > cfpy_inferior_corefile_data_key.set (inf, object.get ()); > return gdbpy_ref<>::new_reference (object.release ()); > > I could change the code as follows, but I am not sure that it makes the code more readable. > > cfpy_inferior_corefile_data_key.set (inf, decltype (object) (object).release ()); > return object; > > If the registry was storing gdbpy_ref instead of 'corefile_object *', I guess that it could be simplified even further to: > > cfpy_inferior_corefile_data_key.set (inf, object); > return object; > > What do you think ? > > However, I am getting further from my original objective, which was only flattening the code for upcoming changes. > All those improvements seem to me out of scope of my original patch. > > Matthieu I realized that my response might be unclear. I forgot to mention that the code I am referencing here is part of the next patch. Matthieu