From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 119160 invoked by alias); 23 Sep 2016 13:59:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 119111 invoked by uid 89); 23 Sep 2016 13:59:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 23 Sep 2016 13:59:46 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F17E7485; Fri, 23 Sep 2016 13:59:44 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8NDxh0Y005327; Fri, 23 Sep 2016 09:59:44 -0400 Subject: Re: [PATCH] Consolidate target_mourn_inferior between GDB and gdbserver To: Jon Turney , gdb-patches@sourceware.org References: <1473655918-2101-1-git-send-email-sergiodj@redhat.com> <87h99cjzd0.fsf@redhat.com> <03f09c13-9fec-ee9a-adf9-95e9f0e81b91@dronecode.org.uk> From: Pedro Alves Message-ID: <9e48a7d7-49ed-c753-f4f3-8b63adbb734d@redhat.com> Date: Fri, 23 Sep 2016 15:45:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <03f09c13-9fec-ee9a-adf9-95e9f0e81b91@dronecode.org.uk> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-SW-Source: 2016-09/txt/msg00305.txt.bz2 On 09/23/2016 02:17 PM, Jon Turney wrote: > This seems to miss one use of target_mourn_inferior() in windows-nat.c. > >> ../../gdb/windows-nat.c: In function ‘void windows_kill_inferior(target_ops*)’: >> >> ../../gdb/windows-nat.c:2467:26: error: too few arguments to function ‘void target_mourn_inferior(ptid_t)’ >> >> target_mourn_inferior (); /* Or just windows_mourn_inferior? */ >> ^ > > Patch attached. > Thanks, please push. Pedro Alves