From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 76710 invoked by alias); 29 Jun 2016 09:53:12 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 76677 invoked by uid 89); 29 Jun 2016 09:53:11 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 29 Jun 2016 09:53:10 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 57E5012B39; Wed, 29 Jun 2016 09:53:09 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5T9r8Eb002886; Wed, 29 Jun 2016 05:53:08 -0400 Subject: Re: [PATCH] Set unknown_syscall differently on arm linux To: Yao Qi , gdb-patches@sourceware.org References: <1467105996-18063-1-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: <9e39007b-b89a-4f54-02f3-fc76a77f91cd@redhat.com> Date: Wed, 29 Jun 2016 09:53:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <1467105996-18063-1-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-06/txt/msg00497.txt.bz2 On 06/28/2016 10:26 AM, Yao Qi wrote: > Currently, we use 123456789 as unknown or illegal syscall number, and > expect program return ENOSYS. Although 123456789 is an illegal syscall > number on arm linux, kernel sends SIGILL rather than returns -ENOSYS. > However, arm linux kernel returns -ENOSYS if syscall number is within > 0xf0001..0xf07ff, so we can use 0xf07ff for unknown_syscall in test. > I think it'd be good if this was converted to a comment in the source. > --- a/gdb/testsuite/gdb.base/catch-syscall.c > +++ b/gdb/testsuite/gdb.base/catch-syscall.c > @@ -28,7 +28,11 @@ int pipe_syscall = SYS_pipe; > int pipe2_syscall = SYS_pipe2; > #endif > int write_syscall = SYS_write; > +#if defined(__arm__) > +int unknown_syscall = 0x0f07ff; > +#else > int unknown_syscall = 123456789; > +#endif > int exit_group_syscall = SYS_exit_group; > Thanks, Pedro Alves