From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5213 invoked by alias); 16 Dec 2019 19:27:59 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 5204 invoked by uid 89); 16 Dec 2019 19:27:59 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy= X-HELO: us-smtp-delivery-1.mimecast.com Received: from us-smtp-2.mimecast.com (HELO us-smtp-delivery-1.mimecast.com) (207.211.31.81) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Dec 2019 19:27:58 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1576524477; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=p/WC4qwU+usaL9CZARg2whgYnpRUY6RXIvAQaFc2n4Q=; b=E1+UJeGWKRQ1CDnuD+V3KXpwQc/gcuXJZIm3lx/bQYYa6Jv1OB1w4L57ZZwL/e2P5A/I3F OT7oSDkpDqmHnPlZQ54/njzHfIY8tSgNo6Yjip2bgd7y5qZrLLtMbMfm8Ry9Lvx+1W+avc B3FtRYIs3xkJM9BL34uNrEm1kIwukII= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-363-AI7VuBbfN7-t7_i-uSVhTg-1; Mon, 16 Dec 2019 14:27:52 -0500 Received: by mail-wr1-f70.google.com with SMTP id y7so2863434wrm.3 for ; Mon, 16 Dec 2019 11:27:52 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id y20sm362978wmi.25.2019.12.16.11.27.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Dec 2019 11:27:50 -0800 (PST) Subject: Re: [PATCH v2 0/5] Fix and cleanups in jit.c To: Simon Marchi , gdb-patches@sourceware.org References: <20191216033917.2936248-1-simon.marchi@polymtl.ca> From: Pedro Alves Message-ID: <9deeca6f-f280-c8bc-f09b-ba422a91f016@redhat.com> Date: Mon, 16 Dec 2019 19:27:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20191216033917.2936248-1-simon.marchi@polymtl.ca> X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-12/txt/msg00717.txt.bz2 On 12/16/19 3:39 AM, Simon Marchi wrote: > This is a follow-up to: > > https://sourceware.org/ml/gdb-patches/2019-12/msg00568.html > > Again, the first patch is a fix and the rest is some c++ification. > > I think I fixed all review comments from v1, the biggest change being > the use of std::forward_list instead of std::vector. Thanks, LGTM. Pedro Alves