From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kWHzC/HEvl+lGAAAWB0awg (envelope-from ) for ; Wed, 25 Nov 2020 15:56:17 -0500 Received: by simark.ca (Postfix, from userid 112) id 2462D1F0AB; Wed, 25 Nov 2020 15:56:17 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=0.3 required=5.0 tests=MAILING_LIST_MULTI,RDNS_NONE autolearn=no autolearn_force=no version=3.4.2 Received: from sourceware.org (unknown [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CA3D51E776 for ; Wed, 25 Nov 2020 15:56:16 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E32B23870880; Wed, 25 Nov 2020 20:56:15 +0000 (GMT) Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 4C4CD3861810 for ; Wed, 25 Nov 2020 20:56:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 4C4CD3861810 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id B0DC21E776; Wed, 25 Nov 2020 15:56:13 -0500 (EST) Subject: Re: [PATCH 12/12] gdb: use two displaced step buffers on amd64/Linux To: Pedro Alves , Simon Marchi , gdb-patches@sourceware.org References: <20201110214614.2842615-1-simon.marchi@efficios.com> <20201110214614.2842615-13-simon.marchi@efficios.com> <7040e2ee-4d28-a83e-22df-20b2ace082bb@palves.net> <88518922-ffb6-f221-f3b8-569c5577ae5a@simark.ca> <91426053-1ce6-3154-3635-cef5390248f4@simark.ca> From: Simon Marchi Message-ID: <9d717009-facf-66b8-6846-e687bee2ad1d@simark.ca> Date: Wed, 25 Nov 2020 15:56:13 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <91426053-1ce6-3154-3635-cef5390248f4@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Language: fr Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-11-25 3:07 p.m., Simon Marchi wrote: > We still have to figure out why the performance regresses compared to > master. One thing is that we still do an extra resume attempt each > time. We do one resume where the disp step prepare succeeds and one > more where it fails. That's twice as much work as before, where we did > one successful prepare and then skipped the next ones. I'll make an > experimental change such that the arch can say "the prepare worked, but > now I'm out of buffer", just to see how that improves (or not) > performance. That made just a small difference. Let's call this new patch E: #9 + A + B + C + D + E: 105,727 Simon