From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id xYZqIV2IDWoUDwoAWB0awg (envelope-from ) for ; Wed, 20 May 2026 06:09:33 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=UKv04+qS; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=UKv04+qS; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 761541E098; Wed, 20 May 2026 06:09:33 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3FF271E062 for ; Wed, 20 May 2026 06:09:32 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2768A4B92097 for ; Wed, 20 May 2026 10:09:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2768A4B92097 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=UKv04+qS; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=UKv04+qS Received: from DUZPR83CU001.outbound.protection.outlook.com (mail-northeuropeazlp170120005.outbound.protection.outlook.com [IPv6:2a01:111:f403:c200::5]) by sourceware.org (Postfix) with ESMTPS id 82FD24BB5912 for ; Wed, 20 May 2026 10:09:01 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 82FD24BB5912 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 82FD24BB5912 Authentication-Results: sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c200::5 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1779271741; cv=pass; b=UmnLZ831LYcr7v7vAhpSbiT1d2Wadt5+amNGklsfUOmsVzsoTZ9M+1D+kfFDDSAzEEin1PgPm6k2s33gdh9RXIFVWiz6kmVh86MzdgiQsvJKvli/k3GMzRJe6zt+eUackzbQK5YGqgIQOXKIjCC85DN/XFGd146xDavX2c7ubGA= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1779271741; c=relaxed/simple; bh=A4/a+90IDykyfTzTPIF2MBaBlW3I5CzVj6XbUWiZfzQ=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=JLnUjXoJQ19W6B1hWTZwCFNRec+SfFhT7zGwMeSKDqDaZf6JHF5wmFNAbwB+mC7o+7iodMg97RW2SbTN9C6zDHKgjgZVWiPDNb8sFQTU0KAm/boAloovHdgyB3ssvFyHbg6z6CeLsZTYn8LSKDVot5WGvM6h6cOqPc6rmMDWHm0= ARC-Authentication-Results: i=3; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=UKv04+qS; dkim=pass (1024-bit key) header.d=arm.com header.i=@arm.com header.a=rsa-sha256 header.s=selector1 header.b=UKv04+qS DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 82FD24BB5912 ARC-Seal: i=2; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=pass; b=cbj0RJJs2bMpk4yfDvcWyJcCZcgnzxq9moDrwuLHIL9QKIfCfpWgO9RnPB9XB44F1SObdjKsUp9KppdFFokrqiGJ/E2LyCWqIk7Iw29ruK6FloiKsWJ6Qica5zUbNZ0XuRbqvj350/7CpgvEL7gURBNRORKR5SgVG6cBLsb7F5rEGIIKrrS/FTYaMTLte+1hGp7IYwfDIXUGjTXCLiWPItBfV6IfBJvZ76chZUnZECLVg1IKmkmfTR3Akm8oEYJuIGW2lLVXtLdj8crF3BPK0JHoKCBaLTOwblcYqppTlzj6EPKtik3tAIIrNJe8KETxyYNIWhwGHLU6whgs229adA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uB/tNe5anT0ef96knfuEtCpY8274pclp6kIkBRmm0d8=; b=nQi3m8wDtGRF9tJKXnRcivcxBl2urN33XRh8ZmTx3FN8ENHq2V3XW3CJQ0ZV5CmGQX/RI3BBgs0MG7LbEJo+qzzWtgsmpEu4KI5QngVP9ThI14JNRkyN+WiwgQONfPPMt6vseKf81Bzny1elVlR4ER0mJaO9eyb+Xq3PLM3YukRuhWZLKEUWvchlCpDPgNheI2bI2L5a29nI2tJQymrF7+N9erTUXEPPGoOjxgqnaDyO3pEsE8cbemZbYBNyOINRn9315O4OQCwJJKrYo7fI5x6ZXGMWZmEb+c1U/Z6mCG/TfzmqWpWl43Bz+MPgqablW+JEHe7AU0mpdK4vumddtQ== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 4.158.2.129) smtp.rcpttodomain=tromey.com smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=arm.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uB/tNe5anT0ef96knfuEtCpY8274pclp6kIkBRmm0d8=; b=UKv04+qSLMKKNP34cXbvBxXumFQnD/yKPQVnIqd2cqDRcA4rOEFfv/3WcDtWw47TRV37dx3aEusXvNk+lSwkAqD3QoclmDBb/K4YOG9q7ia0Zs5ot96jaZMaO8N3CTYi/twf4qorPSqefLKe9iwbPEIDFTIvDvhp7Ke29J0upBg= Received: from DB9PR01CA0009.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::14) by FRRPR08MB11967.eurprd08.prod.outlook.com (2603:10a6:d10:1d1::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.25.24; Wed, 20 May 2026 10:08:52 +0000 Received: from DU2PEPF00028D00.eurprd03.prod.outlook.com (2603:10a6:10:1d8:cafe::63) by DB9PR01CA0009.outlook.office365.com (2603:10a6:10:1d8::14) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.48.14 via Frontend Transport; Wed, 20 May 2026 10:08:52 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 4.158.2.129) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=arm.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 4.158.2.129 as permitted sender) receiver=protection.outlook.com; client-ip=4.158.2.129; helo=outbound-uk1.az.dlp.m.darktrace.com; pr=C Received: from outbound-uk1.az.dlp.m.darktrace.com (4.158.2.129) by DU2PEPF00028D00.mail.protection.outlook.com (10.167.242.184) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.21.48.11 via Frontend Transport; Wed, 20 May 2026 10:08:52 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=MvAFU3FOGC2vMQsPsgdrxlB7RlwbZ3AMon5r9ilcwsoR6hZ2SCJqbVge/1PCK1GgtHBmmAi9a0u2ExoT7q6c8FYbU897jW5R3/0WdBN3WTzMa8rO7cS3WHT0SwRL8ddrBqGYhUhTUukEwn5Jxwn3QrVeanmXiGmV6cfo41zuH190FujM0H2jD0UUWHP1Fq4q8eiDefJ7/HVa28q0aDDt1F29WJXCOqPE9+8aWLhBes0oGOK764/IeN/mvqDEhwXAYeQu7BAVTuQfVwso+SLRwy0C0shIhSvYvpxK2vTCPFGzxcSnTxjvPzrY/GDqGd3CgOspuUZrjeCsBcPqXBAv8A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=uB/tNe5anT0ef96knfuEtCpY8274pclp6kIkBRmm0d8=; b=PY3nQJsfgpSpJjBcz4/zu9pdSHXbXzJMBFYPLczm6aE+l7PBYV8IU1tOXpGlk7XP2MSA7sQmh1mD4/AbG5sux5Y5/7ONc/B6IfiCigIp5TJJbXJS/uD8JL9VEJxEOsHE2ekwafd2QMxHqJYxnwzCej5Rl4Z3FC9gM1KsVGDAJpdYx/u+8ULTTjX5IyF4zy62nBuUlwKNTvglOIGOx2D+Qrlq2uxdZxhoFMg/qr8s0lN83GtoNWSzSVesZXaxqmkHzEX5bX0vArJviU0wNUc44ZMiV3EcpiYnUrpOuSNCDRWVYBs/SWpAhm+bWr+0WvTBjWWNbBskxJvKTIMnZpQZ1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arm.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=uB/tNe5anT0ef96knfuEtCpY8274pclp6kIkBRmm0d8=; b=UKv04+qSLMKKNP34cXbvBxXumFQnD/yKPQVnIqd2cqDRcA4rOEFfv/3WcDtWw47TRV37dx3aEusXvNk+lSwkAqD3QoclmDBb/K4YOG9q7ia0Zs5ot96jaZMaO8N3CTYi/twf4qorPSqefLKe9iwbPEIDFTIvDvhp7Ke29J0upBg= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from DU0PR08MB8663.eurprd08.prod.outlook.com (2603:10a6:10:401::6) by AS4PR08MB7405.eurprd08.prod.outlook.com (2603:10a6:20b:4e0::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.21.48.14; Wed, 20 May 2026 10:07:48 +0000 Received: from DU0PR08MB8663.eurprd08.prod.outlook.com ([fe80::f957:cec9:ec8d:7968]) by DU0PR08MB8663.eurprd08.prod.outlook.com ([fe80::f957:cec9:ec8d:7968%2]) with mapi id 15.21.0025.023; Wed, 20 May 2026 10:07:47 +0000 Message-ID: <9d2b5df3-1d30-4ce1-93eb-87bb52ad1d0f@arm.com> Date: Wed, 20 May 2026 11:07:44 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/4] gdb/python: eval_python_command returns result of the evaluation To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260428162416.511367-1-matthieu.longo@arm.com> <20260428162416.511367-3-matthieu.longo@arm.com> <87cxywipkx.fsf@tromey.com> <87lddfb3ts.fsf@tromey.com> Content-Language: en-US From: Matthieu Longo In-Reply-To: <87lddfb3ts.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: PR1P264CA0080.FRAP264.PROD.OUTLOOK.COM (2603:10a6:102:2cc::18) To DU0PR08MB8663.eurprd08.prod.outlook.com (2603:10a6:10:401::6) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: DU0PR08MB8663:EE_|AS4PR08MB7405:EE_|DU2PEPF00028D00:EE_|FRRPR08MB11967:EE_ X-MS-Office365-Filtering-Correlation-Id: 03ba41d6-3e9b-4536-6850-08deb657cb4a x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; ARA:13230040|366016|376014|1800799024|11063799006|4143699003|56012099003|18002099003|22082099003; X-Microsoft-Antispam-Message-Info-Original: PhX2tB3BLY6T96YSrOoqU+A1Sn5rzoTrETB7boi4Lu2/4A9itqj4YrP3QDkiqUay9OsXSSwo0R6f2d957YGQSxk4ggRPIdxyIzz043xbgIwo8AvITshjkRPhpVKPyCSN6w6DpHm4H1c2mdB2yrJJxnlwXD9DMKP3m0s2i0LhJr3gQwOJr55NLZ4VOz/OBC9D2tbZppA6dTRnZWyKqnryllz1rJ6S5hGjKNjeDRVc3Fp08Gsx/Vp1MgosYFscUvrJY4pWlSjo1LzBXO4P8GovG6XoU/qLbCl5SYyoS6/3gqHJ+wV4nXogDwvTYNU4avC6f8JZjg2huBHzdsN5+Wg+tZ1/GxYmJ/qFQUEX5vphJPxuqcNEIgZMZObEk73gvKhX4bufnkK/GFNkF1ZmJwz4t6ImIPw/yPLBR3Kn9nGFiWnJ9VzP8bvKb0mFvYpoVktQS9QVrh2ICpLI6pDbQdZY41S9g4Raz9gPmBJnwV3oRbTVfy5f/FOmGXU4jSMxb1Op8BNcg74ulxeULGr4+K8Uk/Y8f9t/XSJF8i8pCLGF7PQZH+hMnpoN+zm01yfCAnhQ02lQGps02c5u7NWPTz8u45XIBj+B0zK+xR57hGaI6VyuysHQ4BXHLzwbEct8TkJMtD95LbIBcdZ8Go9U1jJCncDNSMXT91e9xyAn6BAHqAPJk62/3S8hyajYSI4EZ7zZ X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DU0PR08MB8663.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(11063799006)(4143699003)(56012099003)(18002099003)(22082099003); DIR:OUT; SFP:1101; X-Exchange-RoutingPolicyChecked: cmlX8XuiLGEpoRWy+JrpI4MHEXO0v+esOytnmgaKmJzKWp4THZH8oEdmzjEl/chluqvUwyOoZn/zaOx1mkNkricVY0x9/IXc1aBuWmzdEQrPrd3V6/7t5ZWoTvgbCWfQPV5dVxXzBcL/1c+4MItiSmEsPRXubuv/ubxJt0kSvJOEO+htUDvKzpO2XloqqiflPvTYr2UOQofnLo6oV1GQOXrpxn+35FPgOfvuVL6BmZdxtJ1YMBupMFN39lxRHx56HRMysgx5zWQUZUXGjAVM9ImbS/iY5nbQ/6i9wDJ60+461zfjzV9WRqCQk2sEPcUUgc4y+eNdUFsbK9O33FWIRg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: AS4PR08MB7405 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: DU2PEPF00028D00.eurprd03.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: f0c3fd54-81a7-407d-ab64-08deb657a3d5 X-Microsoft-Antispam: BCL:0; ARA:13230040|14060799003|82310400026|1800799024|36860700016|376014|35042699022|4143699003|22082099003|18002099003|56012099003|11063799006; X-Microsoft-Antispam-Message-Info: PI2fQ5DkER3XjFQ1cfnl6kAPgZDs/1ro2BcDm75LRDIYfkU8dTpqC5T+1Zmp5BfIWNis8eDPw6cwQHecSJc11Xp5Tvk3YfiI4QZASX9QpTrJc90GjinkTSSgxEiUAycfWduZBeIM2opUFUknMHoyipTlqUpvf0PRbo2yAtrlIKMemO0ZPoargF7EGzaylckbdH1VAVp0cvAhoprb+UVT/GqTQmjdGwSuY15eomt4xBPP346zVQKoLXan8w6aWyc548JrgxMJ80S4KSiay6pGk/6Wcw9OQDHaii0W91z2icowNWG9kEivulBPFXOZ+PzSpIXO4dJtgDFE8kanslO0IHvPSZmDrNffXMltF7XlKhjOvPOu1LOTLINeXfoWWoiNp8ZuXR3nnsICPjYabJy/Zni+VXV6NOtUf0OnObGSidLrmSvqVOdJ1zKrPqC4C7vYBTlSDqPl30oWzz7yKrVAsTIl0b5PqfVaLpoCJfqlZaIO8hwtdcQLGPns+SprM2nYCYiL7tkh6AG7OWTaKWg/yz3d+cOIktxLlT2aV1rrBqng0oflioWrZrpm7SY3KblTe4dj335fi+XPw9DViOs+8vS/bdDjdIqomE0lPBXvqtnWrP4236KER4NylKlLdcAvSUnPfXT3sw3FX23bzhpEMH1B4DQo2tcX9BN3RdDoxYHWX7COyvPNgtElsw9YbFbXXvn3zyF7YvzihxC5GKp16A9DvHsh5wTgDmNZYgfD0Bo= X-Forefront-Antispam-Report: CIP:4.158.2.129; CTRY:GB; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:outbound-uk1.az.dlp.m.darktrace.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(14060799003)(82310400026)(1800799024)(36860700016)(376014)(35042699022)(4143699003)(22082099003)(18002099003)(56012099003)(11063799006); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: mzUk4CyfVHI1kFRFjCV7zoDeR47/QsUVnhSlfaclLiEvlddhk18bJfJCMxLqW02GSB/dReW/0R3ZER8uJ0ya03pvZcxPJ6fG4ggYgoJYsC/7H9NjzgCEeGo/Ftxu0m0L6DeYmRL32vgj8lo9fBvEvvGbfUN0v9CXSyMzhpsM/gJBbtAvYy92eH4DmU7hb37dzodMScRkq2oevXabaY7u21uVTlgsqV/l8I2GP612OQA1A9LjjWRlFF6/v/omA2jj3wlbWqxZAJZZxFFFCOVO3fKRREcolKPZdCqhjktGYA0FFDCpVXOn6V/+xSXaQrvHsEsN+MzLAPhK4KB/DpjoA7WDp/Fotjszjfu/zpifyswrV+f8UJoezS61D6iqCVtuYFTem1/TS7F0YmqE1nIgRWwTl98MqEP0TrR5LriT4v1FRIXmaUU9QhwwXx4xaSgc X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 May 2026 10:08:52.1670 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 03ba41d6-3e9b-4536-6850-08deb657cb4a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[4.158.2.129]; Helo=[outbound-uk1.az.dlp.m.darktrace.com] X-MS-Exchange-CrossTenant-AuthSource: DU2PEPF00028D00.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: FRRPR08MB11967 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 19/05/2026 20:24, Tom Tromey wrote: >>>>>> Matthieu Longo writes: > >> (1) >> if (eval_python_command (...) == nullptr) >> VS (2) >> if (! eval_python_command (...)) > >> As you can see below, (1) is significantly more verbose than (2) and >> makes more difficult to respect the "80 characters per line" rule. > > I'm probably not the best person to advocate for this, since in olden > times I routinely wrote checks in the concise style, but anyway I think > the rationale is that of the competing interests at play, being clear & > explicit wins out over formatting. > >> - if (eval_python_command (code, Py_file_input) == 0) >> + if (eval_python_command (code, Py_file_input) != nullptr) > > Should this be == nullptr instead? No, eval_python_command() returns nullptr on failure, otherwise the result of the evaluation. Previously, 0 indicated no errors. If the evaluation works, PyOS_ReadlineFunctionPointer is assigned. So the change looks correct to me. > > thanks, > Tom Regards, Matthieu