From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-143662-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 96378 invoked by alias); 23 Nov 2017 12:54:28 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 96351 invoked by uid 89); 23 Nov 2017 12:54:28 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.7 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,KB_WAM_FROM_NAME_SINGLEWORD,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 spammy=spotted
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 23 Nov 2017 12:54:27 +0000
Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id EFAF71E2F2;	Thu, 23 Nov 2017 12:54:25 +0000 (UTC)
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by smtp.corp.redhat.com (Postfix) with ESMTP id 54F706199B;	Thu, 23 Nov 2017 12:54:25 +0000 (UTC)
Subject: Re: [PATCH] C++ify osdata
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
References: <20171118233827.7418-1-simon.marchi@polymtl.ca>
From: Pedro Alves <palves@redhat.com>
Message-ID: <9d0b9473-1fd5-8310-0cde-8233efed58bc@redhat.com>
Date: Thu, 23 Nov 2017 12:54:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20171118233827.7418-1-simon.marchi@polymtl.ca>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-11/txt/msg00534.txt.bz2

Hi Simon,

I think I spotted an issue here.

On 11/18/2017 11:38 PM, Simon Marchi wrote:
> +  /* This keeps a map from integer (pid) to vector of struct osdata_item.
> +     The vector contains information about all threads for the given pid.  */
> +  std::map<int, std::vector<osdata_item> *> tree_;

Isn't this leaking the heap-allocated vectors?

Why make it a map of pointers, actually?  Why not:

  std::map<int, std::vector<osdata_item>>

It's more efficient, and I think results in simpler code.  You
won't need the tree_.find() for example, can just do:

 tree_[pid_i].push_back (...);

Thanks,
Pedro Alves