From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mEAsN8KuQmTdZzIAWB0awg (envelope-from ) for ; Fri, 21 Apr 2023 11:41:54 -0400 Received: by simark.ca (Postfix, from userid 112) id DD9B81E221; Fri, 21 Apr 2023 11:41:54 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=LsKjqgUs; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9828D1E0D3 for ; Fri, 21 Apr 2023 11:41:54 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1682A385700C for ; Fri, 21 Apr 2023 15:41:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 1682A385700C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1682091714; bh=uO5OGJEJ4G+xTbgZRIvAop6ighZsBoTDV4lOqhuoNN4=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=LsKjqgUs5bJqj1vslCYrtkq/1XuO2DhIbGbA9G7QSGPaRNRQGYCskNYgIDkdlW0/G Xlut3Tm2bigPr3m6HKkqcC/iywtwXcRr/z/C/H9ccYP3Bj9Da1UCerUB0dcJWZ5Qu1 2LLEEtoOkXS+sgZ+qRu9OZLt5STc0InrvN23rcuA= Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 1429E385773A for ; Fri, 21 Apr 2023 15:41:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 1429E385773A Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 4D61E21A42; Fri, 21 Apr 2023 15:41:33 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 359061390E; Fri, 21 Apr 2023 15:41:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id h4LZC62uQmRfJQAAMHmgww (envelope-from ); Fri, 21 Apr 2023 15:41:33 +0000 Message-ID: <9cdddfac-c645-b7db-ea08-a94bc0170a9d@suse.de> Date: Fri, 21 Apr 2023 17:41:26 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 1/1] [gdb/contrib] Add make-check-all.sh Content-Language: en-US To: Simon Marchi , gdb-patches@sourceware.org Cc: Andrew Burgess References: <20230403150957.28921-1-tdevries@suse.de> <20230403150957.28921-2-tdevries@suse.de> <87wn2rc22u.fsf@redhat.com> <97c65614-e1a5-a9cb-b5a3-36020e8ed259@suse.de> <2eef24aa-bbe4-478a-c965-82783d3dea9f@simark.ca> <999c220d-dd64-d6fb-b5ef-912150a4cfd6@suse.de> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 4/20/23 16:30, Simon Marchi wrote: > On 4/20/23 07:43, Tom de Vries wrote: >> You say you don't understand the comment, but to me it seems you do so I'm not sure I understand what your concern is. Should the comment be improved, or do you want a change in functionality? > > I just wasn't sure which username I was expected to pass to those > options, I wanted to confirm with you that the intent is to have > dedicated systems users for that. So the comment could say that: > > It is recommended to create users on the local system that will act as > "remote host" and "remote target", for the boards that use them. > Pass their usernames to --host-user and --target-user. This helps > because: > > - remote host/target boards will use $HOME and leave (potentially > lots of) files behind > - it enables more strict checking of build/host/target file > manipulations. > - it prevents a command running on one "machine" to kill or send a > signal to a process on another machine > Ack, I've copied that and added a Co-Authored-By tag. >> I've tried adding a bit more comments, updated version attached. > > Thanks, that LGTM. Committed now. Thanks, - Tom