From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107532 invoked by alias); 18 Apr 2019 16:27:28 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 107524 invoked by uid 89); 18 Apr 2019 16:27:27 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 spammy=HX-Languages-Length:850, replying, legitimately X-HELO: mail-wm1-f44.google.com Received: from mail-wm1-f44.google.com (HELO mail-wm1-f44.google.com) (209.85.128.44) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 18 Apr 2019 16:27:26 +0000 Received: by mail-wm1-f44.google.com with SMTP id z24so3579932wmi.5 for ; Thu, 18 Apr 2019 09:27:26 -0700 (PDT) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:4c97:6d52:2cea:997b? ([2001:8a0:f913:f700:4c97:6d52:2cea:997b]) by smtp.gmail.com with ESMTPSA id i28sm4179318wrc.32.2019.04.18.09.27.23 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Thu, 18 Apr 2019 09:27:23 -0700 (PDT) Subject: Re: [RFA 2/2][master only] gdb/windows-nat.c: Get rid of main_thread_id global To: Joel Brobecker , Eli Zaretskii References: <1555453982-77808-1-git-send-email-brobecker@adacore.com> <1555453982-77808-3-git-send-email-brobecker@adacore.com> <83imvcg0ud.fsf@gnu.org> <20190417173842.GA14817@adacore.com> <83wojseb9c.fsf@gnu.org> <20190417221729.GA5839@adacore.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <9c75d158-6a73-d414-4cb2-17297d4576c6@redhat.com> Date: Thu, 18 Apr 2019 16:27:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190417221729.GA5839@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-04/txt/msg00346.txt.bz2 (I should have read this thread before replying on the other one.) On 4/17/19 11:17 PM, Joel Brobecker wrote: > > - patch #3 (master only): Tag the main thread, and silence > the thread-exit notification of the thread that got tagged. > Depending on the implementation, this patch would potentially > be acceptable for 8.3, but might need extra work to apply. > I think we've had enough problems with 8.3 as it is, I don't > want to add more things to do, so I vote OUT for 8.3. This doesn't seem right to me, given that the main thread may legitimately exit before other threads. If this approach is taken, maybe tweak it a bit: silence the thread-exit notification of the thread that got tagged _iff there are no other threads in the process_. Thanks, Pedro Alves