From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27485 invoked by alias); 29 Jun 2016 09:50:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27472 invoked by uid 89); 29 Jun 2016 09:50:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.2 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 29 Jun 2016 09:50:44 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D058881129; Wed, 29 Jun 2016 09:50:42 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5T9ofHt001668; Wed, 29 Jun 2016 05:50:42 -0400 Subject: Re: [RFA 2/6] Use ATTRIBUTE_UNUSED in some places To: Tom Tromey References: <1465248812-23902-1-git-send-email-tom@tromey.com> <1465248812-23902-3-git-send-email-tom@tromey.com> <4e0f2f7a-6363-271d-2d91-4f8352d6509f@redhat.com> <87shvxt4i0.fsf@tromey.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <9c724132-ba94-7a54-5cfe-8442d76cad78@redhat.com> Date: Wed, 29 Jun 2016 09:50:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <87shvxt4i0.fsf@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-06/txt/msg00496.txt.bz2 On 06/28/2016 09:58 PM, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> I think we should use getcurx/getcury instead. > > I've split the patch into two. > > The inflow bits remain the same as what was posted. I can repost this > if you want. No need. > > This new patch replaces the uses of getyx with getcurx. > > Tom > > commit 2caa6df91fe83630faa615011a724748feee7a30 > Author: Tom Tromey > Date: Tue Jun 28 14:25:49 2016 -0600 > > Use getcurx in curses code > > As suggested by Pedro, this changes a few spots to use getcurx, rather > than getyx. This avoids some unused variable warnings. > > 2016-06-28 Tom Tromey > > * tui/tui-winsource.c (tui_show_source_line): Use getcurx. > * tui/tui-io.c (tui_puts): Use getcurx. > (tui_redisplay_readline): Likewise. > OK. Thanks, Pedro Alves