Re: [PATCH v2] gdb/testsuite: add test for backtracing for threaded inferiors from a corefile

[Guinevere Larsen <blarsen@redhat.com>]

On 24/10/2023 22:40, Lancelot SIX wrote:
> Hi Guinevere,
>
> I only have a couple of small remarks below.

Hi Lancelot!

Thanks for the review. I'll fix them for v3.
>
> On Tue, Oct 24, 2023 at 02:27:52PM +0200, Guinevere Larsen wrote:
< snip >
>> diff --git a/gdb/testsuite/gdb.threads/threadcrash.exp b/gdb/testsuite/gdb.threads/threadcrash.exp
>> new file mode 100644
>> index 00000000000..9dd135b9167
>> --- /dev/null
>> +++ b/gdb/testsuite/gdb.threads/threadcrash.exp
>> @@ -0,0 +1,231 @@
>> +# This testcase is part of GDB, the GNU debugger.
>> +
>> +# Copyright 2023 Free Software Foundation, Inc.
>> +
>> +# This program is free software; you can redistribute it and/or modify
>> +# it under the terms of the GNU General Public License as published by
>> +# the Free Software Foundation; either version 3 of the License, or
>> +# (at your option) any later version.
>> +#
>> +# This program is distributed in the hope that it will be useful,
>> +# but WITHOUT ANY WARRANTY; without even the implied warranty of
>> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
>> +# GNU General Public License for more details.
>> +#
>> +# You should have received a copy of the GNU General Public License
>> +# along with this program.  If not, see <http://www.gnu.org/licenses/>.
>> +
>> +# This test case looks at GDB's ability to get correct backtraces for a
>> +# crashed inferior, recreating it from a live inferior, a corefile and
>> +# a gcore.
>> +
>> +
>> +# First check that we have 7 threads.
>> +
>> +proc test_thread_count {} {
>> +    set thread_count 0
>> +
>> +    gdb_test_multiple "info threads" "getting thread count" -lbl {
>> +	-re "Thread" {
>> +	    incr thread_count
>> +	    exp_continue
>> +	}
>> +	-re "$::gdb_prompt " {
>> +	    gdb_assert {$thread_count == 7}
>> +	}
>> +    }
>> +
>> +    return $thread_count
>> +}
>> +
>> +# Apply all to quickly check if all expected states are
>> +# present.  Then, save the full desired backtrace in a list
>> +# so we can check full backtraces later.
>> +
>> +proc thread_apply_all {} {
>> +    global test_list
>> +
>> +    set unwind_fail false
>> +
>> +    gdb_test_multiple "thread apply all backtrace 100" \
> Is the 100 there to ensure that the backtrace is not truncated (there is
> no way that this test gives a backtrace of more than 100 frames)?  If so,
> why not use something like this?
>
>    with backtrace limit unlimited -- thread apply all bt
>
> This avoid the arbitrary 100 value.

Huh, I didn't know you could do  this.

I'll set the limit at the start of the test, so we don't need such long 
lines everywhere.

-- 
Cheers,
Guinevere Larsen
She/Her/Hers