Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Jason Richards <jsn.richards@gmail.com>
To: gdb-patches@sourceware.org
Subject: infinite loop processing siblings - dwarf2reader - dwarf 3 debug
Date: Sun, 25 Oct 2009 04:24:00 -0000	[thread overview]
Message-ID: <9c25d2960910242124p6dfc4f6an72811d4105711fa2@mail.gmail.com> (raw)

I encountered a problem where GDB gets stuck in an infinite loop processing
dwarf 3 debug information.  Turns out the producer has placed a
sibling attribute
in a die in a comp unit which references a previous die in the comp unit.
"locate_pdi_sibling" first checks for the presence of this sibling and
returns it
instead of scanning forward past the children (there are children
present in this die).

It seams to me the appropriate fix for this problem is to change
"locate_pdi_sibling"
to first return the location past the children, before returning
sibling information, which
fixes this particular problem.

Is there something I am not thinking about?


Regards-
Jason Richards


             reply	other threads:[~2009-10-25  4:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-25  4:24 Jason Richards [this message]
2009-10-26 21:13 ` Tom Tromey
2009-10-26 21:50   ` Daniel Jacobowitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9c25d2960910242124p6dfc4f6an72811d4105711fa2@mail.gmail.com \
    --to=jsn.richards@gmail.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox