Re: [PATCH 2/2] Remove for_each_thread

[Simon Marchi <simark@simark.ca>]

On 2026-05-13 13:32, Tom Tromey wrote:
> This patch removes the for_each_thread function, changing the callers
> to use 'foreach' loops instead.  In general I think loops with
> iterators should be preferred over callback-based approaches -- they
> are easier to read and often result in less source code as well.  For
> example, in this patch a helper function is inlined into its sole
> caller.

Perhaps mention that there is a functional change, since you switch from
using all_threads_safe to all_threads everywhere.  This happens to fix
the bug that Markus was fixing here:

https://inbox.sourceware.org/gdb-patches/20260504071636.1571615-2-markus.t.metzger@intel.com/

I would have liked to see a test along with that fix (I supplied one
down-thread), but whatever.

The other callers don't seem to need all_threads_safe, at first glance.

> @@ -607,16 +605,16 @@ print_one_inferior (struct inferior *inferior, bool recurse,
>  
>        if (inferior->pid != 0)
>  	{
> -	  for_each_thread ([&] (struct thread_info *ti)
> +	  for (auto &ti : all_threads ())
>  	    {
> -	      if (ti->ptid.pid () == inferior->pid)
> +	      if (ti.ptid.pid () == inferior->pid)
>  		{
> -		  int core = target_core_of_thread (ti->ptid);
> +		  int core = target_core_of_thread (ti.ptid);
>  
>  		  if (core != -1)
>  		    cores.insert (core);
>  		}
> -	    });
> +	    }

You could remove the braces of the "for" here.

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon