From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ib+4JspbiGBfDgAAWB0awg (envelope-from ) for ; Tue, 27 Apr 2021 14:45:30 -0400 Received: by simark.ca (Postfix, from userid 112) id 903141F11C; Tue, 27 Apr 2021 14:45:30 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 51E2E1E940 for ; Tue, 27 Apr 2021 14:45:29 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CC9CA3950811; Tue, 27 Apr 2021 18:45:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CC9CA3950811 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619549128; bh=xOw8iN4zX0KrwwlDOa/rXrbnO5zouAO+MBuM1NSCxBw=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=QqdTl8LxEymf+K9AOE5E6o6/UVHrKnvG8g8oR8GCHEUWcCtJNnkR+NM+d1faB5ndX B1LspWT0P4aKrNcLViUO76jVIKCL4qB81QofPqiN0LNFRzrt8/f0NRtaHcTekJiy+x tGK4mL4C5Ian3t0tkvXkx+p7vkqb/BMOVStq7cYw= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 567C13950811 for ; Tue, 27 Apr 2021 18:45:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 567C13950811 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 13RIjKpf008941 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 27 Apr 2021 14:45:25 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 13RIjKpf008941 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 2C3071E940; Tue, 27 Apr 2021 14:45:20 -0400 (EDT) Subject: Re: [PATCH,v2] [testsuite] Fix timeout with maint print objfiles To: Luis Machado , gdb-patches@sourceware.org References: <20210427141044.2573352-1-luis.machado@linaro.org> <20210427182608.2596880-1-luis.machado@linaro.org> Message-ID: <9c009fdb-7464-7772-3320-52deaacfd69d@polymtl.ca> Date: Tue, 27 Apr 2021 14:45:19 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210427182608.2596880-1-luis.machado@linaro.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 27 Apr 2021 18:45:20 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-04-27 2:26 p.m., Luis Machado wrote: > Updates on v2: > > - Add missing exp_continue when looking for "readnow". > - Removed wraps > > -- > > I'm seeing timeouts from gdb.rust/traits.exp when we attempt to print > things with "maint print objfiles". > > This happens for two reasons: > > 1 - GDB does not explicitly split each entry into its own line, but rather > relies on the terminal's width to insert line breaks. > > 2 - When running the GDB testsuite, such width may be unlimited, which will > prevent GDB from inserting any line breaks. > > As a result, the output may be too lengthy and will come in big lines. Tweak > the support library to match the patterns line-by-line, which gives us more > time to match things. Also fix GDB's output to print one entry per line, > regardless of the terminal width. > > A similar approach was used in another testcase using the same command (commit > eaeaf44cfdc9a4096a0dd52fa0606f29d4bfd48e). With the new line breaks, we don't > need a particular pattern, so clean up that test as well. > > gdb/ChangeLog: > > YYYY-MM-DD Luis Machado > > * psymtab.c (psymbol_functions::dump): Output newline. Remove wrap. > * symmisc.c (dump_objfile): Likewise. > > gdb/testsuite/ChangeLog: > > YYYY-MM-DD Luis Machado > > * gdb.base/maint.exp: Drop a pattern that is not needed. > * lib/gdb.exp (readnow): Match line-by-line. Thanks, that LGTM. Simon