From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27097 invoked by alias); 11 Nov 2016 00:09:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27076 invoked by uid 89); 11 Nov 2016 00:09:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=principle, site X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 11 Nov 2016 00:09:29 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 24D32341466; Fri, 11 Nov 2016 00:09:28 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAB09QSr031414; Thu, 10 Nov 2016 19:09:27 -0500 Subject: Re: [RFA 02/14] Change event code to use gdbpy_reference To: Tom Tromey , gdb-patches@sourceware.org References: <1478497656-11832-1-git-send-email-tom@tromey.com> <1478497656-11832-3-git-send-email-tom@tromey.com> From: Pedro Alves Message-ID: <9bf85362-c850-75b4-de1b-f1cdd0df9101@redhat.com> Date: Fri, 11 Nov 2016 00:09:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1478497656-11832-3-git-send-email-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00278.txt.bz2 On 11/07/2016 05:47 AM, Tom Tromey wrote: > PyObject * > create_breakpoint_event_object (PyObject *breakpoint_list, PyObject *first_bp) > { > - PyObject *breakpoint_event_obj = > - create_stop_event_object (&breakpoint_event_object_type); > + gdbpy_reference breakpoint_event_obj > + (create_stop_event_object (&breakpoint_event_object_type)); > > - fail: > - Py_XDECREF (breakpoint_event_obj); > - return NULL; > + return breakpoint_event_obj.release (); > } Wouldn't it better to make these create_foo functions return a gdbpy_reference ? Then at the call site you'd use std::move instead of reset (when assigning to an existing lval): stop_event_obj = std::move (create_breakpoint_event_object (list.get (), first_bp)); The advantage of following such a principle is that it makes it impossible for callers to forget to manage the result with a gdbpy_reference, since assigning the return to a raw PyObject * won't compile. Thanks, Pedro Alves