From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id LGliLxpiDWZZgCEAWB0awg (envelope-from ) for ; Wed, 03 Apr 2024 10:05:14 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-armh-onmicrosoft-com header.b=ycE54uJR; dkim=pass (1024-bit key) header.d=armh.onmicrosoft.com header.i=@armh.onmicrosoft.com header.a=rsa-sha256 header.s=selector2-armh-onmicrosoft-com header.b=ycE54uJR; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id B67AF1E0C0; Wed, 3 Apr 2024 10:05:14 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 93A731E030 for ; Wed, 3 Apr 2024 10:05:12 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B5B5038449C6 for ; Wed, 3 Apr 2024 14:05:11 +0000 (GMT) Received: from EUR04-DB3-obe.outbound.protection.outlook.com (mail-db3eur04on2083.outbound.protection.outlook.com [40.107.6.83]) by sourceware.org (Postfix) with ESMTPS id 87A26384640D for ; Wed, 3 Apr 2024 14:04:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 87A26384640D Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=arm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=arm.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 87A26384640D Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=40.107.6.83 ARC-Seal: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1712153082; cv=pass; b=E4lHhs80R2nDkahOFoDVDrNJXOPmNKx4ut9VcXHb4s+ArWGPLTtAQAB9oQ1sqNP25y5imcKPcvcW7o5wNIYo3ickhVPGU1Tknl4SyCHkw75FTEHGcJlffFkSwMrgQVC5DJwE8Ny6fAyniBAZkjCnPX/D3P09Syj0iFxG+FGqrGA= ARC-Message-Signature: i=3; a=rsa-sha256; d=sourceware.org; s=key; t=1712153082; c=relaxed/simple; bh=qFtby70+kMR1fJDmdl3l+RUeIhoxiIHCUpy9aIVcZ4M=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:Subject:To:From: MIME-Version; b=Xj6iYK823bc9IAlS63cB8V/kn7wa6ijfrn7zAPHAd+m43UajBvqedUaWfkg5dFFwhIUodV8oJsomMVXahASPy2BDUh+ScNfhEzJD4+ZyQGSS05Dm/kRolNCTR+7zDWIgsxRVwtd0zBCUYQ4q/NeIaOa0+jECrEpiLy+Nvw1ai1M= ARC-Authentication-Results: i=3; server2.sourceware.org ARC-Seal: i=2; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=pass; b=Ui2wvarXCJtSs/RaAbhmfsjQvZjOd/8c0u2NoC3IsdSMlmj/FeSjyzE7BwuZcIOuPF+xh7EX8W6wYQm9R1aTALhUMYk45tizz111HZ3cRw5Lx8H1ivWkKdHwHFpCF5NXkiyxPI9SEx14tpwdvUF+jgfWjtYM9Zk+5YD1NamByrpRY/Oj9pe1dkcUw/MV50+gcIKRIjwrPZ+7235WJGolAeZLH8+PG77FdhJzfeYOYJo1PbqWSaECXtBwlzKH+shc8QaV0ez8bnKuag5qs9Uyizi1+8i7ui5hpEOKouM7kPkf+To/wisUknLG+fpcJp8CtBmxbs8c+92GlgeO/wYa2A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fMI+cjUvr6N/LQc8OGWbTA8US+gEt/ze1ShJO3Q8GNw=; b=Anm1uMmmLxIgx4AJwsvha1MC1cHdFK+8uZFaOW1ce0HKDlrB44CvBFjgZq2Z6F7dQQWWGRPAqN8R/uZ78M9CV7rPQoFymvrxQ+eeNd+gcIvL7wqvFTjV3NqsSc3L98l59QtGfKMt2k5YyruSBIZt/zIrCN4du9aMJ2ogaJ+VBrfZ3+n4jNQSpxlunZgfRmmFF1WJnOcKn2CB3q3l9WhFrLYCCgGBb3QT2l7GcECkSoAqO5H7kZI8xKE4expW9oFDU1g32WurdX6KakMJvY6M5Dht1iLUWj9Ck7v04dfXSHTADTw8X4x90HQ+3At9fxoS9DNGHOTnOn34wkarLAJe3g== ARC-Authentication-Results: i=2; mx.microsoft.com 1; spf=pass (sender ip is 63.35.35.123) smtp.rcpttodomain=sourceware.org smtp.mailfrom=arm.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com; arc=pass (0 oda=1 ltdi=1 spf=[1,1,smtp.mailfrom=arm.com] dkim=[1,1,header.d=arm.com] dmarc=[1,1,header.from=arm.com]) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fMI+cjUvr6N/LQc8OGWbTA8US+gEt/ze1ShJO3Q8GNw=; b=ycE54uJRpDbfhVTaAMYniNGN53tL/f2HNsyXkKWIThClpxdWFaiXdpTEYE+kqZCCZplEOuzeOhjbxiJuaSkArMDfVc6F9sAW8nTeoJnJRfyQgiO9bv7hFl/6Iwvw9Ean00wv+RUet45tckTxYCUA0BQMZPqihE/1CFQvQmDxbo4= Received: from AS4PR09CA0014.eurprd09.prod.outlook.com (2603:10a6:20b:5e0::17) by DBBPR08MB6076.eurprd08.prod.outlook.com (2603:10a6:10:1f5::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Wed, 3 Apr 2024 14:04:37 +0000 Received: from AM3PEPF0000A78D.eurprd04.prod.outlook.com (2603:10a6:20b:5e0:cafe::e8) by AS4PR09CA0014.outlook.office365.com (2603:10a6:20b:5e0::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46 via Frontend Transport; Wed, 3 Apr 2024 14:04:37 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM3PEPF0000A78D.mail.protection.outlook.com (10.167.16.116) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.7452.22 via Frontend Transport; Wed, 3 Apr 2024 14:04:37 +0000 Received: ("Tessian outbound ff4e98f65004:v300"); Wed, 03 Apr 2024 14:04:36 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 9e70fa4982b937c7 X-CR-MTA-TID: 64aa7808 Received: from b5fc39fe7466.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CA36CD25-F94A-483E-821C-5482CA53ABEF.1; Wed, 03 Apr 2024 14:04:30 +0000 Received: from EUR05-AM6-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id b5fc39fe7466.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Wed, 03 Apr 2024 14:04:30 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fVbeFbhZkmAou6ZxNCyj2JgQON+UfW9A66s6A11ODVY/4rNpQ7tSNVC5o9CM4oBvp21ExiIEzb6R9E/qeVNfXSKTPKCRW0uoKCbu3L6dxq6RkzALBlZQJXJKne0W3ncfh9OAjiOvkE1pu9jya7ho0rHN/5B5CAODr8wCXW0ESahaZnurS2Sy4/gzJd6TEYj1B66KOEty7jcHwjEM+jfyZcnj9PmYDDKMmnnUXYjElql86HWV9jSVR48ECQqgSjJiqkqceVhyC40qCSGKA6ntvWoN+soCrtb9CQtWxT07OcpMnmkF1JgqvL2a2GIKTY0Vn2cK484nM3bWZg8HqgEqQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fMI+cjUvr6N/LQc8OGWbTA8US+gEt/ze1ShJO3Q8GNw=; b=E1Ufrzd2JavAINP+nH9C6OeP6GTXL/Jg0HilafMDihF4PrYTrjFMVTfhlj/r2zH+RJydMOtrVjX9ucqeggCZqDTjv8sU31AOzd9a2gp3OcOol5XucPPioFcZ5+ArOA2BxP3tE79tG8gZLMrPfE0IoJkmm7ygJRAYidvkH6P7hcFG529GLaRYJnAh2sDyFIihxsoJeRPsXeiwgyMRQdJKXg9fP0nl86syVK2iPJQXF9GeaEfwPYtfdak+XkjWW7CCpdlrVf8QYDedrzVRBFZwfcWbraHUwSZ3SxS4XXOF28uZYuoXB6fg6bf7OAwAV+Gi9VwlgAhIV2vnPSdPE3AYFw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fMI+cjUvr6N/LQc8OGWbTA8US+gEt/ze1ShJO3Q8GNw=; b=ycE54uJRpDbfhVTaAMYniNGN53tL/f2HNsyXkKWIThClpxdWFaiXdpTEYE+kqZCCZplEOuzeOhjbxiJuaSkArMDfVc6F9sAW8nTeoJnJRfyQgiO9bv7hFl/6Iwvw9Ean00wv+RUet45tckTxYCUA0BQMZPqihE/1CFQvQmDxbo4= Received: from VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) by DBBPR08MB10651.eurprd08.prod.outlook.com (2603:10a6:10:53b::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Wed, 3 Apr 2024 14:04:28 +0000 Received: from VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::363f:3fc8:fc36:58ed]) by VI1PR08MB3919.eurprd08.prod.outlook.com ([fe80::363f:3fc8:fc36:58ed%5]) with mapi id 15.20.7409.042; Wed, 3 Apr 2024 14:04:28 +0000 Message-ID: <9be4c93e-6f02-4171-8dcd-ed262ffc6d69@arm.com> Date: Wed, 3 Apr 2024 15:04:26 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 4/4] gdb: Add new remote packet to check if address is tagged Content-Language: en-US To: Thiago Jung Bauermann , Gustavo Romero Cc: gdb-patches@sourceware.org References: <20240328224850.2785280-1-gustavo.romero@linaro.org> <20240328224850.2785280-5-gustavo.romero@linaro.org> <87r0fs76wm.fsf@linaro.org> From: Luis Machado In-Reply-To: <87r0fs76wm.fsf@linaro.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0206.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::13) To VI1PR08MB3919.eurprd08.prod.outlook.com (2603:10a6:803:c4::31) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: VI1PR08MB3919:EE_|DBBPR08MB10651:EE_|AM3PEPF0000A78D:EE_|DBBPR08MB6076:EE_ x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: dtJKZlC5JZdC2BvSikyfGqrvQneT1UrZN3/J2JkFksTdbsQB1p8mCMAAnZCSbyCrmwyMhxb7Z6wFY6lew1jvOuXu6KrcNkvfwgfFPaqCtSKNGMj1JW+J/YLC8fBcCxnvr0g3dnHZbr13zQSnakikG7IL5rqlk0wtp2WdmjzxYo3CsFBfGe79GVuv7tnyupnQH/sd7KKOUsUP55GUh8hWhKW+5hvb3PFiQxyj0imLn5iIR4I7m9hc/2WASWgrnuibILptSzAdhcgSfAB/iLt2XXZhJsdHcNLPgPRwdKar8OALgqbNq6hH6ugtf0vDtXbvbV7iSTpwoydcebcmVYGOeTCNnSpZ+AcG/KT0Ku0BAbeuzcoVjnhJshclxdZeqJI6JWCcIgT3nyHn258/PmQKIhJynqNvxhuqS8bXaHn1ffecO6hvrVO4RXbJEqBW4upugwtoDB40CXlQP968FAEFeNWjoLByXk7vLZ9XLWVf3/qOVYVrXor7/smTewHFb8OmUsM3y2CIzhSXso+0GikskrqEm6mUryaHBibxepqdINqnary5kik4Np+dCd2dHp8oSB/a3a3Jd6yL5fZ5AOn61ABqXgywhgpm2zhjjySlLtu65GjnRNUUQg0eAzjn++v2yOfvuzNyZX8rbc8x2HQXdBYc2BV/tLxX4qkZUbVAa/k= X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:VI1PR08MB3919.eurprd08.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376005)(366007)(1800799015); DIR:OUT; SFP:1102; X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB10651 X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM3PEPF0000A78D.eurprd04.prod.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 9e4afa7a-02b1-4691-c2e2-08dc53e6ff60 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Ok4XrzXNxVcawrhP4XJebtEqnm8jkaYoSmJc8UB5agWd9lYACV3vm3ba0NFbe+lqMbiyLfa0b+5GOiShGTb+bkPaGjd6HsJlOdJbvos8VmIfbpDtnFwtrj13RxWkpkDDbF/BS35Kjvb7AXzKr5ilEtBERjcz12sPWKIJU2g1o8PFsuhF8SJLxoDtrKeBXGoGiZnOg+wbELYjqcgQ/8YKJek00sTFl6/t15lyjUKyXXYTQMbdX5d9Cy5o2XK8NzSzVC1AbDgfhg0rJH0icp0nbEUGmMb8YJTFBogNRsP7iF5aVPOtkZF0blngRp0SqyZWBtG++682qxPaoN1lNL9hu0f9DjS7Fa558ub1B95uMk8ehvQ1p8g2SlLt9FkETshwMEYyZ7HNC01jElHkS9AWWUXzwwHktYk2t8EWfzKQwkOLdLh7VvTn5UumlpQmfhfDwzLZgvPIRKxlYnWu6ylrMqbOV3pxObZWXrN9X8WimGKZSOkTR0paR6M5Ygke1IurkP6jKCRflq4BN40P7HYdeMiK/vxB1d72ZZeY3Z/Nrx71OCKCbCU7+ymAfL1AL7NwTu9zP8C6gprMqsEDJkeaesCRCSRvrw88gRxn3EOwVQo1DRgY0+gu1gcqZ4PGIlZ3uJWNN+pnesB6UsShytBv2gZLOYA1ka9ZQSLY4TmHUONBLhTNElPjHjxkhZyJk8KcHMKcHLCLyGRKfk3a5xPSVA/WkrVW8cT9CB/OYY7gN+mPQPejKj0rycUjG5fDzY1f X-Forefront-Antispam-Report: CIP:63.35.35.123; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:64aa7808-outbound-1.mta.getcheckrecipient.com; PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com; CAT:NONE; SFS:(13230031)(376005)(36860700004)(82310400014)(1800799015); DIR:OUT; SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Apr 2024 14:04:37.1257 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 9e4afa7a-02b1-4691-c2e2-08dc53e6ff60 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d; Ip=[63.35.35.123]; Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM3PEPF0000A78D.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR08MB6076 X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FORGED_SPF_HELO, KAM_DMARC_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_PASS, SPF_NONE, TXREP, UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 3/30/24 03:08, Thiago Jung Bauermann wrote: > > Just one more suggestion that occurred to me later: > > Gustavo Romero writes: > >> For supporting the new packet, a new target hook is introduced, >> check_memtag_addr, which is used instead of the gdbarch_tagged_address_p >> gdbarch hook in the upper layers (printcmd.c). > > "check_memtag_addr" is a bit vague: what does it check? This confused me > a bit when I was reading the code with these patches > applied. Alternatives I can think of are "is_addr_tagged", or > "tagged_address_p". That last bit seems more in line with the gdb terminology. A target took "tagged_address_p" or "target_is_address_tagged" should be a bit more clear. Plus we have precedent in the target hooks is_async_p, can_async_p, always_non_stop_p etc. > > I'm not too fond of the "_p" suffix, but it has the advantage of being > consistent with the existing gdbarch hook so it may be preferable in > this case. > > Ah, one other thing that just occurred to me: I think this warrants an > entry in gdb/NEWS. > > -- > Thiago