From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 4HAKOxcDTmHsQAAAWB0awg (envelope-from ) for ; Fri, 24 Sep 2021 12:55:51 -0400 Received: by simark.ca (Postfix, from userid 112) id EFA8A1EE25; Fri, 24 Sep 2021 12:55:51 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.9 required=5.0 tests=MAILING_LIST_MULTI, NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 988341EDF0 for ; Fri, 24 Sep 2021 12:55:47 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5AD573858428 for ; Fri, 24 Sep 2021 16:55:47 +0000 (GMT) Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) by sourceware.org (Postfix) with ESMTPS id BB1AB385801A for ; Fri, 24 Sep 2021 16:54:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BB1AB385801A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wr1-f49.google.com with SMTP id t18so29465038wrb.0 for ; Fri, 24 Sep 2021 09:54:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:from:to:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=U9FEmGe/tZcjvD/qA01/i/0JN0Bl1gDoS6dtkXxnMXI=; b=WOSOf+OcxQqpOoY5zJFC4cwxdo9kxa5Bsqh//iuSdNU8q35xaGdywQhm9Uyjk4/maI lhC6jOA9pP5WNBmSP9nmemEAcf+e2hmDz1CzicX+28/Z75LPwWm/VGFrx8ESDlAfg5k3 RvttkqJbU+XQ9gvk8k9oREsnkvieT0Yhunwy/rG1onO9B7MV/TCwCotYYw+dL1uNIHIP wypxDdMEN0NMulzWMbhOPs5J5iPBP2rBPc2gp6DynstOsVp5hFfvR6S6Idz6tIBDoTA9 JvqUrMUXcxPITE5PmacWJopR2bpmt6EzwZRik2C9/1nrfOYIR3LhqqEt+5R+zggjRoCW uduQ== X-Gm-Message-State: AOAM531UUgxw6Np1KlsU8o3CDyffbDdjJrA2EO0pJ1AUj3XAQfyasDGm SbEChdeZ9DNm7T/UAF64DrL/oqftE2ah/Q== X-Google-Smtp-Source: ABdhPJwDQATKzVRXbK+HSu34NDKfV/mcgi1th9oX/e+Xe6c19U2lncCvZOC9Mab3x6fySGZx2o3FAw== X-Received: by 2002:a1c:21c3:: with SMTP id h186mr3203102wmh.18.1632502495812; Fri, 24 Sep 2021 09:54:55 -0700 (PDT) Received: from [192.168.0.201] (bl22-100-144.dsl.telepac.pt. [2.83.100.144]) by smtp.gmail.com with ESMTPSA id k26sm3070386wms.39.2021.09.24.09.54.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Sep 2021 09:54:54 -0700 (PDT) Subject: Re: [PATCH] gdbsupport: remove attempt to define TARGET_WORD_SIZE From: Pedro Alves To: Andrew Burgess , gdb-patches@sourceware.org References: <20210924164413.3770845-1-andrew.burgess@embecosm.com> Message-ID: <9bd5f5ea-aa2a-8829-cde0-d5697dab87c1@palves.net> Date: Fri, 24 Sep 2021 17:54:53 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <20210924164413.3770845-1-andrew.burgess@embecosm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-09-24 5:44 p.m., Andrew Burgess wrote: > In the gdbsupport configure.ac file, there is an attempt to define > TARGET_WORD_SIZE. This is done by running grep on the file > ../bfd/bfd-in3.h. > > The problem with this is, the file bfd-in3.h is generated into the bfd > build directory when bfd is configured, and there is no dependency > between the gdbsupport module and the bfd module, so, for example, if > I do: > > $ ../src/configure > $ make all-gdbsupport > > Then bfd will neither be configured, or built. In this case > TARGET_WORD_SIZE ends up being defined, but with no value because the > grep on bfd-in3.h fails. > > However, it turns out that this doesn't matter; we don't actually use > TARGET_WORD_SIZE anywhere. > > My proposal in this commit is to just remove the definition of > TARGET_WORD_SIZE, the alternative would be to add a dependency between > configure-gdbsupport and configure-bfd into Makefile.def, but adding a > dependency for something we don't need seems pretty pointless. Strange, that TARGET_WORD_SIZE bits was added by 01027315f540, and AFAICS, git grep on 01027315f540^ only finds ChangeLog hits. But it wasn't used anywhere when it was added by commit 01027315f540 either. Maybe Tromey remembers. The patch LGTM.