From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 47605 invoked by alias); 29 Jun 2017 11:08:44 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 47574 invoked by uid 89); 29 Jun 2017 11:08:43 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 29 Jun 2017 11:08:43 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id B9B9AA23E4; Thu, 29 Jun 2017 11:08:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com B9B9AA23E4 Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com B9B9AA23E4 Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id E363C89CAF; Thu, 29 Jun 2017 11:08:00 +0000 (UTC) Subject: Re: [PATCH 06/40] Expression completer should not match explicit location options To: Yao Qi References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-7-git-send-email-palves@redhat.com> <86h8yzdwng.fsf@gmail.com> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <9bb22b33-5666-0aed-4ef5-de686983cab4@redhat.com> Date: Thu, 29 Jun 2017 11:08:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00786.txt.bz2 On 06/29/2017 11:56 AM, Pedro Alves wrote: > The patch fixes this by having the expression_completer function > bypass the function that completes explicit locations: > > /* Not ideal but it is what we used to do before... */ > - return location_completer (ignore, p, word); > + return linespec_location_completer (ignore, text, word); > Hmm, reading this back made my realize that I'm dropping "p" here, which is computed just above. That doesn't make a difference to the test added by 37cd5d19fecc (2008), which was the commit that added that code. Hmm, looks like that's a bit of dead code we can remove. Thanks, Pedro Alves