From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id wsgGOxlLfGeVdgUAWB0awg (envelope-from ) for ; Mon, 06 Jan 2025 16:28:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1736198937; bh=6e2LRaoOX4iDbokiBiU81fCyWoYlioqQ8641Dq1hUGo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=xDbMhx5CUgguyLX6+iKth74ezry0fhX/wHVMau5hN2RMvJJFAI4uKyE0yl2pjR9Nl J6ha6jDf87wBFNVitodJ8JhwIwaQSmrOiMpBEGFmt+cWyNoPRK3nHNpujFsGhIVZtN G9l+20hCehQ53dx4zEArcgycmrk3bCFWn2O2SycY= Received: by simark.ca (Postfix, from userid 112) id E417A1E0BB; Mon, 6 Jan 2025 16:28:57 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=unavailable autolearn_force=no version=4.0.0 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=hHCAScmK; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=GGGUylCl; dkim-atps=neutral Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 70E4C1E05C for ; Mon, 6 Jan 2025 16:28:57 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 185583858C60 for ; Mon, 6 Jan 2025 21:28:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 185583858C60 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=hHCAScmK; dkim=pass (1024-bit key) header.d=simark.ca header.i=@simark.ca header.a=rsa-sha256 header.s=mail header.b=GGGUylCl Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 7D4C53858D21 for ; Mon, 6 Jan 2025 21:28:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7D4C53858D21 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7D4C53858D21 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=158.69.221.121 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736198902; cv=none; b=OOyPjlp0BfTxojCXq9iAT8W70Beey2nO6c0HffSoXhpnpSCE7Jag+wYbm1xNuX0bp1AFLLSAqVwzummRfU1Rc1IYTLwMwlNR1cQ5dETI2HeWIaguF8JipXFrtsZrRQdBRVmcNW0/rDOG/kfIhSf3YKmLoPxQ4QRrHz8WQos7o8s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1736198902; c=relaxed/simple; bh=6e2LRaoOX4iDbokiBiU81fCyWoYlioqQ8641Dq1hUGo=; h=DKIM-Signature:DKIM-Signature:Message-ID:Date:MIME-Version: Subject:To:From; b=hX0qQZzkguUdJkew5KxWX7xx9INOG8uDYpDeC7CEIsxX/mR2Q094Vb2uBh0PFXetNNhU/AP3fZQILt43MMXMwcWYDtvs2xKmtSt7dFJB5f+RhH/EnQXwJfKz2p2ItfleJEg4BcbT3JJTK7H7O6ElTdAqnVcjMijXEjCQ1s9xYrA= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7D4C53858D21 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1736198902; bh=6e2LRaoOX4iDbokiBiU81fCyWoYlioqQ8641Dq1hUGo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=hHCAScmKo0rVizpJQBOowsFk+BOK+QFcPdbfbGjfaLBAhjIG2JeoSeFuL437bwWCw OXfSluiIme4zyyDVkjAJa7K+nq1RN90d8ND87kzpf1ZW0VByeCYe9mNveqVpiqtiHE Xo/1RA3Iv++v+1OUo0/1Mzf6SUicdzW7Og8Jjlts= Received: by simark.ca (Postfix, from userid 112) id 264261E0C1; Mon, 6 Jan 2025 16:28:22 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=simark.ca; s=mail; t=1736198901; bh=6e2LRaoOX4iDbokiBiU81fCyWoYlioqQ8641Dq1hUGo=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=GGGUylClfkPDe2/2kjXQzuT5D1Z0Qxssame2OXXhVN2ZnN8yVw7xoY0S179BeeM2z W4g92qOQKuR64PK4mUKW+3UZc/u7RzNMRKsexOF0RnnmCJasMN9sMXikUgKqj5mVSp tTV8tFAFV+cviBMSe5Kclh7z1NNm/UWd6TQ6UPA4= Received: from [10.0.0.11] (modemcable238.237-201-24.mc.videotron.ca [24.201.237.238]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id E0D631E05C; Mon, 6 Jan 2025 16:28:20 -0500 (EST) Message-ID: <9bb013dc-22e0-48c2-ae08-c2d196a2819d@simark.ca> Date: Mon, 6 Jan 2025 16:28:20 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 01/11] gdbserver: dump 'xx...x' in collect_register_as_string for unavailable register To: Tankut Baris Aktemur , gdb-patches@sourceware.org Cc: simon.marchi@efficios.com References: <20241230-upstream-gdbserver-regcache-v2-0-020a9514fcf0@intel.com> <20241230-upstream-gdbserver-regcache-v2-1-020a9514fcf0@intel.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <20241230-upstream-gdbserver-regcache-v2-1-020a9514fcf0@intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2024-12-30 05:49, Tankut Baris Aktemur wrote: > Fix 'collect_register_as_string' so that unavailable registers are > dumped as 'xx...x' instead of arbitrary values. This gives the > opportunity that we can reuse 'collect_register_as_string' in > 'registers_to_string' for additional code simplification. > > Note: This patch is also included in the "A new target to debug Intel GPUs" > series at > https://sourceware.org/pipermail/gdb-patches/2024-December/214029.html > > Reviewed-By: Luis Machado Can you please clarify in the commit message where the impact of the change is? I initially assumed (don't know why) this was fixing some debug output. I dug a bit, and it seems like it specifically changes the behavior when sending expedited regs. Otherwise, the code changes LGTM: Approved-By: Simon Marchi Simon