From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 16733 invoked by alias); 8 Dec 2017 12:24:45 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 16718 invoked by uid 89); 8 Dec 2017 12:24:44 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 08 Dec 2017 12:24:43 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 775591A4086; Fri, 8 Dec 2017 12:24:42 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id D150960BEC; Fri, 8 Dec 2017 12:24:41 +0000 (UTC) Subject: Re: [PATCH 0/3 v3] [AArch64] Support tagged pointer To: Yao Qi , gdb-patches@sourceware.org References: <1512727471-30745-1-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: <9b93ee00-8744-9ce2-323b-adf810b7d7e3@redhat.com> Date: Fri, 08 Dec 2017 12:24:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <1512727471-30745-1-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-12/txt/msg00182.txt.bz2 On 12/08/2017 10:04 AM, Yao Qi wrote: > ARMv8 supports tagged address, that is, the top one byte in address > is ignored. It is always enabled on aarch64-linux. See > https://www.kernel.org/doc/Documentation/arm64/tagged-pointers.txt > > Some parts of GDB related to address are updated in this patch series, > > - Memory access, like command 'x', > - Setting hw breakpoint on some address, > - Setting watchpoint on some address, > > Address tag is treated as non-significant bits of address, so this patch > series add a new gdbarch significant_addr_bit, and use it in gdbarch to > get rid of non-significant bits. This was the suggestion in the v2 review. > (https://sourceware.org/ml/gdb-patches/2017-10/msg00792.html) Thanks much for the update. I like this version a lot better. > > When I test this patch series, and I find a regression in linespec. I > posted the fix https://sourceware.org/ml/gdb-patches/2017-12/msg00158.html > Without this fix, this series causes a regression. Thanks again for that fix. Pedro Alves