From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id IOJnFEjXt2VCNAwAWB0awg (envelope-from ) for ; Mon, 29 Jan 2024 11:50:16 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=d2rjjox3; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 47A2C1E0C3; Mon, 29 Jan 2024 11:50:16 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 299251E092 for ; Mon, 29 Jan 2024 11:50:14 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9C87D38582B7 for ; Mon, 29 Jan 2024 16:50:13 +0000 (GMT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id AFA123858D1E for ; Mon, 29 Jan 2024 16:49:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AFA123858D1E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AFA123858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706546988; cv=none; b=E/tcZPbonO2JWFB7fRLtf1wvNJRbFJ84UsGScvaWTu3nrrs94O0BvCEDWTr6uQaadSJIvoVsyl9qIOHuUl0xC55+uWuBhQbXv/qUnT5pTSrZ9bfSNFo4Wz6cswJbOmN6J07qX8+vSI/csQtabo+4o8V2iOErIWlAOorU0fqtinY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1706546988; c=relaxed/simple; bh=rcw4c34zp0HRkIggRmO3YlkHMWTMa75nE9MmwuwAdmQ=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Vwp9ndkajfpavTE8mOQOlO3avdt7rQX1LkCOxLfGjZVhctQBlbfk/TOtRJvgUbVTWFtF2IfIMqvtvfmb8wD9dHLkmHzmTlmD2Z8UoViRBb6AvKBbsLK8sUVet0zjhSx3mbFHnvp8ItscSxkX/CwBnFc+uesL+qM0x0aGTSBVzFM= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1706546985; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Mo2SJgI0l6uRF57GayD61m1L6c/vX5Rip2dz0YHSuh0=; b=d2rjjox3ouwLexS1wG26oN6HqRGRDH/SBpcq+LWGRTaQlrZvnnP7qNz3tPXxmPwrYqt9vC btMBferCKLHaDw+1rQD/usaVO7d/OcTYZUhYQPY0i1s8gugs6k/bz3ehHAleBYvX7TPVuc DvZvI+82+LiIcw7m0Lo54zPm1KIKJHo= Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-57-lkwj6_GUMKaI92eIMFeUBA-1; Mon, 29 Jan 2024 11:49:42 -0500 X-MC-Unique: lkwj6_GUMKaI92eIMFeUBA-1 Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-1d8c8dedd33so15175955ad.1 for ; Mon, 29 Jan 2024 08:49:42 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706546981; x=1707151781; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Mo2SJgI0l6uRF57GayD61m1L6c/vX5Rip2dz0YHSuh0=; b=tGcVUM6CBBSo7Ic6mmf9BgXEcqJVaPGVUBUzrWbR/vIPf2RAB+PHYdnnazzZXbQ74c +tKn4aJMSQ59npzTeGDxxkpXFBsvwX0ICQUVZc6iNZrKargT6tvOWFWckPrulWVz+5n0 GezkopyTd/sPrwQnM1qLprBbHTNBglFoF5s6hCb88jB180wfHHRrSkXJSL1IMTsfxJe5 DZd1Nq4FWhhpHdslZ43mlvTKT5Hh00icHdAL2p7aeiFOY2+qjKpqmbi1TywLeAkxuqS5 T7m9IhjTvoiD7VX2RyxrvcnZ4qZ43Jo5nd1nhCqSbUlCgF0OJ3j/utysaGjMYxycJYNi W5Cw== X-Gm-Message-State: AOJu0Yxuu9q5eA/e1Br82llxNWC+Y+WrDy0/ByffNIQJX+OZ5OrsICv3 nOHbtjUcjG6rSEwQyns9uRO+WBx/8dEONJadMev2jj/0LPfrN+NGCHsjAQkU57Oz1rQvd37rLou 523xfEYuWuNTVRvhQq/jmyBbyK/ypvTeBHegUgJREBRwr9Qce4BfFV9lJ5LUX63vOF2M= X-Received: by 2002:a17:903:444:b0:1d8:ef92:df with SMTP id iw4-20020a170903044400b001d8ef9200dfmr1311716plb.53.1706546981561; Mon, 29 Jan 2024 08:49:41 -0800 (PST) X-Google-Smtp-Source: AGHT+IHvdNM8/YOa4UvPrCoqorfEYkMOOUdAYx2ns8GFkGnv5HmK5JBDyiR1I7hnjd4Z9UgG95KakQ== X-Received: by 2002:a17:903:444:b0:1d8:ef92:df with SMTP id iw4-20020a170903044400b001d8ef9200dfmr1311706plb.53.1706546981264; Mon, 29 Jan 2024 08:49:41 -0800 (PST) Received: from [150.1.200.12] (174-21-92-140.tukw.qwest.net. [174.21.92.140]) by smtp.gmail.com with ESMTPSA id u20-20020a170903305400b001d8ec9d6d24sm1546923pla.208.2024.01.29.08.49.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jan 2024 08:49:40 -0800 (PST) Message-ID: <9b93df65-1317-4e6d-8fe0-b0940db7f1db@redhat.com> Date: Mon, 29 Jan 2024 08:49:40 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/unwinders: better support for $pc not saved To: Andrew Burgess , gdb-patches@sourceware.org References: <4d3be44a23e2e5853d966c081bccbeb751004310.1706366387.git.aburgess@redhat.com> From: Keith Seitz In-Reply-To: <4d3be44a23e2e5853d966c081bccbeb751004310.1706366387.git.aburgess@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.1 required=5.0 tests=BAYES_00, DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H4, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_NONE, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On 1/27/24 07:26, Andrew Burgess wrote: > This started with a Red Hat bug report which can be seen here: > > https://bugzilla.redhat.com/show_bug.cgi?id=1850710 > > The problem reported here was using GDB on GNU/Linux for S390, the > user stepped into JIT generated code. As they enter the JIT code GDB > would report 'PC not saved', and this same message would be reported > after each step/stepi. I really appreciate that you've looked into this. For several years now, any interested user has seen my hack workaround (posted in 28313)! I haven't dug into this yet, but I wanted to point out that on s390x, the new test file comes with a FAIL (on unix, native-gdbserver, and native-extended-gdbserver boards): === gdb Summary === # of expected passes 6 # of unexpected failures 1 The failure from gdb.log (I'm testing through our internal beaker test infra on RHEL9, so all tests are run (unfortunately) as root): bt #0 other_func () at /root/test-fsf-master/gdb/build-s390x-redhat-linux-gnu/gdb/ testsuite/../../../gdb/testsuite/gdb.base/pc-not-saved.c:24 #1 0x00000000010006ae in break_bt_here () at /root/test-fsf-master/gdb/build-s3 90x-redhat-linux-gnu/gdb/testsuite/../../../gdb/testsuite/gdb.base/pc-not-saved. c:38 Backtrace stopped: previous frame inner to this frame (corrupt stack?) (gdb) FAIL: gdb.base/pc-not-saved.exp: backtrace from other_func function Keith