From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id nuqYO3h2wWly7TUAWB0awg (envelope-from ) for ; Mon, 23 Mar 2026 13:20:57 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=KxkBd30x; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qvljK4g2; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=KxkBd30x; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qvljK4g2; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id E43741E0BC; Mon, 23 Mar 2026 13:20:56 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E3A951E08C for ; Mon, 23 Mar 2026 13:20:55 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 3EB404BAE7F8 for ; Mon, 23 Mar 2026 17:20:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 3EB404BAE7F8 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=KxkBd30x; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qvljK4g2; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=KxkBd30x; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=qvljK4g2 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id A2FB84BAE7C0 for ; Mon, 23 Mar 2026 17:20:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org A2FB84BAE7C0 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org A2FB84BAE7C0 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774286424; cv=none; b=CW7Drgc3uv7E9T09L9G598rycEpIjVB8FaBA6/m4aZTOaufO3i799m4dtFsP6gFiK7KfYMDjLf+lzkK1R73rML1xpw9ap9s1j0iMltk+gYM/CjvVuirvCTSttTv2nevUi4DtGaM0WKyg+zGQqdhySqFpOqMSJQJIS+17Oqw3Oec= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1774286424; c=relaxed/simple; bh=f2PLqAk2WI6k2a8iihr9bsv0ttuPdE1NhXef0OLI3dc=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=OdaYVxWXA74rRfiAO7yDdwW1JZm/BgfuHL4vTLHo0bTEfI125dukcHDZXwITGwg1nm8vGBWyr3rLisffLAij5NUWx5jElutfWXiawPHptnVJlEpjM6GEWNq8hewhYfMh5i0j2p0asdfGh860pQLCln/kpchko3yPxrBRI6jQSKY= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A2FB84BAE7C0 Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id AFBC84D372; Mon, 23 Mar 2026 17:20:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774286423; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l6Y4twUI4yuTsHO30VzFG6szh1F5VyfqunDPNrPWo5U=; b=KxkBd30x5BuEcJu8KnOD34wioLMpFPYVuFNkWPQKXQ1WpsUK1o11Old7fkC4vvwog7Z8BG Toib9BLu/Erx1zabd6dCUV9dUadQKhpWCn1MVLaMOoWDfiWxGQ3EytajHJM+fGZJF/ccTV dTp8B8hosJcbvMPEYwepN7Z1BG5s6Bg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774286423; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l6Y4twUI4yuTsHO30VzFG6szh1F5VyfqunDPNrPWo5U=; b=qvljK4g2igI5nZmLt90y8FtDO+5ZU7DJiHntugxuGM9e4rM8kgNHRR1nJgEQI2gC1sAlUy 0dK61Zs/yFUCHuAw== Authentication-Results: smtp-out1.suse.de; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=KxkBd30x; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=qvljK4g2 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1774286423; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l6Y4twUI4yuTsHO30VzFG6szh1F5VyfqunDPNrPWo5U=; b=KxkBd30x5BuEcJu8KnOD34wioLMpFPYVuFNkWPQKXQ1WpsUK1o11Old7fkC4vvwog7Z8BG Toib9BLu/Erx1zabd6dCUV9dUadQKhpWCn1MVLaMOoWDfiWxGQ3EytajHJM+fGZJF/ccTV dTp8B8hosJcbvMPEYwepN7Z1BG5s6Bg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1774286423; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=l6Y4twUI4yuTsHO30VzFG6szh1F5VyfqunDPNrPWo5U=; b=qvljK4g2igI5nZmLt90y8FtDO+5ZU7DJiHntugxuGM9e4rM8kgNHRR1nJgEQI2gC1sAlUy 0dK61Zs/yFUCHuAw== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 9A360439B4; Mon, 23 Mar 2026 17:20:23 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id bA9QJFd2wWnkVAAAD6G6ig (envelope-from ); Mon, 23 Mar 2026 17:20:23 +0000 Message-ID: <9b8e8980-581f-4e89-a843-b52b0bfaf3b7@suse.de> Date: Mon, 23 Mar 2026 18:20:23 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] [gdb/remote] Reimplement escape_buffer To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260321094433.3298268-1-tdevries@suse.de> <87o6ke8wie.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87o6ke8wie.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.51 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; R_DKIM_ALLOW(-0.20)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; MX_GOOD(-0.01)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCPT_COUNT_TWO(0.00)[2]; FROM_HAS_DN(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; RBL_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:104:10:150:64:97:from]; TO_DN_SOME(0.00)[]; MIME_TRACE(0.00)[0:+]; URIBL_BLOCKED(0.00)[imap1.dmz-prg2.suse.org:helo,imap1.dmz-prg2.suse.org:rdns,suse.de:mid,suse.de:dkim,suse.de:email]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_TLS_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; FROM_EQ_ENVFROM(0.00)[]; SPAMHAUS_XBL(0.00)[2a07:de40:b281:104:10:150:64:97:from]; MID_RHS_MATCH_FROM(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; RECEIVED_SPAMHAUS_BLOCKED_OPENRESOLVER(0.00)[2a07:de40:b281:106:10:150:64:167:received]; DKIM_TRACE(0.00)[suse.de:+]; DBL_BLOCKED_OPENRESOLVER(0.00)[suse.de:mid, suse.de:dkim, suse.de:email, imap1.dmz-prg2.suse.org:helo, imap1.dmz-prg2.suse.org:rdns] X-Rspamd-Action: no action X-Rspamd-Server: rspamd1.dmz-prg2.suse.org X-Rspamd-Queue-Id: AFBC84D372 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/23/26 3:12 PM, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> Reimplement function escape_buffer in gdb/remote.c, to print c_isprint chars > Tom> like the actual chars, and others like octal escape sequences, getting us > Tom> instead: > > Tom> - stb.putstrn (buf, n, '\\'); > > Supposedly putstrn does this quoting already. > Why doesn't that work? See ui_file::printchar. > Aha, I read the header comment of putstr/putstrn and concluded from it that it wouldn't quote such chars. Anyway, the way to make this work using putstrn is: ... @@ -10515,6 +10515,7 @@ static std::string escape_buffer (const char *buf, int n) { string_file stb; + scoped_restore reset = make_scoped_restore (&sevenbit_strings, true); stb.putstrn (buf, n, '\\'); return stb.release (); ... > Tom> + /* Append 3-wide leading zero octal \ooo. */ > Tom> + string_appendf (str, "\\%03hho", c); > > I wonder if %hh actually works properly with the gdb format code. > I don't recall ever seeing this before. > The %hh is supported since c++11, so I suppose this is supported by the underlying vsprintf. Thanks, - Tom > Tom