From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 8R0hA/wNvmiFgzIAWB0awg (envelope-from ) for ; Sun, 07 Sep 2025 18:58:04 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=Ci6aGDJm; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 05FFC1E047; Sun, 07 Sep 2025 18:58:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0F43B1E047 for ; Sun, 07 Sep 2025 18:58:03 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B0C123858D35 for ; Sun, 7 Sep 2025 22:58:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B0C123858D35 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=Ci6aGDJm Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by sourceware.org (Postfix) with ESMTPS id 7A2823858D39 for ; Sun, 7 Sep 2025 22:55:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7A2823858D39 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7A2823858D39 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::32d ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757285745; cv=none; b=mxymQJkICnBpP8hIO4X1xdMANGI79Z4z+InuoFDlwD9Az7YWJMbhW+9X20OwmIYlNskVj2gkOxlVmlGVWTK+S/q81pG0Wxv2Qq5qthlbNywew6Sr7j/o06ayGBNpTDpQRKWcr83vT7fzfeVRXlSzIm8Sq0qimscotXsc3si9YYg= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1757285745; c=relaxed/simple; bh=X0MTKY9oeo4BRLNfpS/ebpcGpBN0V3PocbHFQvliqog=; h=DKIM-Signature:Message-ID:Date:MIME-Version:From:Subject:To; b=q31e6MUSn+2oAlklwQyHykmmcv+6sw7jl8Y7ncih3czVl8wPJuBX/CndkzUEwi7lZCedlJnEh4+XsNghYAY5ndqiH3fxAqqGCv/dZqoQmLiqwULt+IEtxyXydtXnBbTGrwfBVHJfm5e2YuQT53U+3wng8FY82SoMXTDckbkB434= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7A2823858D39 Received: by mail-wm1-x32d.google.com with SMTP id 5b1f17b1804b1-45b9814efbcso32069925e9.0 for ; Sun, 07 Sep 2025 15:55:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1757285744; x=1757890544; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:content-language:references :to:subject:from:user-agent:mime-version:date:message-id:from:to:cc :subject:date:message-id:reply-to; bh=PSqhuYV7c9GENMAJnWwm7VutNSEubD284nfU2NBZcG8=; b=Ci6aGDJmNa/EAC02kNee4iT7cwozqyxyFQzXFRtR0OrgNDJUniIPQ7LhMzx4KU72tu g+0MuaCOmicvHv1crsD8Hx/6l1rUty9hZW6p33WqSxmTA7wGI+ZL7NEiQ0eIU0hSOZ8j O3m0oxyafl6Au3nK01v8J6pIEJ8noDbuWOoWGJZV4AOc4kyTYa2mV7XT1RM+x/QFlDJO Z3tMDDvP9C/Jw8Jo3q/BT0IdQ6X8zemgdFexG8OPVh5qNBbbGZO6gQ9aOMsue0TvbxfE iixW6dYXJbBJ5bp8csiSyrjzgUWd5uyEnrDwinZJ2NWTrjYnzTQWlGfl80h2NskjaPMv TiLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1757285744; x=1757890544; h=content-transfer-encoding:in-reply-to:content-language:references :to:subject:from:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=PSqhuYV7c9GENMAJnWwm7VutNSEubD284nfU2NBZcG8=; b=NAjVtQJ9jwQhqTTJUZAa45HTT/xzYv8vZYN7HMXg2vGNaJGp9puq9VI7p2jDFfLY+Y 8a9byygQkI3c4zss7QjLNoT/o75ts8gQ5Ne7gQG6alHLG5Ne+s3P09mzGnPdgHbamE2X XBIKTvXB8sRKJWUs6VtYpj/sSwDqWnBSl7Fbf6UTv2UHgGpYe5cOUliQi++dYXpIWS3G e3RyDTvZ3CqTwgDrdSLGnWyvj9QlvMot5pJ0mOU3A212e1hLa8YQFBSFCbpUVofBcuxA 0KxT2XBBrmOIYAR3MrpyBkN3uGyEI+RRHmhrxAgLz3XeU7emPr1/6B9tVcGVbLtLk0q7 Vc5w== X-Forwarded-Encrypted: i=1; AJvYcCX+pWQLR1f5I7qLEA3+aonBB4jbmNXel2/wy7DfDTaWTLliqb1kmQxNrIqzfg1ndsjfdIypNCTMuupcUQ==@sourceware.org X-Gm-Message-State: AOJu0YzeSBlNo9drZrRSLu0YsBEVubohGeSNDI0NKaD+ntNpo9YU4St9 Xt0auphvetjmVP1qaYTWO/OnSrdeCZcu37VA5PlAnqyMrSoKlFb3vk2AVJiV+PEb X-Gm-Gg: ASbGnctU2OJGgDjSAuiYIkNyxAgFVuBiYuwUtkP6ZhbvnRHHHR18QEuaY00VcAljEeX vRiIjCWQjRgFVDuKHS49LyJ9iJlv9e8/EBGSbbtG8zauADFGfoW8jLPYuf5gNWG1tJ3IPeXuWE/ jOsv0e3IOQQ61G274nBTbsGWtgAHpGcrBkE+Hz0Tvdja4WpKqnQnA5ZxvKyADDcgrTfkKVjfO6Q I+lv+mbPt76slD/7xvMvEWoS8L91we99mJww1/kpuPRWVGGudX0zfYFWr1mFNWg6oCUkktiTuBs UUJHo9oxKhXOw0D/rah1ydGCDsepeptZiHwx2Coo88k2twtOUbDqzMXc6sRPbbOVIzK8IoatFgQ 7otKKiS57Y3Bn7Fr+EZU7ViALnuVWwCiFP8sQvpfvj5CIRSDJtwXlI/nC X-Google-Smtp-Source: AGHT+IGZ36dsq0f9OOz8X1CosUy6UAYbLSZK8P6gvmoja3ssopTsJbtfq/Ae6zfR8t0GmCVZtGWRew== X-Received: by 2002:a05:6000:2382:b0:3e0:f4be:8710 with SMTP id ffacd0b85a97d-3e2ffd7fb6bmr7670830f8f.6.1757285743901; Sun, 07 Sep 2025 15:55:43 -0700 (PDT) Received: from [192.168.0.38] ([86.12.216.189]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45de15de2b7sm59665365e9.14.2025.09.07.15.55.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 07 Sep 2025 15:55:43 -0700 (PDT) Message-ID: <9b23ebe9-5fa4-40a2-bffd-075b15749c92@gmail.com> Date: Sun, 7 Sep 2025 23:55:42 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird From: Luis Subject: Re: [RFC PATCH 2/5] gdbserver/aarch64: Enable FPMR for AArch64 in gdbserver on Linux To: Ezra.Sitorus@arm.com, gdb-patches@sourceware.org References: <20250905131707.77027-1-Ezra.Sitorus@arm.com> <20250905131707.77027-3-Ezra.Sitorus@arm.com> Content-Language: en-US In-Reply-To: <20250905131707.77027-3-Ezra.Sitorus@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 05/09/2025 14:17, Ezra.Sitorus@arm.com wrote: > From: Ezra Sitorus > > Support FPMR in gdbserver. > > Manually validated under Shrinkwrap (Arm FVP). > --- > gdbserver/linux-aarch64-low.cc | 29 +++++++++++++++++++++++++++++ > 1 file changed, 29 insertions(+) > > diff --git a/gdbserver/linux-aarch64-low.cc b/gdbserver/linux-aarch64-low.cc > index 9d3ac803e7b..e15280c3681 100644 > --- a/gdbserver/linux-aarch64-low.cc > +++ b/gdbserver/linux-aarch64-low.cc > @@ -248,6 +248,26 @@ aarch64_store_fpregset (struct regcache *regcache, const void *buf) > supply_register (regcache, AARCH64_FPCR_REGNUM, ®set->fpcr); > } > > +/* Fill BUF with the FPMR from the regcache. */ s/FPMR/FPMR register" > + > +static void > +aarch64_fill_fpmr_regset (struct regcache *regcache, void *buf) > +{ > + uint64_t *fpmr = (uint64_t *) buf; > + int fpmr_regnum = find_regno (regcache->tdesc, "fpmr"); > + collect_register (regcache, fpmr_regnum, fpmr); > +} > + > +/* Store the FPMR to regcache. */ s/FPMR/FPMR register > + > +static void > +aarch64_store_fpmr_regset (struct regcache *regcache, const void *buf) > +{ > + uint64_t *fpmr = (uint64_t *) buf; > + int fpmr_regnum = find_regno (regcache->tdesc, "fpmr"); > + supply_register (regcache, fpmr_regnum, fpmr); > +} > + > /* Store the pauth registers to regcache. */ > > static void > @@ -879,6 +899,10 @@ static struct regset_info aarch64_regsets[] = > { PTRACE_GETREGSET, PTRACE_SETREGSET, NT_ARM_TAGGED_ADDR_CTRL, > 0, OPTIONAL_REGS, > aarch64_fill_mteregset, aarch64_store_mteregset }, > + /* Floating Point Mode Register (FPMR). */ > + { PTRACE_GETREGSET, PTRACE_SETREGSET, NT_ARM_FPMR, > + 0, OPTIONAL_REGS, > + aarch64_fill_fpmr_regset, aarch64_store_fpmr_regset }, > /* TLS register. */ > { PTRACE_GETREGSET, PTRACE_SETREGSET, NT_ARM_TLS, > 0, OPTIONAL_REGS, > @@ -954,6 +978,10 @@ aarch64_adjust_register_sets (const struct aarch64_features &features) > if (features.gcs_linux) > regset->size = sizeof (user_gcs); > break; > + case NT_ARM_FPMR: > + if (features.fpmr) > + regset->size = sizeof (uint64_t); > + break; > default: > gdb_assert_not_reached ("Unknown register set found."); > } > @@ -986,6 +1014,7 @@ aarch64_target::low_arch_setup () > features.mte = linux_get_hwcap2 (pid, 8) & HWCAP2_MTE; > features.tls = aarch64_tls_register_count (tid); > features.gcs = features.gcs_linux = linux_get_hwcap (pid, 8) & HWCAP_GCS; > + features.fpmr = linux_get_hwcap2 (pid, 8) & (1UL << 48); s/1UL/1ULL > > /* Scalable Matrix Extension feature and size check. */ > if (linux_get_hwcap2 (pid, 8) & HWCAP2_SME)