From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id lcGGFawKKmddfSYAWB0awg (envelope-from ) for ; Tue, 05 Nov 2024 07:08:12 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=A69r5ecW; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=xW2J4GEL; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=Mymgih49; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=ue+cTs6k; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3FE241E5E8; Tue, 5 Nov 2024 07:08:12 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_BLOCKED,RCVD_IN_VALIDITY_CERTIFIED,RCVD_IN_VALIDITY_RPBL, RCVD_IN_VALIDITY_SAFE,URIBL_BLOCKED,URIBL_DBL_BLOCKED_OPENDNS autolearn=ham autolearn_force=no version=4.0.0 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 56D851E5E4 for ; Tue, 5 Nov 2024 07:08:11 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EDFCB3857709 for ; Tue, 5 Nov 2024 12:08:10 +0000 (GMT) Received: from smtp-out2.suse.de (smtp-out2.suse.de [IPv6:2a07:de40:b251:101:10:150:64:2]) by sourceware.org (Postfix) with ESMTPS id 09BCC3858023 for ; Tue, 5 Nov 2024 12:07:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 09BCC3858023 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 09BCC3858023 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:2 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730808471; cv=none; b=FzhfyPSvi1GAcJC0ZAY+H2rXO8U43oAtmySifqyk6XJWGLdsez4tsNKp5nGozKIMjaNv9lUWIA/jyKtmIVwYS3AVNU6/Di8zuH0aGtmoNDXLbpiKyeTlKK1Zawdlc8txhLJ2uVu/7oRGlLgL/AgFRWR5vDgtB6VikdOUrDBbmqo= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1730808471; c=relaxed/simple; bh=KVniiSoFDHFww5Wf+/M61/UyFoDss2qNW5VaZI7EP18=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=QWu0O0YNT+HlQo0ja7+7HrRJOjCLyb49eX86IhWZx8cfNG01aFkWpBWBMcFcS4eltkCVyJHYPRXNixgzFn4r7xFgX3ga1Y9ImGUyaHvNDhGznKABu93IEMnEoduRyKiE07Dge8dZNZQUA026sUEhnfFa4FwVHfMvQ6I4tF+TAQI= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 2AF631F811; Tue, 5 Nov 2024 12:07:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1730808468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7JwGTiy94AKQwhdGQHkmYpG+cJMVmWDkZUCvv0jceZI=; b=A69r5ecWfTV3bSHUfQmgu/fz0RzXwd2/6etaB0i80dIfSnXQgjTGThxV7hZX/6twIfslZS toex3bHxbxlzvoLHdASqfF1nWPOJNuiOi4Ep89Q5ubCCjWHJ9ncFs99Qb3RlFm/BSZdRDR buIIredhNCKEL6NbjYF8HL5mpDkclZo= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1730808468; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7JwGTiy94AKQwhdGQHkmYpG+cJMVmWDkZUCvv0jceZI=; b=xW2J4GELUE+WhPX/04tV2hwPWg+NATj3DvW2VboMuAMKgPcdxfNXiXsiidpURORQBS449g R/+bPKjVzufxSWDg== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1730808467; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7JwGTiy94AKQwhdGQHkmYpG+cJMVmWDkZUCvv0jceZI=; b=Mymgih49huXpb//W3lTomfuiuT7l4OJuWijCz1mzNCXGb+UB4UEs23UPRWDAd1yCXZE8PG SAHbr/mDaGCcnCyZfuTb+27hQQ5DDIByPv2ZaVii1v9fkmtUaBGG58uVcfzTkLLVBtyItp v6zP3virm+kHyt4cUpUDxEE8G6rxPSM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1730808467; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=7JwGTiy94AKQwhdGQHkmYpG+cJMVmWDkZUCvv0jceZI=; b=ue+cTs6kjCtlApS+wkMa9AbJ+u/a8F3yxB5VyuualIthUdLOxfQTxCqkHpSVhbQZuG59my Zlu8udshPJrAzXCQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 118E813964; Tue, 5 Nov 2024 12:07:47 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 0hrmApMKKmf2cQAAD6G6ig (envelope-from ); Tue, 05 Nov 2024 12:07:47 +0000 Message-ID: <9b20eea0-0f14-47d9-ad7f-39e197d2e521@suse.de> Date: Tue, 5 Nov 2024 13:07:49 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] [gdbsupport] Add gdb::{waitpid,read,write,close} To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20241028174913.27056-1-tdevries@suse.de> <87y122501s.fsf@tromey.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <87y122501s.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FUZZY_BLOCKED(0.00)[rspamd.com]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo, suse.de:email, suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 11/1/24 18:35, Tom Tromey wrote: >>>>>> "Tom" == Tom de Vries writes: > > Tom> +namespace gdb { > Tom> + > Tom> +extern "C" { > > I didn't even know this was valid ... but is it really needed? > It seems wrong. > It seemed to work: ... $ cat test.c namespace gdb { extern "C" { int foo (void) { return 1; }; } } $ cat test2.c namespace gdb { extern "C" { int foo (void); } } int main (void) { return gdb::foo (); } $ g++ test.c test2.c ... but the linkage symbol is plain foo: ... $ nm ./a.out | grep foo 00000000004004c7 T foo ... So, you're right, this is wrong. I seem to have ended up with gdb_waitpid instead of gdb::waitpid in v2, similar to gdb_select, but thinking about it now I slightly prefer gdb::waitpid. I suppose it doesn't matter that much. > Tom> + pid_t > Tom> + waitpid (pid_t pid, int *wstatus, int options) > Tom> + { > Tom> + return gdb::handle_eintr (-1, ::waitpid, pid, wstatus, options); > Tom> + } > > Also it seems like these could all be inline functions in the header > anyway. Done in v2. In the case of fnctl, I ended up with a template to handle the variable number of arguments. Submitted here ( https://sourceware.org/pipermail/gdb-patches/2024-November/212941.html ). Thanks, - Tom