From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id RI8LJRL3jWBiEwAAWB0awg (envelope-from ) for ; Sat, 01 May 2021 20:49:22 -0400 Received: by simark.ca (Postfix, from userid 112) id 875481F11C; Sat, 1 May 2021 20:49:22 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7CF9D1E01F for ; Sat, 1 May 2021 20:49:21 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E55DA386EC3C; Sun, 2 May 2021 00:49:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E55DA386EC3C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619916560; bh=vjE1hrgEmYaIXbqxlO7rN2Z2+bkwrHv32lpmdjICOys=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=WzX1K2tY4UZWgfIK3CGXhK2yWQ7j/IyHKRg8IXruuC0jgtfuj5PtL0tw/SCId1wql jBzqpCiDD+mTpVnU6NIq6YWX1CtnjwvBhoVsoXCClolh91Sqm6wsfoGdRtZqNr/S0S 75PyVjp84xTw9wsgvbWfvcbOiVLGjsnRceG3qAKI= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 915BB386EC3C for ; Sun, 2 May 2021 00:49:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 915BB386EC3C Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 1420nDHR032038 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Sat, 1 May 2021 20:49:17 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 1420nDHR032038 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 3DAC21E01F for ; Sat, 1 May 2021 20:49:13 -0400 (EDT) Subject: Re: [PATCH] gnulib: import getline To: gdb-patches@sourceware.org References: <20210501220936.30972-1-vapier@gentoo.org> <533969a7-d2fe-cdbd-40dc-e77eab30a469@polymtl.ca> Message-ID: <9b1cfe9d-2366-f626-f555-3ee5a99cddbc@polymtl.ca> Date: Sat, 1 May 2021 20:49:13 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 2 May 2021 00:49:13 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-05-01 8:46 p.m., Mike Frysinger wrote: > On 01 May 2021 20:39, Simon Marchi wrote: >> On 2021-05-01 6:09 p.m., Mike Frysinger via Gdb-patches wrote: >>> We use getline in sim today which breaks on older systems that are >>> compliant with the latest POSIX standard. >> >> I can't really parse that sentence. Using getline doesn't work on older >> systems, because those older systems are compliant with the latest POSIX >> standard? Huh? Wouldn't being compliant with the latest POSIX standard >> be a good thing? > > sorry, meant "not compliant". getline is in POSIX, but not all targets > support it. e.g. Windows (mingw) omit it. > -mike Ah ok, that makes more sense, thanks. Still, please mention the specific platform in the commit message. I always understand better with a concrete example. Thanks! Simon