Re: [RFA 3/3] Move logic out of symbol_find_demangled_name

Pedro Alves
2016-06-17T13:50:35Z

On 06/17/2016 01:36 PM, Tom Tromey wrote:
> Pedro> OK. I still think we should have a comment clarifying this.
> Pedro> The new comment mentions that we'll attempt demangling in the
> Pedro> order the constants are defined, but doesn't explain the
> Pedro> dependencies that led to the particular order you chose.
>
> I added one in language.h but I can move it to enum language instead.

I think I'd prefer it close to where the order is defined.
But maybe there is OK as well; hard to say without seeing.
Maybe do both, and everyone's happy.

As long as we have a comment somewhere discoverable, I'm sure
it'll be fine. So OK however you prefer.

Thanks,
Pedro Alves