From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by sourceware.org (Postfix) with ESMTPS id 5BD283844070 for ; Thu, 13 Aug 2020 12:59:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5BD283844070 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=andrew.burgess@embecosm.com Received: by mail-wm1-x341.google.com with SMTP id k20so4948446wmi.5 for ; Thu, 13 Aug 2020 05:59:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=xZHqWEP2o4iQ9NCglXLKAxDFNgipljJXqzc+P3XLMAw=; b=eOykOB63ilG2nqfkeKJDfoHE2dvpiOq87btbw+LWDCsmWUOBP3JcO9MkOZWgXP1ydF coQeAJrs/55Gzne6H87HLYQOTDDvSv2TXE6i87b8/JoHXwmVWM5eu4GKZVOg54JLrl7L t4PeqTJ4x28hv4pCxBOICRZwOgSxlDDaPL8lRnmQ02eMKLkclifpPVQ81ZbsLk1hOCGe TRWKhpINvnK6yyDi8Bt4vx6Dcus0VzW7XtRbaWeSd+gFqouLu6J0QC+gWrYHWyJSvXaR rEF10heyHtutp27lFHupFw/mBcBOZp5Q+7r+uOTDV0uE0c+MtPxSU157NgyBpsqoC4Vi t07A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=xZHqWEP2o4iQ9NCglXLKAxDFNgipljJXqzc+P3XLMAw=; b=BeiBSLIUXkuyO5u/jrMDsC2GVvADuVgNmQj8UbFpibEFHSvG6kR7kvrTzyCLPHSKp+ F2qAczuCpgc/v8PapnHpktnfNRbRKDJ4uwpooAr0yQqq6ksZXZB9IykUHGUYUDtwR7Me 64WeCW4hNL9CfmuQeD/6r/x9yBBrbtWv1fhBlBCQaPWiNTNBOWcjagHofADeHFRMq7E6 Ji/yrUtTShyCYF8WKLhicUYo+8nMxG8kamLNvte/roVL7FlfBPX86RAblr6tD46Pebcd ZH6Yb16xA7gdOBVPuvpcCFlUtTwgr8n21GbdkAX8aMKe8nk1bSyO61mEvbAQ1TsxIsW1 cyXg== X-Gm-Message-State: AOAM531AvLJNh5yiOXCQZkFIy+dW62ZaTgwgMcXkDpvktULESQTl8hxh IALkVVS2QzYbQka5UaY2oJdogrXzByo= X-Google-Smtp-Source: ABdhPJzESSs/MSclPjUVr4+FFJo903g7/3OJ4yEpDeuPd+IJYef7JYtQLXOdoSh5mF0MPWxffy3f0A== X-Received: by 2002:a7b:c74b:: with SMTP id w11mr4106875wmk.81.1597323543183; Thu, 13 Aug 2020 05:59:03 -0700 (PDT) Received: from localhost (host86-186-80-213.range86-186.btcentralplus.com. [86.186.80.213]) by smtp.gmail.com with ESMTPSA id l18sm10122887wrm.52.2020.08.13.05.59.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Aug 2020 05:59:02 -0700 (PDT) From: Andrew Burgess To: gdb-patches@sourceware.org Subject: [PATCH 7/8] gdb/testsuite: Add missing expected results Date: Thu, 13 Aug 2020 13:58:44 +0100 Message-Id: <9afbe4de3bc0f8cc1f63711113376971b077f502.1597319264.git.andrew.burgess@embecosm.com> X-Mailer: git-send-email 2.25.4 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-10.3 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Aug 2020 12:59:05 -0000 The tests in this script are driven from two lists of expected results, one of the lists is missing some data so DejaGNU ends up matching against the empty string (which passes). This commit adds the missing expected results into the script. I could rewrite this test to make things more robust, however, a later commit is going to completely rewrite this test script, I'm simply adding this here so that _before_ the rewrite the test is complete, then if anyone ever digs into the history of this test script things will make sense (I hope). gdb/testsuite/ChangeLog: * gdb.fortran/array-slices.exp: Add missing message data. --- gdb/testsuite/ChangeLog | 4 ++++ gdb/testsuite/gdb.fortran/array-slices.exp | 5 ++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.fortran/array-slices.exp b/gdb/testsuite/gdb.fortran/array-slices.exp index 8587c51e990..31f95a3668d 100644 --- a/gdb/testsuite/gdb.fortran/array-slices.exp +++ b/gdb/testsuite/gdb.fortran/array-slices.exp @@ -53,7 +53,10 @@ set message_strings \ " = 'array \\(1:5,1:5\\)'" \ " = 'array \\(1:10:2,1:10:2\\)'" \ " = 'array \\(1:10:3,1:10:2\\)'" \ - " = 'array \\(1:10:5,1:10:3\\)'" ] + " = 'array \\(1:10:5,1:10:3\\)'" \ + " = 'other'" \ + " = 'other \\(-5:0, -2:0\\)'" \ + " = 'other \\(-5:4:2, -2:7:3\\)'" ] set i 0 foreach result $array_contents msg $message_strings { -- 2.25.4