From: Simon Marchi <simark@simark.ca>
To: Pedro Alves <palves@redhat.com>
Cc: Simon Marchi <simon.marchi@ericsson.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix type of values representing optimized out static members
Date: Wed, 07 Feb 2018 13:50:00 -0000 [thread overview]
Message-ID: <9aeeb2f46d96a1e6284fb8c5dab523f8@simark.ca> (raw)
In-Reply-To: <4fc7ac76-dfe5-3113-7c9a-f29d3d023b3d@redhat.com>
On 2018-02-07 07:23, Pedro Alves wrote:
> On 02/05/2018 08:00 PM, Simon Marchi wrote:
>> From: Simon Marchi <simark@simark.ca>
>>
>> As reported here:
>>
>> https://sourceware.org/ml/gdb/2018-02/msg00019.html
>>
>> the type of values representing static members that are optimized out
>> is
>> wrong. It currently assigns the type of the containing class rather
>> than the type of the field. This patch fixes that.
>>
>> I found a place in m-static.exp already dealing with optimized out
>> static members, so I just added some gdb_test there.
>>
>> gdb/ChangeLog:
>>
>> * value.c (value_static_field): Assign field type instead of
>> containing type when returning an optimized out value.
>>
>> gdb/testsuite/ChangeLog:
>>
>> * gdb.cp/m-static.exp: Check type of optimized out static
>> member.
>
> Looks right. OK.
>
> Thanks,
> Pedro Alves
Thanks, pushed.
Simon
prev parent reply other threads:[~2018-02-07 13:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-05 20:01 Simon Marchi
2018-02-07 12:23 ` Pedro Alves
2018-02-07 13:50 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9aeeb2f46d96a1e6284fb8c5dab523f8@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=palves@redhat.com \
--cc=simon.marchi@ericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox