From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id oHxWJEWpd2PD7RkAWB0awg (envelope-from ) for ; Fri, 18 Nov 2022 10:48:21 -0500 Received: by simark.ca (Postfix, from userid 112) id 8A12D1E124; Fri, 18 Nov 2022 10:48:21 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=QoZpcSVp; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2B49E1E0CB for ; Fri, 18 Nov 2022 10:48:21 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 62F653853567 for ; Fri, 18 Nov 2022 15:48:20 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 62F653853567 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1668786500; bh=3bubEbTF9G0YT55c0/OHPLWFFl90dfwDsDjQOLSUVz8=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=QoZpcSVpX+bykQ5FQQXpURqP6tmofTP/yO/QMMzWAgLQE4ELY7pKt3tyzEwpDLs+a S5KL1s/Cya5EerkgZwJcu1bcSEec0nzJyfb1IOGdkkA3TEMxm9p5auWzJDDU9euUAD YNQFPknwsv7odqddFzduq4u9uHr6yQ2xLSO0hmsM= Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 48B4F3857C51 for ; Fri, 18 Nov 2022 15:48:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 48B4F3857C51 Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 4193C1E0CB; Fri, 18 Nov 2022 10:47:58 -0500 (EST) Message-ID: <9ae34eea-a4aa-1fe9-bf85-16fb1d7a0ba0@simark.ca> Date: Fri, 18 Nov 2022 10:47:57 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] gdb: fix symtab.c build on 32 bit targets Content-Language: en-US To: Tom Tromey , Simon Marchi via Gdb-patches Cc: Simon Marchi , ro@gcc.gnu.org References: <20221117183226.1632406-1-simon.marchi@efficios.com> <87wn7sqnn4.fsf@tromey.com> In-Reply-To: <87wn7sqnn4.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 11/18/22 10:37, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi via Gdb-patches writes: > > Simon> PR 29798 shows a similar error message but on Solaris. > > It should say "PR build/29798" here, so the commit script can pick it > up. Fixed. > > Simon> Work around that by using string_printf. It is a good thing to get rid > Simon> of the alloca anyway. > > Indeed. IMO alloca should be poisoned. > The patch looks good to me. Thanks, will push. > > Simon> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29798 > > ... we should teach that commit script to pick this up. > I don't know how to access it, though. I will ask Joel. Simon