From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95713 invoked by alias); 9 Feb 2017 13:03:14 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 95701 invoked by uid 89); 9 Feb 2017 13:03:13 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:469, python.c, UD:python.c, pythonc X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Feb 2017 13:03:03 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 358C81B1755; Thu, 9 Feb 2017 13:03:03 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v19D31qp028582; Thu, 9 Feb 2017 08:03:02 -0500 Subject: Re: [RFA 5/5] Remove some gotos from Python To: Tom Tromey , gdb-patches@sourceware.org References: <20170115134253.24018-1-tom@tromey.com> <20170115134253.24018-6-tom@tromey.com> From: Pedro Alves Message-ID: <9ae1fe23-1588-bccc-6e75-39758bc06cbd@redhat.com> Date: Thu, 09 Feb 2017 13:03:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170115134253.24018-6-tom@tromey.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-02/txt/msg00222.txt.bz2 On 01/15/2017 01:42 PM, Tom Tromey wrote: > This patch slightly refactors a couple of spots in the Python code to > avoid some gotos. > > 2017-01-15 Tom Tromey > > * python/python.c (do_start_initialization): New function, from > _initialize_python. > (_initialize_python): Call do_start_initialization. > * python/py-linetable.c (ltpy_iternext): Use explicit returns, not > goto. OK. Thanks, Pedro Alves