From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id lxdHJcpphWJW+gYAWB0awg (envelope-from ) for ; Wed, 18 May 2022 17:48:58 -0400 Received: by simark.ca (Postfix, from userid 112) id 88D1E1E220; Wed, 18 May 2022 17:48:58 -0400 (EDT) Authentication-Results: simark.ca; dkim=fail reason="signature verification failed" (2048-bit key; secure) header.d=freebsd.org header.i=@freebsd.org header.a=rsa-sha256 header.s=dkim header.b=wTTtZpF1; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.7 required=5.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,NICE_REPLY_A,RDNS_DYNAMIC autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A3EBF1E01D for ; Wed, 18 May 2022 17:48:57 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 04CD13857806 for ; Wed, 18 May 2022 21:48:57 +0000 (GMT) Received: from mx2.freebsd.org (mx2.freebsd.org [IPv6:2610:1c1:1:606c::19:2]) by sourceware.org (Postfix) with ESMTPS id E63AC3858413 for ; Wed, 18 May 2022 21:48:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E63AC3858413 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id EDE4598B78; Wed, 18 May 2022 21:48:43 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4L3RSq5hmJz4f6c; Wed, 18 May 2022 21:48:43 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1652910523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EtgEyBGUZiy+AFxeb2Hkpa9gmdTbA6Na4097Vo14hQ8=; b=wTTtZpF1QUcOTfefB6KCRLBsP697tyouwpeYMZcv8PZ+2JrSa1YCHP88hDC3AH/V9ZFIR2 TC1RjKYxTFkdoEf1AQYKd5SWc+4Lapg7N+TL176uQhBvlXQlzcTyxypA6u3YUPlau3/98+ vRl9x4S0mSqpG/dvN6SQQHGLgWbZghT6+nx2HZzOJMqNjBAD8cSOdHcAJ8cpai5CcD9CLG chUhrDvhU86R55xjDEjjPw6E1wOxwGyjT7WbyNqhRSsJdCyh2Cg+ro1BR7gcToJ2iomIWH Gjvsdmfqk1BQv64pbXl638tCpjpIwIa5VwD4vD2wqYUthVApCUzGLKyK5q5Vtg== Received: from [IPV6:2601:648:8680:ed60:8ce3:c94a:ed81:31cb] (unknown [IPv6:2601:648:8680:ed60:8ce3:c94a:ed81:31cb]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 3E5B12664D; Wed, 18 May 2022 21:48:43 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: <9aa0af42-2405-60b6-dc4e-4333c3239314@FreeBSD.org> Date: Wed, 18 May 2022 14:48:41 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.9.0 Subject: Re: [PATCH v3 00/13] Handle variable XSAVE layouts Content-Language: en-US To: "George, Jini Susan" , "gdb-patches@sourceware.org" References: <20220503210515.30739-1-jhb@FreeBSD.org> From: John Baldwin In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1652910523; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=EtgEyBGUZiy+AFxeb2Hkpa9gmdTbA6Na4097Vo14hQ8=; b=uvoxICg1NbtwzCH+VHuVNldShUmyeaWn1DB2n6u7gdiueufDVSZfc4wRL99xFOFBmXQmsm bCPVZjo5DHQvGsTA+vV1J9lybqH7XqVAKuH3tuHNXohQjmcqrvCEywYHFRMxM7NW3HzfZw 8vGKQC1dGqvKnNyBoYzx3tFDS2d7Bdtzit3lZ33kwOxs3OovIcksKVO72I05ZfURfDhu8N qs+WtFSH47VWi/JO9wWcH2KOw3c9P+D1poGLPbyXzukxbdeNjHQDMb+39XaSC1RNVQuB7j +gmbR85jHUPfdtRA92sqmhaSfg4rarFkx6arRohMw+4AQEYJauzKYVTX9ZTiAw== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1652910523; a=rsa-sha256; cv=none; b=ZrZw9g0sJufctNy54iShTq9KnTo1sgnRBeJ70wXRubjoz/xwZuuhWhMDgZR4Jg5T5DyGSg zJzlrNFAnGKW7uYdSpIlpLx1LTKGbEOivw/Ow/n1rbM8WwZthfYO+r+c54UVwidhyRhpoC XkiXqUMqPnsSQPZDA6BLkOTy462HDbl9AqEiV23F7pJ49FkoVGQmMv9eIh126To+gcbh4K aO/id57VOPynGJ+L3qsx60Ld0Go1hP5xjHdIWLLXyOecoK6BUpn/fos7M1G0O/1v9g1vAB lQgcY+4+qiNdj0B+PLs4At4kDUaIaIDQhJOSSOFZi8VrfIHXEg2bgGSOv40IfA== ARC-Authentication-Results: i=1; mx1.freebsd.org; none X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 5/10/22 3:48 AM, George, Jini Susan wrote: > [Public] > > Thanks again for doing this, John, Felix and Aleksandar. I went through the changes and tested on a few AMD CPUs of differing xsave layouts. As of now these changes seem to cover the current AMD CPU implementations. Going forward, if additional AMD specific layouts have to be added, we would do it. > > The changes look good to me (I am no approver, though) for the most part. A few minor comments: > > Nit: in gdb/i386-tdep.h, it might be good to add a comment for the following line (line # 148) for consistency with the rest of the fields. > x86_xsave_layout xsave_layout; Done. > Nit: You might want to modify the comments preceding the modified xsave_*_offset[] definitions in gdb/i387-tdep.c to reflect that the offset to the locations are at (tdep)->xsave_layout.*_offset + xsave_*_offset[REGNUM]. Ok, I have done so locally though tried to describe this a bit differently. For example: /* At xsave_avxh_offset[REGNUM] you'll find the relative offset within the AVX region of the XSAVE extended state where the upper 128bits of GDB register YMM0 + REGNUM is stored. */ > Nit: Line 771 in gdb/i387-tdep.c. Might make sense to remove the "HI16_ZMM_area +" part. Done. Thanks! -- John Baldwin