From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id LzcBGYRnh2AjdQAAWB0awg (envelope-from ) for ; Mon, 26 Apr 2021 21:23:16 -0400 Received: by simark.ca (Postfix, from userid 112) id 52C3E1F11C; Mon, 26 Apr 2021 21:23:16 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C7C4F1E54D for ; Mon, 26 Apr 2021 21:23:15 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5814238930CF; Tue, 27 Apr 2021 01:23:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5814238930CF DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619486595; bh=EbZDduFXKUgshq2KJpHgF4F7C0zZk0koVlk1EXfwsA8=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=l8U2YumKPPNlvE8nSCf/Nn3uwPDNyzlBmoepTfXXLkxOg74LOTgw+B/1TVj0uY+iu AvgXOj3BUu36VFO/sW1rbfFUvnLjPfK08g+XUHq6AN6akTs3NzMK0h0Hx0lBMNT/N8 h3mBHPKYJQDOnl5EXFaukFCMXbpDxoyGMKkl0q2k= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 92611383581A for ; Tue, 27 Apr 2021 01:23:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 92611383581A Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 13R1N4BJ020895 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 26 Apr 2021 21:23:08 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 13R1N4BJ020895 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 04ED61E54D; Mon, 26 Apr 2021 21:23:03 -0400 (EDT) Subject: Re: [PATCH 02/43] Cleanup of the dwarf_expr_context constructor To: Zoran Zaric , gdb-patches@sourceware.org References: <20210301144620.103016-1-Zoran.Zaric@amd.com> <20210301144620.103016-3-Zoran.Zaric@amd.com> Message-ID: <9a9febd0-e44c-bbe5-488f-871a3bbc486f@polymtl.ca> Date: Mon, 26 Apr 2021 21:23:03 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <20210301144620.103016-3-Zoran.Zaric@amd.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 27 Apr 2021 01:23:04 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-03-01 9:45 a.m., Zoran Zaric via Gdb-patches wrote: > Move the initial values for dwarf_expr_context class data members > to the class declaration in expr.h. > > gdb/ChangeLog: > > * dwarf2/expr.c (dwarf_expr_context::dwarf_expr_context): > Remove initial data members values. > * dwarf2/expr.h (dwarf_expr_context): Add initial values > to the class data members. LGTM. I suggest you push this right away, it's a good cleanup and it will be one less patch to carry. Simon