From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id k4S9OIQ8cmrGEwcAWB0awg (envelope-from ) for ; Tue, 04 Aug 2026 15:24:52 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=f/n/Jwtg; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id D39001E09B; Tue, 04 Aug 2026 15:24:52 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 203641E09B for ; Tue, 04 Aug 2026 15:24:52 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id DC0624BB3B91 for ; Tue, 4 Aug 2026 19:24:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org DC0624BB3B91 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=f/n/Jwtg Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 651004BB24F6 for ; Tue, 4 Aug 2026 19:24:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 651004BB24F6 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 651004BB24F6 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785871461; cv=none; b=KGgKeWaooB1lF7CpbK3HDK44yVY83mujurdqifxpvJihLN+m8qXhRmwwli/vSenX1vKdEPHvTBIC34jDjSR/FqRQgZhc86pVtcWVa8kFuVlgvtnIbZUX24tJKql+5rUkR3SVnBi+Wi/EfSg6Y5ESxB/DWaAUaicrqSiz9fNnPA0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1785871461; c=relaxed/simple; bh=N7Vc5uc0iucS8zMV8ziUcSgkIbAyfw5GeyEFeFCNy3k=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=rJ6aIt1mICmRHJLzvC6RPMHCvP8OZJjtwztSgUfklW3ZyZOwH3gdg7zlxK16CfMohcMtP1vnNH1wPHs0JFIGUBLFlWYRYllUkm3k3V/AUXGLpHLrB3UaNkt9BpSq1E7/wp0qQsJ9CwrxCOJKKDh3UJ9kmAk2z0mV6D4hFuAs838= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=f/n/Jwtg DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 651004BB24F6 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 674JO9fB031482 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 4 Aug 2026 15:24:14 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 674JO9fB031482 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1785871454; bh=3EXRTFFSt88nhlCZeTN1teV/jVF1wsP+/Ply7OOrBnA=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=f/n/Jwtgk1lF2g0ErQ/lIuOgmmbPEBDrQdX5I7IM0ZF1nfndjQvu3aYLbAwH3WvDp tDGFUGqlLvdjntR13x0toeHCxF2sJRrosXgPCSuZtX1rYGfHK5cWVTY57zE1KUV2/P HLy1fDQD1iisnvgyqQ1Stvn+3gkXC1Jsqer+hv3Yhxs6jycVaI8paAShua79V4Zo5G zYWDfM7Q6AA5svGZJn+xTeKHoSnhZ1ZBq7cPIo0/MGeqv8fkfrrPfRo6bybGi+k3u5 RbKEJywXj2vEnfdHL/daUw4nRnpCnqT8iWfzZGUftrA8273zCV4huIE0ZkDswkZVhq FKEAS6m7oNEWQ== Received: by simark.ca (Postfix) id 12A791E09B; Tue, 04 Aug 2026 15:24:08 -0400 (EDT) Message-ID: <9a86131a-860e-429d-84fb-d86e2f452f5d@polymtl.ca> Date: Tue, 4 Aug 2026 15:24:08 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 08/10] gdb: add objfile -> solib backlink To: Tom Tromey Cc: gdb-patches@sourceware.org, Lancelot SIX References: <20260708215145.93134-1-simon.marchi@polymtl.ca> <20260708215145.93134-9-simon.marchi@polymtl.ca> <87ldb4uu4b.fsf@tromey.com> <87h5l9zsr6.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <87h5l9zsr6.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Tue, 4 Aug 2026 19:24:09 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-08-04 13:43, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> I could change it to `const std::vector &` or > Simon> `gdb::array_view`. The latter sounds better, since callers > Simon> don't need to know they are stored in a vector (we could also return an > Simon> even more generic "range" type, but I guess that would require more > Simon> boilerplate (unless we already have a class to accomplish this easily > Simon> that I forgot about?). > > ... > > Simon> + if (const auto &solibs = objfile->solibs (); > Simon> + !solibs.empty ()) > Simon> + return solibs.front (); >>> >>> I wonder if instead you would consider exposing something like this as a >>> method on objfile. > > Simon> Like a "first_solib ()" method? I certainly can do that. > > Either the array_view or the first_solib approach would be totally fine > by me. Thanks. Ok, when I did the change I realized what you mean. We only ever care about the first solib, so if there is this first_solib() method, we can get first of the solibs() method. I'll do that. Simon