Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Joel Brobecker <brobecker@adacore.com>, Yao Qi <qiyaoltc@gmail.com>
Cc: Xavier Roirand <roirand@adacore.com>,
	gdb-patches@sourceware.org, tgingold@free.fr
Subject: Re: [RFA/Darwin] Recognize .plt section
Date: Mon, 05 Mar 2018 12:32:00 -0000	[thread overview]
Message-ID: <9a760bb1-f696-8a3d-6271-b83860b186f7@redhat.com> (raw)
In-Reply-To: <20180305115940.sjosq3os3akrdsfy@adacore.com>

On 03/05/2018 11:59 AM, Joel Brobecker wrote:
>>> +2018-03-02  Tristan Gingold  <gingold@adacore.com>
>>> +
>>> +	Pushed by Xavier Roirand <roirand@adacore.com>
>>
>> Nowadays, in case of author != commiter, we don't write down the name of
>> committer in ChangeLog.  Any reason you do so?  I noticed that you did
>> this in several Tristan's patches.
> 
> It's something I have been doing on occasions. The idea was that
> people working from source packages alone could see who did the push.
> But I'm not really attached to it, so this can be skipped if people
> prefer.

The GNU coding standards has section saying not to do that.  From
<https://www.gnu.org/prep/standards/standards.html>:

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
When you install someone else’s changes, put the contributor’s name in the change
log entry rather than in the text of the entry. In other words, write this:

2002-07-14  John Doe  <jdoe@gnu.org>

        * sewing.c: Make it sew.

rather than this:

2002-07-14  Usual Maintainer  <usual@gnu.org>

        * sewing.c: Make it sew.  Patch by jdoe@gnu.org.

As for the date, that should be the date you applied the change. 
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Thanks,
Pedro Alves


      reply	other threads:[~2018-03-05 12:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-05  8:54 Xavier Roirand
2018-03-05 11:48 ` Yao Qi
2018-03-05 11:59   ` Joel Brobecker
2018-03-05 12:32     ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a760bb1-f696-8a3d-6271-b83860b186f7@redhat.com \
    --to=palves@redhat.com \
    --cc=brobecker@adacore.com \
    --cc=gdb-patches@sourceware.org \
    --cc=qiyaoltc@gmail.com \
    --cc=roirand@adacore.com \
    --cc=tgingold@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox