From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23021 invoked by alias); 13 Jun 2016 15:26:08 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 23005 invoked by uid 89); 13 Jun 2016 15:26:07 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.3 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Mon, 13 Jun 2016 15:25:57 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A63727F080; Mon, 13 Jun 2016 15:25:56 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5DFPtrp021891; Mon, 13 Jun 2016 11:25:56 -0400 Subject: Re: [PATCH 10/12] Switch current_thread to lwp's thread in install_software_single_step_breakpoints To: Yao Qi , gdb-patches@sourceware.org References: <1464859846-15619-1-git-send-email-yao.qi@linaro.org> <1464859846-15619-11-git-send-email-yao.qi@linaro.org> From: Pedro Alves Message-ID: <9a7294da-3904-9ba1-db2d-57a0db18c8b5@redhat.com> Date: Mon, 13 Jun 2016 15:26:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1464859846-15619-11-git-send-email-yao.qi@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-06/txt/msg00241.txt.bz2 On 06/02/2016 10:30 AM, Yao Qi wrote: > install_software_single_step_breakpoints has parameter lwp, but still > need to switch to current_thread. In order to simplify its caller, > we do the current_thread save/restore inside install_software_single_step_breakpoints. > > gdb/gdbserver: > > 2016-05-25 Yao Qi > > * gdbthread.h (make_cleanup_restore_current_thread): Declare. > * inferiors.c (do_restore_current_thread_cleanup): New function. > (make_cleanup_restore_current_thread): Likewise. > * linux-low.c (install_software_single_step_breakpoints): Call > make_cleanup_restore_current_thread. Switch current_thread to > thread. OK. Thanks, Pedro Alves