From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 50840 invoked by alias); 19 Jun 2017 21:24:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 50407 invoked by uid 89); 19 Jun 2017 21:24:38 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS,T_RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 19 Jun 2017 21:24:21 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E8B6180F8F; Mon, 19 Jun 2017 21:24:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com E8B6180F8F Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=palves@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com E8B6180F8F Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 214931749C; Mon, 19 Jun 2017 21:24:14 +0000 (UTC) Subject: Re: [PATCH 02/25] Adjust the order of 32bit-linux.xml and 32bit-sse.xml in i386/i386-linux.xml To: Simon Marchi , Yao Qi References: <1497256916-4958-1-git-send-email-yao.qi@linaro.org> <1497256916-4958-3-git-send-email-yao.qi@linaro.org> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: <9a60c2a9-09ef-c21a-db18-385105d986a1@redhat.com> Date: Mon, 19 Jun 2017 21:24:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-06/txt/msg00548.txt.bz2 On 06/19/2017 09:22 PM, Simon Marchi wrote: > On 2017-06-12 10:41, Yao Qi wrote: >> Exchange the order of 32bit-linux.xml and 32bit-sse.xml in >> i386/i386-linux.xml, to align with other i386 linux .xml files. >> >> --- a/gdb/features/i386/i386-linux.xml >> +++ b/gdb/features/i386/i386-linux.xml >> @@ -12,6 +12,6 @@ >> i386 >> GNU/Linux >> >> - >> >> + >> > > I think you can push this one right away as a cosmetic cleanup. Unless this is a case of a default target description matching the layout of targets that predated support for XML descriptions. Could that be the case here? From: static void i386_linux_init_abi (struct gdbarch_info info, struct gdbarch *gdbarch) { ... if (! tdesc_has_registers (tdesc)) tdesc = tdesc_i386_linux; ... ... it may well be. So we need to tread carefully here. The order may be required for back compatibility. A deeper audit with that in mind is in order. Thanks, Pedro Alves