Re: [PATCH v3 1/2] Introduce "gdb/configure.nat" (and delete "gdb/config/*/*.mh" files)

Pedro Alves
2017-05-05T16:35:28Z

On 05/05/2017 05:29 AM, Sergio Durigan Junior wrote:

> +# Native-target dependent makefile fragment comes in here.
> +@nat_extra_makefile_frag@
> +

> rename from gdb/config/i386/i386gnu.mh
> rename to gdb/config/i386/i386gnu-extra.mh
> index 070497f..93016ff 100644
> --- a/gdb/config/i386/i386gnu.mh
> +++ b/gdb/config/i386/i386gnu-extra.mh

...

> # MIG stubs are not yet ready for C++ compilation.
> -%_S.o %_U.o : COMPILE.post += -x c
> +%_S.o %_U.o : COMPILE.post +=-x c
>

Spurious whitespace change.

> NAT_GENERATED_FILES = notify_S.h notify_S.c \
> - process_reply_S.h process_reply_S.c \
> - msg_reply_S.h msg_reply_S.c msg_U.h msg_U.c \
> - exc_request_U.h exc_request_U.c exc_request_S.h exc_request_S.c
> + process_reply_S.h process_reply_S.c \
> + msg_reply_S.h msg_reply_S.c msg_U.h msg_U.c \
> + exc_request_U.h exc_request_U.c exc_request_S.h exc_request_S.c

Ditto.

Apart from the naming issue and the spurious whitespace changes,
this looks fine to me.

Thanks,
Pedro Alves