From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Ysx/NlkQWmrObw4AWB0awg (envelope-from ) for ; Fri, 17 Jul 2026 07:22:01 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=B6KbBLWy; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=E/fT30A+; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=B6KbBLWy; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=E/fT30A+; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id CAFE31E09E; Fri, 17 Jul 2026 07:22:01 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C23CE1E099 for ; Fri, 17 Jul 2026 07:21:59 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E0CAD4BA23CA for ; Fri, 17 Jul 2026 11:21:57 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E0CAD4BA23CA Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=B6KbBLWy; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=E/fT30A+; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=B6KbBLWy; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=E/fT30A+ Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2a07:de40:b251:101:10:150:64:1]) by sourceware.org (Postfix) with ESMTPS id B46464BA2E0A for ; Fri, 17 Jul 2026 11:21:33 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org B46464BA2E0A Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org B46464BA2E0A Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a07:de40:b251:101:10:150:64:1 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784287293; cv=none; b=X+eELXWHz56o/7pzo1uscKC33ploJ7Qf+e26aEimrZYezEhHr7RuWbV6xW1Skhd6DhFGO+tmED7X7RPu1bNXQjs+KiY0oX6R1tBJgHiRzoySNb7Idmz5k0mDKZeXPdoTmGPo8vfj9Ul9QewMFKL9Mm8M6dK4U8UKVX3KVGjJYBA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1784287293; c=relaxed/simple; bh=YPyKvmbs/NJcYxbEhy9ZkYpjtfTlCPxIKSOIx4bs8nA=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=etLrfL0D9AE7sfIDNXjTKcAco4iEtGdNqxEXkrOsv7r7O2XVI4CECxg2AzrZPgkOhYMlcRxjdmJe7ZmNLutnaM+wvD4ih/j+5+c9wyqecPylC57yT1+LJ5zWPLUiIMfsazTHRVTjEyXQSMk+pgiwI6xEM45BBtwDFwsD/I0bV3s= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=B6KbBLWy; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=E/fT30A+; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=B6KbBLWy; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=E/fT30A+ DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B46464BA2E0A Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8B19878E6B for ; Fri, 17 Jul 2026 11:21:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1784287292; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=raWQVx6L/QofTzYaR0CYRzcgJMzlQMMKYrbi2wole4U=; b=B6KbBLWy1L0sC0l/CGl8K1IwVQqH6E6bxGrORXPDYyg16XwDtl9ao4dnQNS5IGsIShri0u fsP7X38jVJAcWSkOIg+xycy6G+9oDC6PBVSOGzwm5NRNDLu5gAqb9DbwVLuKkIOoMXJawd XLP4MqeRfyJkMKaMQV2sPTxldI8lLG4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1784287292; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=raWQVx6L/QofTzYaR0CYRzcgJMzlQMMKYrbi2wole4U=; b=E/fT30A+Isygv7rSFMGzBvjOUudxfT6PhRH+Nu8OOKaLh9SqERCp+EX7X5a2oy7fi9kdYd LPbIABr+ixKen/Cg== Authentication-Results: smtp-out1.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1784287292; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=raWQVx6L/QofTzYaR0CYRzcgJMzlQMMKYrbi2wole4U=; b=B6KbBLWy1L0sC0l/CGl8K1IwVQqH6E6bxGrORXPDYyg16XwDtl9ao4dnQNS5IGsIShri0u fsP7X38jVJAcWSkOIg+xycy6G+9oDC6PBVSOGzwm5NRNDLu5gAqb9DbwVLuKkIOoMXJawd XLP4MqeRfyJkMKaMQV2sPTxldI8lLG4= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1784287292; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=raWQVx6L/QofTzYaR0CYRzcgJMzlQMMKYrbi2wole4U=; b=E/fT30A+Isygv7rSFMGzBvjOUudxfT6PhRH+Nu8OOKaLh9SqERCp+EX7X5a2oy7fi9kdYd LPbIABr+ixKen/Cg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 7A2B7779AA for ; Fri, 17 Jul 2026 11:21:32 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ccJpHDwQWmrAaAAAD6G6ig (envelope-from ) for ; Fri, 17 Jul 2026 11:21:32 +0000 Message-ID: <9a48d793-2f3e-4ce9-950b-52c48ad1fea0@suse.de> Date: Fri, 17 Jul 2026 13:21:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [pre-commit] Fix codespell-log hook From: Tom de Vries To: gdb-patches@sourceware.org References: <20260716165436.1416427-1-tdevries@suse.de> Content-Language: en-US In-Reply-To: <20260716165436.1416427-1-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; MID_RHS_MATCH_FROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo,suse.de:mid] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 7/16/26 6:54 PM, Tom de Vries wrote: > A recent commit added this top-level setting to .pre-commit-config.yaml: > ... > files: '^(gdb|gdbserver|gdbsupport)/' > ... > > This broke the codespell-log hook, which is a commit-msg hook, which is called > with the commit message as first argument. > > However, the top-level files setting filters out .git/COMMIT_EDITMSG, with the > consequence that the commit-msg hook is no longer called. > > It seems obvious to me that this is a pre-commit bug: the files field is there > to filter files in the repository, which .git/COMMIT_EDITMSG is not one of. > But upstream disagrees [1]. > > Use the workaround suggested as fix upstream: include .git/COMMIT_EDITMSG in > the default files set. > > [ FWIW, that still doesn't fix something like this: > ... > $ tmp=$(mktemp) > $ echo 'msg' > $tmp > $ pre-commit run --hook-stage commit-msg --commit-msg-filename $tmp > ... > > I wanted to mention that upstream, but I couldn't because I was already locked > out of commenting on the issue I filed. ] > > Alternatively, we can drop the top-level files setting, and revert to > per-hook settings. > Writing a regression test for this made me realize that the workaround proposed in this patch is not sufficient, so I've committed a v2 ( https://sourceware.org/pipermail/gdb-patches/2026-July/228714.html ) that reverts to per-hook settings. Thanks, - Tom > [1] https://github.com/pre-commit/pre-commit/issues/3720 > --- > .pre-commit-config.yaml | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/.pre-commit-config.yaml b/.pre-commit-config.yaml > index 2f86a333ab5..fda10e30b1d 100644 > --- a/.pre-commit-config.yaml > +++ b/.pre-commit-config.yaml > @@ -40,7 +40,9 @@ > minimum_pre_commit_version: 4.5.1 > default_install_hook_types: [pre-commit, commit-msg] > default_stages: [pre-commit] > -files: '^(gdb|gdbserver|gdbsupport)/' > +# The ^\.git/COMMIT_EDITMSG$ is there to make sure commit-msg hooks work. > +# See this issue ( https://github.com/pre-commit/pre-commit/issues/3720 ). > +files: '^(gdb|gdbserver|gdbsupport)/|^\.git/COMMIT_EDITMSG$' > > repos: > # Python hooks. Run these for (in glob notation): > > base-commit: a4481c8ff808e7237b99815d84b0d4c06ded6124