From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id kOIQJ0RvVmPJDBAAWB0awg (envelope-from ) for ; Mon, 24 Oct 2022 06:56:04 -0400 Received: by simark.ca (Postfix, from userid 112) id 9BE361E112; Mon, 24 Oct 2022 06:56:04 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=EbMg/iPx; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 540F51E0CB for ; Mon, 24 Oct 2022 06:56:04 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 05FE23858012 for ; Mon, 24 Oct 2022 10:56:04 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 05FE23858012 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1666608964; bh=PrfywqKV8zwetURnCK33E4OKI2IqER4X0ce3MFEg9r0=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=EbMg/iPxW7qHKvO5oByzGmkpi9q2lIJxfK/bSNjMEHzfv7uEz0/lMoMmgf6TWDBAc t0jZYBym6tYyLHi1i+mzadwqGf+GduObIllhR3XNwOm3XLGjvfiW1ICs4cjNEnKnFS d8nAt5Tyo3xi1oJAJdWMaKB0cCjwcpa5agdSZVAY= Received: from mail-sender-0.a4lg.com (mail-sender-0.a4lg.com [IPv6:2401:2500:203:30b:4000:6bfe:4757:0]) by sourceware.org (Postfix) with ESMTPS id 231FD3858022 for ; Mon, 24 Oct 2022 10:55:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 231FD3858022 Received: from [127.0.0.1] (localhost [127.0.0.1]) by mail-sender-0.a4lg.com (Postfix) with ESMTPSA id 82160300089; Mon, 24 Oct 2022 10:55:43 +0000 (UTC) Message-ID: <9a25e076-17d8-13b5-6ca5-abcda37d15b7@irq.a4lg.com> Date: Mon, 24 Oct 2022 19:55:41 +0900 Mime-Version: 1.0 Subject: Re: [PATCH 15/40] sim/h8300: Add "+ 0x0" to avoid self-assignments Content-Language: en-US To: Mike Frysinger , gdb-patches@sourceware.org References: <5ab303a5bdfc1da7832f8fa22f57678c9ef1a5fa.1666258361.git.research_trasio@irq.a4lg.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tsukasa OI via Gdb-patches Reply-To: Tsukasa OI Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2022/10/23 23:05, Mike Frysinger wrote: > On 20 Oct 2022 09:32, Tsukasa OI wrote: >> Clang generates a warning if there is a redundant self-assignment >> ("-Wself-assign"). On the default configuration, it causes a build failure >> (unless "--disable-werror" is specified). >> >> However, removing self-assignments in step_once function makes the code less >> readable. Instead, this commit inserts dummy addition to match the comments >> "Value added == 0". This is redundant but will suppress warnings and >> matches with other branches better. It will be also optimized away so we >> can ignore performance impact on this. >> --- >> sim/h8300/compile.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> --- a/sim/h8300/compile.c >> +++ b/sim/h8300/compile.c >> @@ -4141,7 +4141,7 @@ step_once (SIM_DESC sd, SIM_CPU *cpu) >> res = GET_B_REG (code->src.reg); /* FIXME fetch? */ >> if (!c && (0 <= (res >> 4) && (res >> 4) <= 9) && >> !h && (0 <= (res & 0xf) && (res & 0xf) <= 9)) >> - res = res; /* Value added == 0. */ >> + res = res + 0x0; /* Value added == 0. */ > > Andrew posted a patch to just delete the assignment. either is fine with me. > -mike I'll leave it for Andrew and I will withdraw following patches from my patchset: - PATCH 03/40 - PATCH 15/40 - PATCH 16/40 (wrote by Andrew) - PATCH 28/40 - PATCH 30/40 - PATCH 36/40 Because this patchset (intended to be a RFC PATCH) is a mere copy of my working branch, I need to sync with Andrew's work. Thanks, Tsukasa