From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 30BiN2K8oWk3qgwAWB0awg (envelope-from ) for ; Fri, 27 Feb 2026 10:46:42 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=rO9c93GO; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=57EkB69n; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=rO9c93GO; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=57EkB69n; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id CEC281E0DD; Fri, 27 Feb 2026 10:46:42 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 13FCC1E089 for ; Fri, 27 Feb 2026 10:46:42 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 8FFFA4B9DB5B for ; Fri, 27 Feb 2026 15:46:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8FFFA4B9DB5B Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=rO9c93GO; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=57EkB69n; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=rO9c93GO; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=57EkB69n Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 708FD4BA2E0B for ; Fri, 27 Feb 2026 15:46:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 708FD4BA2E0B Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 708FD4BA2E0B Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772207173; cv=none; b=cdliGTZhLAJ9vOfXZfY6+tcuz44n3bBrXclBRLHyfzQDeUFFLED25j3ueJC8h5GZOcDPd8oGvZsxkE7qd43ubXijWXl50+bxFp5Mer/IsLkWbzL5ivnsUhm2hcYEYu+sg8+cd4DW6S8MFLIoKj8WDLzMsEFC5MGb/aANKTcxbVE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1772207173; c=relaxed/simple; bh=VqD5tufvJ7GXH+2SCybZgm+dRA7UYwE/QE+c3jP/XSY=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:To:From; b=p/fjqVJv6FN4yzuFXBaEV2HkgNxKTVeDZ0d6N6Rs1ZvWsQI2LRBcRhrJu8uZitFmyjmig7nUzaZe2gRyu7N/gW+Qiy1Skj02P/F2besypyG7XSYhG3WPh4U2p7vgEedh3UDzjZwOZgtYmeT2xfHhoay7U09pok82tvE5yXU5G3Q= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 708FD4BA2E0B Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 64EB75D291; Fri, 27 Feb 2026 15:46:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772207172; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wkEfwId/rM1qjQMqrXx5aQAF1EaTOjDb++4yPf7Xefk=; b=rO9c93GOUjhNgiDm31by+AVSZTt5ebCvTVQwX4HdjkPmn6tQs2UmEXDxSNBdD6Uuvb20vG TMocNrRnN5dXFf7nQFqXcyyHQ62M5FIaeYx2xSOORosDQ+f+ACS87UsgsGJ60DUdyBi1p3 ta91lEHaQ2kfxAojqhG4oEzfP4u4PnM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772207172; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wkEfwId/rM1qjQMqrXx5aQAF1EaTOjDb++4yPf7Xefk=; b=57EkB69nUivo0cOO2WzcUH378GKHG7F9XOkMwVYj5SltGnqPKW9tYU5BP+NxZ/hSJ0O/CM xPhCGw3w3fgN34BQ== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1772207172; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wkEfwId/rM1qjQMqrXx5aQAF1EaTOjDb++4yPf7Xefk=; b=rO9c93GOUjhNgiDm31by+AVSZTt5ebCvTVQwX4HdjkPmn6tQs2UmEXDxSNBdD6Uuvb20vG TMocNrRnN5dXFf7nQFqXcyyHQ62M5FIaeYx2xSOORosDQ+f+ACS87UsgsGJ60DUdyBi1p3 ta91lEHaQ2kfxAojqhG4oEzfP4u4PnM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1772207172; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=wkEfwId/rM1qjQMqrXx5aQAF1EaTOjDb++4yPf7Xefk=; b=57EkB69nUivo0cOO2WzcUH378GKHG7F9XOkMwVYj5SltGnqPKW9tYU5BP+NxZ/hSJ0O/CM xPhCGw3w3fgN34BQ== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4DFC73EA69; Fri, 27 Feb 2026 15:46:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id 8Tm8EUS8oWnZOwAAD6G6ig (envelope-from ); Fri, 27 Feb 2026 15:46:12 +0000 Message-ID: <9a013265-6107-4727-987c-c562418382ea@suse.de> Date: Fri, 27 Feb 2026 16:46:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] Compute register name once in default_print_one_register_info To: Tom Tromey , gdb-patches@sourceware.org References: <20260227143344.333820-1-tromey@adacore.com> Content-Language: en-US From: Tom de Vries In-Reply-To: <20260227143344.333820-1-tromey@adacore.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-4.30 / 50.00]; BAYES_HAM(-3.00)[99.99%]; NEURAL_HAM_LONG(-1.00)[-1.000]; NEURAL_HAM_SHORT(-0.20)[-1.000]; MIME_GOOD(-0.10)[text/plain]; RCVD_VIA_SMTP_AUTH(0.00)[]; FUZZY_RATELIMITED(0.00)[rspamd.com]; ARC_NA(0.00)[]; MIME_TRACE(0.00)[0:+]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_TLS_ALL(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; FROM_EQ_ENVFROM(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; RCVD_COUNT_TWO(0.00)[2]; DBL_BLOCKED_OPENRESOLVER(0.00)[imap1.dmz-prg2.suse.org:helo] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2/27/26 3:33 PM, Tom Tromey wrote: > PR gdb/9884 points out that default_print_one_register_info could call > gdbarch_register_name a single time. The current code seems harmless > but OTOH the proposed change is also harmless and perhaps slightly > faster, so why not. > LGTM, obvious even. Approved-By: Tom de Vries Thanks, - Tom > Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=9884 > --- > gdb/infcmd.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/gdb/infcmd.c b/gdb/infcmd.c > index 319d17d95eb..d0d1c142041 100644 > --- a/gdb/infcmd.c > +++ b/gdb/infcmd.c > @@ -2505,11 +2505,12 @@ default_print_registers_info (struct gdbarch *gdbarch, > > /* If the register name is empty, it is undefined for this > processor, so don't display anything. */ > - if (*(gdbarch_register_name (gdbarch, i)) == '\0') > + const char *regname = gdbarch_register_name (gdbarch, i); > + if (*regname == '\0') > continue; > > default_print_one_register_info > - (file, gdbarch_register_name (gdbarch, i), > + (file, regname, > value_of_register (i, get_next_frame_sentinel_okay (frame))); > } > } > > base-commit: e302db71359c85e3c1f1eb90e8f0aaa06ee81752