From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125350 invoked by alias); 20 Mar 2019 10:36:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 124812 invoked by uid 89); 20 Mar 2019 10:36:30 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-24.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,MIME_BASE64_BLANKS,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.1 spammy=am, 2025 X-HELO: EUR03-AM5-obe.outbound.protection.outlook.com Received: from mail-eopbgr30070.outbound.protection.outlook.com (HELO EUR03-AM5-obe.outbound.protection.outlook.com) (40.107.3.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Mar 2019 10:36:27 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector1-arm-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=6cUP6mCE1h4PBBzwjYCAiBTaiP+eCWo82yXg3r57kgM=; b=Ldua+uyqmwD3aHbdAvlRz3gOdiyusgfRI4JVQE4zvN4lTsVLTt1ycdGMIDWsz7LShRawtTyQPT/btkpgPYpuQnq39t9z9kMMwqBNgLJQ8EtKgb1PVyn0utEdCk4dZRAs+GWNIs55UKcDnF+O61JhmJ4ABeD2N1/iQbJvRMG3z0c= Received: from AM4PR0802MB2129.eurprd08.prod.outlook.com (10.172.216.148) by AM4PR0802MB2180.eurprd08.prod.outlook.com (10.172.217.18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.1730.15; Wed, 20 Mar 2019 10:36:24 +0000 Received: from AM4PR0802MB2129.eurprd08.prod.outlook.com ([fe80::39ee:53d8:6053:d3fe]) by AM4PR0802MB2129.eurprd08.prod.outlook.com ([fe80::39ee:53d8:6053:d3fe%10]) with mapi id 15.20.1709.015; Wed, 20 Mar 2019 10:36:24 +0000 From: Alan Hayward To: Simon Marchi CC: "gdb-patches@sourceware.org" , nd Subject: Re: [PATCH] Testsuite: Ensure pie is disabled on some tests Date: Wed, 20 Mar 2019 10:36:00 -0000 Message-ID: <9F1CA01C-32AB-420F-9A4D-751D27264209@arm.com> References: <20190306102006.99150-1-alan.hayward@arm.com> <696945e9-4942-5285-0bb4-0bf899606f0a@simark.ca> <260313A3-D685-4306-8DE1-080D51BAE0BE@arm.com> In-Reply-To: authentication-results: spf=none (sender IP is ) smtp.mailfrom=Alan.Hayward@arm.com; received-spf: None (protection.outlook.com: arm.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 Content-Type: text/plain; charset="utf-8" Content-ID: Content-Transfer-Encoding: base64 MIME-Version: 1.0 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-IsSubscribed: yes X-SW-Source: 2019-03/txt/msg00426.txt.bz2 DQoNCj4gT24gMTkgTWFyIDIwMTksIGF0IDE2OjM2LCBQZWRybyBBbHZlcyA8 cGFsdmVzQHJlZGhhdC5jb20+IHdyb3RlOg0KPiANCj4gT24gMDMvMTkvMjAx OSAwMzo0NSBQTSwgQWxhbiBIYXl3YXJkIHdyb3RlOg0KPj4gKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAjIFJlY2VudCBEZWJpYW4vVWJ1bnR1 IGRlZmF1bHRzIHRvIFBJRSBlbmFibGVkLiBFbnN1cmUgaXQgaXMgZGlzYWJs ZWQuDQo+PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxhcHBl bmQgb3B0cyB7bm9waWV9DQo+IA0KPiBQbGVhc2UgZG9uJ3Qgd3JpdGUgIlJl Y2VudCIsICJOZXciLCBldGMuICBJbWFnaW5lIGl0J3MgMjAyNSBhbmQgeW91 J3JlDQo+IHJlYWRpbmcgdGhpcyBjb21tZW50LiAgV2hhdCB3b3VsZCAiUmVj ZW50IiBtZWFuIHRoZW4/ICBTcGVsbCBvdXQgc29tZQ0KPiB2ZXJzaW9uIG51 bWJlciB3aGVyZSB5b3Ugb2JzZXJ2ZWQgdGhpcyBpbnN0ZWFkLg0KPiANCj4g VGhhbmtzLA0KPiBQZWRybyBBbHZlcw0KDQpGYWlyIGVub3VnaC4gVXBkYXRl ZCB3aXRoIFVidW50dTE2LjEwIGFuZCBEZWJpYW45Lg0KDQoNCj4gT24gMTkg TWFyIDIwMTksIGF0IDE2OjA3LCBTaW1vbiBNYXJjaGkgPHNpbWFya0BzaW1h cmsuY2E+IHdyb3RlOg0KPiANCj4gT24gMjAxOS0wMy0xOSAxMTo0NSBhLm0u LCBBbGFuIEhheXdhcmQgd3JvdGU6DQo+Pj4gT24gMTkgTWFyIDIwMTksIGF0 IDEzOjQ3LCBTaW1vbiBNYXJjaGkgPHNpbWFya0BzaW1hcmsuY2E+IHdyb3Rl Og0KPj4+IA0KPj4+IE9uIDIwMTktMDMtMDYgNToyMCBhLm0uLCBBbGFuIEhh eXdhcmQgd3JvdGU6DQo+Pj4+IFJlY2VudCB2ZXJzaW9ucyBvZiBVYnVudHUg YW5kIERlYmlhbiBkZWZhdWx0IEdDQyB0byBlbmFibGUgcGllLg0KPj4+PiBJ biBkdW1wLmV4cCwgcGllIHdpbGwgY2F1c2VzIGFkZHJlc3NlcyB0byBiZSBv dXQgb2YgcmFuZ2UgZm9yIElIRVguDQo+Pj4+IEluIGJyZWFrLWludGVycC5l eHAsIHBpZSBpcyBleHBsaWNpdGx5IHNldCBmb3Igc29tZSB0ZXN0cyBhbmQg YXNzdW1lZA0KPj4+PiB0byBiZSBkaXNhYmxlZCBmb3IgdGhlIHJlbWFpbmRl ci4NCj4+Pj4gRW5zdXJlIHBpZSBpcyBkaXNhYmxlZCBmb3IgdGhlc2UgdGVz dHMgd2hlbiByZXF1aXJlZC4NCj4+Pj4gZ2RiL3Rlc3RzdWl0ZS9DaGFuZ2VM b2c6DQo+Pj4+IDIwMTktMDMtMDYgIEFsYW4gSGF5d2FyZCAgPGFsYW4uaGF5 d2FyZEBhcm0uY29tPg0KPj4+PiAJKiBnZGIuYmFzZS9icmVhay1pbnRlcnAu ZXhwOiBFbnN1cmUgcGllIGlzIGRpc2FibGVkLg0KPj4+PiAJKiBnZGIuYmFz ZS9kdW1wLmV4cDogTGlrZXdpc2UuDQo+Pj4gDQo+Pj4gSGkgQWxhbiwNCj4+ PiANCj4+PiBUaGUgIm5vcGllIiBmbGFnIHRvIGdkYl9jb21waWxlIGhhcyBi ZWVuIGludHJvZHVjZWQgcmVjZW50bHkgZm9yIHRoaXMsIGNvdWxkIHlvdSB1 c2UgdGhhdCBpbnN0ZWFkPyAgU2VlIGNvbW1pdCA2ZThiMWFiMmZkNGMgKCJG aXggdmFyaW91cyB0ZXN0cyB0byB1c2UgLW5vLXBpZSBsaW5rZXIgZmxhZyB3 aGVuIG5lZWRlZOKAnSkuDQo+PiBBaGEhIFRoYXTigJlzIGV4YWN0bHkgd2hh dCBJIG5lZWRlZC4NCj4+IEluIG15IG1pbmQsIHdlIHNob3VsZCBoYXZlIGEg 4oCccGll4oCdIGZsYWcgdG9vLiBJ4oCZbGwgYWRkIHRoaXMgaW4gdG9vLg0K PiANCj4gR29vZCBpZGVhLg0KPiANCj4+IFVwZGF0ZWQuIEkgd291bGQgaGF2 ZSBwdXNoZWQgdGhpcyBuZXcgdmVyc2lvbiAtIGJ1dCAtIEnigJltIGEgbGl0 dGxlIHVuc3VyZSBhYm91dCBhZGRpbmcgdGhlIGFkZGl0aW9uYWwgYm9hcmQg ZmxhZ3MuDQo+PiBQaWUgb3B0aW9uIGFkZHMgYm90aCBmbGFnIGFuZCBsZGZs YWcgdmVyc2lvbnMgdG8gbWFrZSBzdXJlIGl0IGdldHMgdGhlIGNhc2VzIHdo ZXJlIHdl4oCZcmUganVzdCBjb21waWxpbmcgdG8gb2JqZWN0cy4NCj4gDQo+ IFJpZ2h0LCBpZiB3ZSBhcmUgbG9va2luZyB0byBlbmFibGUgcGllICh2ZXJz dXMgZGlzYWJsaW5nIGl0KSwgd2UgbmVlZCBib3RoLg0KPiANCj4+IFRoaXMg dmVyc2lvbiBvaz8NCj4+ICAgICAyMDE5LTAzLTE5ICBBbGFuIEhheXdhcmQg IDxhbGFuLmhheXdhcmRAYXJtLmNvbT4NCj4+ICAgICAgICAgICAgICogUkVB RE1FOiBBZGQgcGllIG9wdGlvbnMuDQo+PiAgICAgICAgICAgICAqIGdkYi5i YXNlL2JyZWFrLWludGVycC5leHA6IEVuc3VyZSBwaWUgaXMgZGlzYWJsZWQu DQo+PiAgICAgICAgICAgICAqIGdkYi5iYXNlL2R1bXAuZXhwOiBMaWtld2lz ZS4NCj4+ICAgICAgICAgICAgICogbGliL2dkYi5leHAgKGdkYl9jb21waWxl KTogQWRkIHBpZSBvcHRpb24uDQo+PiBkaWZmIC0tZ2l0IGEvZ2RiL3Rlc3Rz dWl0ZS9SRUFETUUgYi9nZGIvdGVzdHN1aXRlL1JFQURNRQ0KPj4gaW5kZXgg YjVlNzViOWE3OS4uMjUzODFjZGYwNCAxMDA2NDQNCj4+IC0tLSBhL2dkYi90 ZXN0c3VpdGUvUkVBRE1FDQo+PiArKysgYi9nZGIvdGVzdHN1aXRlL1JFQURN RQ0KPj4gQEAgLTQ4Miw2ICs0ODIsMTYgQEAgZ2RiLG5vX3RocmVhZF9uYW1l cw0KPj4gICAgVGhlIHRhcmdldCBkb2Vzbid0IHN1cHBvcnQgdGhyZWFkIG5h bWVzLg0KPj4gK2dkYixwaWVfZmxhZw0KPj4gKw0KPj4gKyAgVGhlIGZsYWcg cmVxdWlyZWQgdG8gZm9yY2UgdGhlIGNvbXBpbGVyIHRvIHByb2R1Y2UgcG9z aXRpb24taW5kZXBlbmRlbnQNCj4+ICsgIGV4ZWN1dGFibGVzLg0KPj4gKw0K Pj4gK2dkYixsZHBpZV9mbGFnDQo+PiArDQo+PiArICBUaGUgZmxhZyByZXF1 aXJlZCB0byBmb3JjZSB0aGUgbGlua2VyIHRvIHByb2R1Y2UgcG9zaXRpb24t aW5kZXBlbmRlbnQNCj4+ICsgIGV4ZWN1dGFibGVzLg0KPj4gKw0KPiANCj4g InBpZV9sZGZsYWciIHNvdW5kcyBtb3JlIG5hdHVyYWwgdG8gbWUgdGhhbiAi bGRwaWVfZmxhZyIsIHVubGVzcyB5b3UgY2hvc2UgdGhpcyBuYW1lIHRvIGJl IGNvbnNpc3RlbnQgd2l0aCBvdGhlciBleGlzdGluZyBvcHRpb25zPw0KDQpT d2l0Y2hlZC4NCg0KPiANCj4+ICBnZGIsbm9waWVfZmxhZw0KPj4gICAgVGhl IGZsYWcgcmVxdWlyZWQgdG8gZm9yY2UgdGhlIGNvbXBpbGVyIHRvIHByb2R1 Y2Ugbm9uLXBvc2l0aW9uLWluZGVwZW5kZW50DQo+PiBkaWZmIC0tZ2l0IGEv Z2RiL3Rlc3RzdWl0ZS9nZGIuYmFzZS9icmVhay1pbnRlcnAuZXhwIGIvZ2Ri L3Rlc3RzdWl0ZS9nZGIuYmFzZS9icmVhay1pbnRlcnAuZXhwDQo+PiBpbmRl eCBmODVlOGE2NTBhLi44YmI4NTNjMDQxIDEwMDY0NA0KPj4gLS0tIGEvZ2Ri L3Rlc3RzdWl0ZS9nZGIuYmFzZS9icmVhay1pbnRlcnAuZXhwDQo+PiArKysg Yi9nZGIvdGVzdHN1aXRlL2dkYi5iYXNlL2JyZWFrLWludGVycC5leHANCj4+ IEBAIC02MjUsOCArNjI1LDEwIEBAIGZvcmVhY2ggbGRwcmVsaW5rIHtOTyBZ RVN9IHsNCj4+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgbGFw cGVuZCBvcHRzIHtkZWJ1Z30NCj4+ICAgICAgICAgICAgICAgICAgICAgICAg ICAgICB9DQo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgaWYgeyRi aW5waWUgIT0gIk5PIn0gew0KPj4gLSAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBsYXBwZW5kIG9wdHMge2FkZGl0aW9uYWxfZmxhZ3M9LWZQSUV9 DQo+PiAtICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxhcHBlbmQg b3B0cyB7bGRmbGFncz0tcGllfQ0KPj4gKyAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBsYXBwZW5kIG9wdHMge3BpZX0NCj4+ICsgICAgICAgICAg ICAgICAgICAgICAgICAgICB9IGVsc2Ugew0KPj4gKyAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAjIFJlY2VudCBEZWJpYW4vVWJ1bnR1IGRlZmF1 bHRzIHRvIFBJRSBlbmFibGVkLiBFbnN1cmUgaXQgaXMgZGlzYWJsZWQuDQo+ PiArICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGxhcHBlbmQgb3B0 cyB7bm9waWV9DQo+PiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfQ0K Pj4gICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNldCBkaXIgJHtleGVj fS5kDQo+PiBkaWZmIC0tZ2l0IGEvZ2RiL3Rlc3RzdWl0ZS9nZGIuYmFzZS9k dW1wLmV4cCBiL2dkYi90ZXN0c3VpdGUvZ2RiLmJhc2UvZHVtcC5leHANCj4+ IGluZGV4IDQ0YjA5ODhiODAuLjU2ZGNhZmQ0Y2IgMTAwNjQ0DQo+PiAtLS0g YS9nZGIvdGVzdHN1aXRlL2dkYi5iYXNlL2R1bXAuZXhwDQo+PiArKysgYi9n ZGIvdGVzdHN1aXRlL2dkYi5iYXNlL2R1bXAuZXhwDQo+PiBAQCAtMzYsNiAr MzYsMTAgQEAgaWYge1tpc3RhcmdldCAic3B1Ki0qLSoiXX0gdGhlbiB7DQo+ PiAgICAgIHNldCBpczY0Yml0b25seSAieWVzIg0KPj4gIH0NCj4+ICsjIFJl Y2VudCBEZWJpYW4vVWJ1bnR1IGRlZmF1bHRzIHRvIFBJRSBlbmFibGVkLiBF bnN1cmUgaXQgaXMgZGlzYWJsZWQgYXMgdGhpcw0KPj4gKyMgY2F1c2VzIGFk ZHJlc3NlcyB0byBiZSBvdXQgb2YgcmFuZ2UgZm9yIElIRVguDQo+PiArbGFw cGVuZCBvcHRpb25zIHtub3BpZX0NCj4+ICsNCj4+ICBpZiAgeyBbZ2RiX2Nv bXBpbGUgIiR7c3JjZGlyfS8ke3N1YmRpcn0vJHtzcmNmaWxlfSIgIiR7Ymlu ZmlsZX0iIGV4ZWN1dGFibGUgJHtvcHRpb25zfV0gIT0gIiIgfSB7DQo+PiAg ICAgICB1bnRlc3RlZCAiZmFpbGVkIHRvIGNvbXBpbGUiDQo+PiAgICAgICBy ZXR1cm4gLTENCj4+IGRpZmYgLS1naXQgYS9nZGIvdGVzdHN1aXRlL2xpYi9n ZGIuZXhwIGIvZ2RiL3Rlc3RzdWl0ZS9saWIvZ2RiLmV4cA0KPj4gaW5kZXgg ZjEzZjkwOWMzNC4uMjU5ODY1ZjVmZCAxMDA2NDQNCj4+IC0tLSBhL2dkYi90 ZXN0c3VpdGUvbGliL2dkYi5leHANCj4+ICsrKyBiL2dkYi90ZXN0c3VpdGUv bGliL2dkYi5leHANCj4+IEBAIC0zNDYxLDYgKzM0NjEsNyBAQCBzZXQgZ2Ri X3NhdmVkX3NldF91bmJ1ZmZlcmVkX21vZGVfb2JqICIiDQo+PiAgIyAgICAg ZHluYW1pY2FsbHkgbG9hZCBsaWJyYXJpZXMgYXQgcnVudGltZS4gIEZvciBl eGFtcGxlLCBvbiBMaW51eCwgdGhpcyBhZGRzDQo+PiAgIyAgICAgLWxkbCBz byB0aGF0IHRoZSB0ZXN0IGNhbiB1c2UgZGxvcGVuLg0KPj4gICMgICAtIG5v d2FybmluZ3M6ICBJbmhpYml0IGFsbCBjb21waWxlciB3YXJuaW5ncy4NCj4+ ICsjICAgLSBwaWU6IEZvcmNlIGNyZWF0aW9uIG9mIFBJRSBleGVjdXRhYmxl cy4NCj4+ICAjICAgLSBub3BpZTogUHJldmVudCBjcmVhdGlvbiBvZiBQSUUg ZXhlY3V0YWJsZXMuDQo+PiAgIw0KPj4gICMgQW5kIGhlcmUgYXJlIHNvbWUg b2YgdGhlIG5vdCB0b28gb2JzY3VyZSBvcHRpb25zIHVuZGVyc3Rvb2QgYnkg RGVqYUdudSB0aGF0DQo+PiBAQCAtMzU5OSw4ICszNjAwLDI3IEBAIHByb2Mg Z2RiX2NvbXBpbGUge3NvdXJjZSBkZXN0IHR5cGUgb3B0aW9uc30gew0KPj4g ICAgICAgICBzZXQgb3B0aW9ucyBbbHJlcGxhY2UgJG9wdGlvbnMgJG5vd2Fy bmluZ3MgJG5vd2FybmluZ3MgJGZsYWddDQo+PiAgICAgIH0NCj4+IC0gICAg IyBSZXBsYWNlIHRoZSAibm9waWUiIG9wdGlvbiB3aXRoIHRoZSBhcHByb3By aWF0ZSBhZGRpdGlvbmFsX2ZsYWdzDQo+PiAtICAgICMgdG8gZGlzYWJsZSBQ SUUgZXhlY3V0YWJsZXMuDQo+PiArICAgICMgUmVwbGFjZSB0aGUgInBpZSIg b3B0aW9uIHdpdGggdGhlIGFwcHJvcHJpYXRlIGZsYWdzIHRvIGVuYWJsZSBQ SUUNCj4+ICsgICAgIyBleGVjdXRhYmxlcy4NCj4+ICsgICAgc2V0IHBpZSBb bHNlYXJjaCAtZXhhY3QgJG9wdGlvbnMgcGllXQ0KPj4gKyAgICBpZiB7JHBp ZSAhPSAtMX0gew0KPj4gKyAgICAgICBpZiBbdGFyZ2V0X2luZm8gZXhpc3Rz IGdkYixwaWVfZmxhZ10gew0KPj4gKyAgICAgICAgICAgc2V0IGZsYWcgImFk ZGl0aW9uYWxfZmxhZ3M9W3RhcmdldF9pbmZvIGdkYixwaWVfZmxhZ10iDQo+ PiArICAgICAgIH0gZWxzZSB7DQo+PiArICAgICAgICAgICBzZXQgZmxhZyAi YWRkaXRpb25hbF9mbGFncz0tZnBpZSINCj4gDQo+IEkga25vdyB0aGVyZSdz IGEgZGlmZmVyZW5jZSBiZXR3ZWVuIC1mcGllIGFuZCAtZlBJRSwgYnV0IEkg ZG9uJ3QgcmVhbGx5IHRoYXQgd2hhdCBpdCBpcyBhYm91dC4gIERpZCB5b3Ug Y2hvb3NlIC1mcGllIG9uIHB1cnBvc2U/ICBTaW5jZSBpdCBtYXR0ZXJzIG9u IEFBcmNoNjQsIGFtb25nIG90aGVycywgbWF5YmUgeW91IGtub3cgdGhlIGRp ZmZlcmVuY2U/DQo+IA0KDQpJIGhhZG7igJl0IGNob3NlbiAtZnBpZSBvbiBw dXJwb3NlLiBJ4oCZdmUgcmVhZCBpbnRvIHRoaXMgYSBiaXQgbW9yZSBub3cg LSBpdOKAmXMgYW4gYXdrd2FyZCBzZXQgb2YgZmxhZ3MuDQpmUElFIGlzIHRo ZSBzYWZlciBvcHRpb24gYW5kIGl04oCZcyB3aGF0IFVidW50dS9EZWJpYW4g ZGVmYXVsdCB0by4NClVwZGF0ZWQgdGhlIHBhdGNoIHdpdGggUElFIGFuZCBh ZGRlZCBzb21lIGV4cGxhbmF0aW9ucyBhcyB0byB3aHkuDQoNCldpbGwgcHVz aCBpZiB0aGVyZSBhcmUgbm8gZnVydGhlciBjb21tZW50cy4NCg0KDQoNCmRp ZmYgLS1naXQgYS9nZGIvdGVzdHN1aXRlL1JFQURNRSBiL2dkYi90ZXN0c3Vp dGUvUkVBRE1FDQppbmRleCBiNWU3NWI5YTc5Li5kYjkwZWE0Njk4IDEwMDY0 NA0KLS0tIGEvZ2RiL3Rlc3RzdWl0ZS9SRUFETUUNCisrKyBiL2dkYi90ZXN0 c3VpdGUvUkVBRE1FDQpAQCAtNDgyLDYgKzQ4MiwxNiBAQCBnZGIsbm9fdGhy ZWFkX25hbWVzDQoNCiAgIFRoZSB0YXJnZXQgZG9lc24ndCBzdXBwb3J0IHRo cmVhZCBuYW1lcy4NCg0KK2dkYixwaWVfZmxhZw0KKw0KKyAgVGhlIGZsYWcg cmVxdWlyZWQgdG8gZm9yY2UgdGhlIGNvbXBpbGVyIHRvIHByb2R1Y2UgcG9z aXRpb24taW5kZXBlbmRlbnQNCisgIGV4ZWN1dGFibGVzLg0KKw0KK2dkYixw aWVfbGRmbGFnDQorDQorICBUaGUgZmxhZyByZXF1aXJlZCB0byBmb3JjZSB0 aGUgbGlua2VyIHRvIHByb2R1Y2UgcG9zaXRpb24taW5kZXBlbmRlbnQNCisg IGV4ZWN1dGFibGVzLg0KKw0KIGdkYixub3BpZV9mbGFnDQoNCiAgIFRoZSBm bGFnIHJlcXVpcmVkIHRvIGZvcmNlIHRoZSBjb21waWxlciB0byBwcm9kdWNl IG5vbi1wb3NpdGlvbi1pbmRlcGVuZGVudA0KZGlmZiAtLWdpdCBhL2dkYi90 ZXN0c3VpdGUvZ2RiLmJhc2UvYnJlYWstaW50ZXJwLmV4cCBiL2dkYi90ZXN0 c3VpdGUvZ2RiLmJhc2UvYnJlYWstaW50ZXJwLmV4cA0KaW5kZXggZjg1ZThh NjUwYS4uNTFlMzFmNjUwMyAxMDA2NDQNCi0tLSBhL2dkYi90ZXN0c3VpdGUv Z2RiLmJhc2UvYnJlYWstaW50ZXJwLmV4cA0KKysrIGIvZ2RiL3Rlc3RzdWl0 ZS9nZGIuYmFzZS9icmVhay1pbnRlcnAuZXhwDQpAQCAtNjI1LDggKzYyNSwx MCBAQCBmb3JlYWNoIGxkcHJlbGluayB7Tk8gWUVTfSB7DQogICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIGxhcHBlbmQgb3B0cyB7ZGVidWd9DQog ICAgICAgICAgICAgICAgICAgICAgICAgICAgfQ0KICAgICAgICAgICAgICAg ICAgICAgICAgICAgIGlmIHskYmlucGllICE9ICJOTyJ9IHsNCi0gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgbGFwcGVuZCBvcHRzIHthZGRpdGlv bmFsX2ZsYWdzPS1mUElFfQ0KLSAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICBsYXBwZW5kIG9wdHMge2xkZmxhZ3M9LXBpZX0NCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgbGFwcGVuZCBvcHRzIHtwaWV9DQorICAg ICAgICAgICAgICAgICAgICAgICAgICAgfSBlbHNlIHsNCisgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIyBEZWJpYW45L1VidW50dTE2LjEwIG9u d2FyZHMgZGVmYXVsdCB0byBQSUUgZW5hYmxlZC4gRW5zdXJlIGl0IGlzIGRp c2FibGVkLg0KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBsYXBw ZW5kIG9wdHMge25vcGllfQ0KICAgICAgICAgICAgICAgICAgICAgICAgICAg IH0NCg0KICAgICAgICAgICAgICAgICAgICAgICAgICAgIHNldCBkaXIgJHtl eGVjfS5kDQpkaWZmIC0tZ2l0IGEvZ2RiL3Rlc3RzdWl0ZS9nZGIuYmFzZS9k dW1wLmV4cCBiL2dkYi90ZXN0c3VpdGUvZ2RiLmJhc2UvZHVtcC5leHANCmlu ZGV4IDQ0YjA5ODhiODAuLjUyYmE1ZjhlYmUgMTAwNjQ0DQotLS0gYS9nZGIv dGVzdHN1aXRlL2dkYi5iYXNlL2R1bXAuZXhwDQorKysgYi9nZGIvdGVzdHN1 aXRlL2dkYi5iYXNlL2R1bXAuZXhwDQpAQCAtMzYsNiArMzYsMTAgQEAgaWYg e1tpc3RhcmdldCAic3B1Ki0qLSoiXX0gdGhlbiB7DQogICAgIHNldCBpczY0 Yml0b25seSAieWVzIg0KIH0NCg0KKyMgRGViaWFuOS9VYnVudHUxNi4xMCBv bndhcmRzIGRlZmF1bHQgdG8gUElFIGVuYWJsZWQuIEVuc3VyZSBpdCBpcyBk aXNhYmxlZCBhcw0KKyMgdGhpcyBjYXVzZXMgYWRkcmVzc2VzIHRvIGJlIG91 dCBvZiByYW5nZSBmb3IgSUhFWC4NCitsYXBwZW5kIG9wdGlvbnMge25vcGll fQ0KKw0KIGlmICB7IFtnZGJfY29tcGlsZSAiJHtzcmNkaXJ9LyR7c3ViZGly fS8ke3NyY2ZpbGV9IiAiJHtiaW5maWxlfSIgZXhlY3V0YWJsZSAke29wdGlv bnN9XSAhPSAiIiB9IHsNCiAgICAgIHVudGVzdGVkICJmYWlsZWQgdG8gY29t cGlsZSINCiAgICAgIHJldHVybiAtMQ0KZGlmZiAtLWdpdCBhL2dkYi90ZXN0 c3VpdGUvbGliL2dkYi5leHAgYi9nZGIvdGVzdHN1aXRlL2xpYi9nZGIuZXhw DQppbmRleCBmMTNmOTA5YzM0Li42ODAwYzc0MTg3IDEwMDY0NA0KLS0tIGEv Z2RiL3Rlc3RzdWl0ZS9saWIvZ2RiLmV4cA0KKysrIGIvZ2RiL3Rlc3RzdWl0 ZS9saWIvZ2RiLmV4cA0KQEAgLTM0NjEsNiArMzQ2MSw3IEBAIHNldCBnZGJf c2F2ZWRfc2V0X3VuYnVmZmVyZWRfbW9kZV9vYmogIiINCiAjICAgICBkeW5h bWljYWxseSBsb2FkIGxpYnJhcmllcyBhdCBydW50aW1lLiAgRm9yIGV4YW1w bGUsIG9uIExpbnV4LCB0aGlzIGFkZHMNCiAjICAgICAtbGRsIHNvIHRoYXQg dGhlIHRlc3QgY2FuIHVzZSBkbG9wZW4uDQogIyAgIC0gbm93YXJuaW5nczog IEluaGliaXQgYWxsIGNvbXBpbGVyIHdhcm5pbmdzLg0KKyMgICAtIHBpZTog Rm9yY2UgY3JlYXRpb24gb2YgUElFIGV4ZWN1dGFibGVzLg0KICMgICAtIG5v cGllOiBQcmV2ZW50IGNyZWF0aW9uIG9mIFBJRSBleGVjdXRhYmxlcy4NCiAj DQogIyBBbmQgaGVyZSBhcmUgc29tZSBvZiB0aGUgbm90IHRvbyBvYnNjdXJl IG9wdGlvbnMgdW5kZXJzdG9vZCBieSBEZWphR251IHRoYXQNCkBAIC0zNTk5 LDggKzM2MDAsMzMgQEAgcHJvYyBnZGJfY29tcGlsZSB7c291cmNlIGRlc3Qg dHlwZSBvcHRpb25zfSB7DQogICAgICAgIHNldCBvcHRpb25zIFtscmVwbGFj ZSAkb3B0aW9ucyAkbm93YXJuaW5ncyAkbm93YXJuaW5ncyAkZmxhZ10NCiAg ICAgfQ0KDQotICAgICMgUmVwbGFjZSB0aGUgIm5vcGllIiBvcHRpb24gd2l0 aCB0aGUgYXBwcm9wcmlhdGUgYWRkaXRpb25hbF9mbGFncw0KLSAgICAjIHRv IGRpc2FibGUgUElFIGV4ZWN1dGFibGVzLg0KKyAgICAjIFJlcGxhY2UgdGhl ICJwaWUiIG9wdGlvbiB3aXRoIHRoZSBhcHByb3ByaWF0ZSBjb21waWxlciBh bmQgbGlua2VyIGZsYWdzDQorICAgICMgdG8gZW5hYmxlIFBJRSBleGVjdXRh Ymxlcy4NCisgICAgc2V0IHBpZSBbbHNlYXJjaCAtZXhhY3QgJG9wdGlvbnMg cGllXQ0KKyAgICBpZiB7JHBpZSAhPSAtMX0gew0KKyAgICAgICBpZiBbdGFy Z2V0X2luZm8gZXhpc3RzIGdkYixwaWVfZmxhZ10gew0KKyAgICAgICAgICAg c2V0IGZsYWcgImFkZGl0aW9uYWxfZmxhZ3M9W3RhcmdldF9pbmZvIGdkYixw aWVfZmxhZ10iDQorICAgICAgIH0gZWxzZSB7DQorICAgICAgICAgICAjIEZv ciBzYWZldHksIHVzZSBmUElFIHJhdGhlciB0aGFuIGZwaWUuIE9uIEFBcmNo NjQsIG02OGssIFBvd2VyUEMNCisgICAgICAgICAgICMgYW5kIFNQQVJDLCBm cGllIGNhbiBjYXVzZSBjb21waWxlIGVycm9ycyBkdWUgdG8gdGhlIEdPVCBl eGNlZWRpbmcNCisgICAgICAgICAgICMgYSBtYXhpbXVtIHNpemUuICBPbiBv dGhlciBhcmNoaXRlY3R1cmVzIHRoZSB0d28gZmxhZ3MgYXJlDQorICAgICAg ICAgICAjIGlkZW50aWNhbCAoc2VlIHRoZSBHQ0MgbWFudWFsKS4gTm90ZSBE ZWJpYW45IGFuZCBVYnVudHUxNi4xMA0KKyAgICAgICAgICAgIyBvbndhcmRz IGRlZmF1bHQgR0NDIHRvIHVzaW5nIGZQSUUuICBJZiB5b3UgZG8gcmVxdWly ZSBmcGllLCB0aGVuDQorICAgICAgICAgICAjIGl0IGNhbiBiZSBzZXQgdXNp bmcgdGhlIHBpZV9mbGFnLg0KKyAgICAgICAgICAgc2V0IGZsYWcgImFkZGl0 aW9uYWxfZmxhZ3M9LWZQSUUiDQorICAgICAgIH0NCisgICAgICAgc2V0IG9w dGlvbnMgW2xyZXBsYWNlICRvcHRpb25zICRwaWUgJHBpZSAkZmxhZ10NCisN CisgICAgICAgaWYgW3RhcmdldF9pbmZvIGV4aXN0cyBnZGIscGllX2xkZmxh Z10gew0KKyAgICAgICAgICAgc2V0IGZsYWcgImxkZmxhZ3M9W3RhcmdldF9p bmZvIGdkYixwaWVfbGRmbGFnXSINCisgICAgICAgfSBlbHNlIHsNCisgICAg ICAgICAgIHNldCBmbGFnICJsZGZsYWdzPS1waWUiDQorICAgICAgIH0NCisg ICAgICAgbGFwcGVuZCBvcHRpb25zICIkZmxhZyINCisgICAgfQ0KKw0KKyAg ICAjIFJlcGxhY2UgdGhlICJub3BpZSIgb3B0aW9uIHdpdGggdGhlIGFwcHJv cHJpYXRlIGxpbmtlciBmbGFnIHRvIGRpc2FibGUNCisgICAgIyBQSUUgZXhl Y3V0YWJsZXMuICBUaGVyZSBhcmUgbm8gY29tcGlsZXIgZmxhZ3MgZm9yIHRo aXMgb3B0aW9uLg0KICAgICBzZXQgbm9waWUgW2xzZWFyY2ggLWV4YWN0ICRv cHRpb25zIG5vcGllXQ0KICAgICBpZiB7JG5vcGllICE9IC0xfSB7DQogICAg ICAgIGlmIFt0YXJnZXRfaW5mbyBleGlzdHMgZ2RiLG5vcGllX2ZsYWddIHs= >From gdb-patches-return-154739-listarch-gdb-patches=sources.redhat.com@sourceware.org Wed Mar 20 14:08:53 2019 Return-Path: Delivered-To: listarch-gdb-patches@sources.redhat.com Received: (qmail 40604 invoked by alias); 20 Mar 2019 14:08:53 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Delivered-To: mailing list gdb-patches@sourceware.org Received: (qmail 40596 invoked by uid 89); 20 Mar 2019 14:08:53 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-20.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.1 spammy=ecs, HX-Languages-Length:1999, HContent-Transfer-Encoding:8bit X-HELO: rock.gnat.com Received: from rock.gnat.com (HELO rock.gnat.com) (205.232.38.15) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Mar 2019 14:08:52 +0000 Received: from localhost (localhost.localdomain [127.0.0.1]) by filtered-rock.gnat.com (Postfix) with ESMTP id 66D6F560C2; Wed, 20 Mar 2019 10:08:50 -0400 (EDT) Received: from rock.gnat.com ([127.0.0.1]) by localhost (rock.gnat.com [127.0.0.1]) (amavisd-new, port 10024) with LMTP id pRHtlHQ0NrTZ; Wed, 20 Mar 2019 10:08:50 -0400 (EDT) Received: from murgatroyd.Home (174-29-37-56.hlrn.qwest.net [174.29.37.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by rock.gnat.com (Postfix) with ESMTPSA id 1D439560C1; Wed, 20 Mar 2019 10:08:50 -0400 (EDT) From: Tom Tromey To: gdb-patches@sourceware.org Cc: Tom Tromey Subject: [PATCH] Merge handle_inferior_event and handle_inferior_event_1 Date: Wed, 20 Mar 2019 14:08:00 -0000 Message-Id: <20190320140846.13031-1-tromey@adacore.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-SW-Source: 2019-03/txt/msg00427.txt.bz2 Content-length: 2007 I noticed that handle_inferior_event is just a small wrapper that frees the value chain. This patch replaces it with a scoped_value_mark, reducing the number of lines of code here. Regression tested on x86-64 Fedora 29. gdb/ChangeLog 2019-03-20 Tom Tromey * infrun.c (handle_inferior_event): Rename from handle_inferior_event_1. Create a scoped_value_mark. (handle_inferior_event): Remove. --- gdb/ChangeLog | 6 ++++++ gdb/infrun.c | 23 ++++++----------------- 2 files changed, 12 insertions(+), 17 deletions(-) diff --git a/gdb/infrun.c b/gdb/infrun.c index 550fbe7f5b9..ad7892105a4 100644 --- a/gdb/infrun.c +++ b/gdb/infrun.c @@ -4591,8 +4591,13 @@ handle_no_resumed (struct execution_control_state *ecs) once). */ static void -handle_inferior_event_1 (struct execution_control_state *ecs) +handle_inferior_event (struct execution_control_state *ecs) { + /* Make sure that all temporary struct value objects that were + created during the handling of the event get deleted at the + end. */ + scoped_value_mark free_values; + enum stop_kind stop_soon; if (ecs->ws.kind == TARGET_WAITKIND_IGNORE) @@ -5189,22 +5194,6 @@ Cannot fill $_exitsignal with the correct signal number.\n")); } } -/* A wrapper around handle_inferior_event_1, which also makes sure - that all temporary struct value objects that were created during - the handling of the event get deleted at the end. */ - -static void -handle_inferior_event (struct execution_control_state *ecs) -{ - struct value *mark = value_mark (); - - handle_inferior_event_1 (ecs); - /* Purge all temporary values created during the event handling, - as it could be a long time before we return to the command level - where such values would otherwise be purged. */ - value_free_to_mark (mark); -} - /* Restart threads back to what they were trying to do back when we paused them for an in-line step-over. The EVENT_THREAD thread is ignored. */ -- 2.20.1