From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 75264 invoked by alias); 5 Jul 2018 19:16:48 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 75219 invoked by uid 89); 5 Jul 2018 19:16:45 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-26.9 required=5.0 tests=BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Ask X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 05 Jul 2018 19:16:44 +0000 Received: from smtp.corp.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id E9F065F73B; Thu, 5 Jul 2018 19:16:42 +0000 (UTC) Received: from theo.uglyboxes.com (ovpn04.gateway.prod.ext.phx2.redhat.com [10.5.9.4]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B430C300193F; Thu, 5 Jul 2018 19:16:42 +0000 (UTC) Subject: Re: [RFA 10/42] Move some code from buildsym to stabsread To: Tom Tromey , gdb-patches@sourceware.org References: <20180523045851.11660-1-tom@tromey.com> <20180523045851.11660-11-tom@tromey.com> From: Keith Seitz Message-ID: <99fce463-478c-de06-b2f0-081e3c18fed8@redhat.com> Date: Thu, 05 Jul 2018 19:16:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180523045851.11660-11-tom@tromey.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-07/txt/msg00127.txt.bz2 I just have one comment: On 05/22/2018 09:58 PM, Tom Tromey wrote: > diff --git a/gdb/stabsread.c b/gdb/stabsread.c > index 4cfefaa3e0..13663106dc 100644 > --- a/gdb/stabsread.c > +++ b/gdb/stabsread.c > @@ -44,6 +44,7 @@ > #include "target-float.h" > #include "cp-abi.h" > #include "cp-support.h" > +#include "bcache.h" > #include > > /* Ask stabsread.h to define the vars it normally declares `extern'. */ > @@ -4839,6 +4840,18 @@ find_name_end (const char *name) > } > } > > + > + > +/* Compute a small integer hash code for the given name. */ > + > +int > +hashname (const char *name) > +{ > + return hash (name, strlen (name)) % HASHSIZE; > +} > + > + > + > /* Initializer for this module. */ > > void Seems some superfluous newlines got pasted in here? Please use "See stabsread.h" and move the comment into the header. Okay, that's actually two comments, but one is so trivial, I didn't count it. Keith