From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112098 invoked by alias); 29 Nov 2019 17:40:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 112088 invoked by uid 89); 29 Nov 2019 17:40:07 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00 autolearn=ham version=3.3.1 spammy=benefits, bothers, effectively, portability X-HELO: us-smtp-1.mimecast.com Received: from us-smtp-delivery-1.mimecast.com (HELO us-smtp-1.mimecast.com) (207.211.31.120) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 29 Nov 2019 17:40:05 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575049204; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=J+d7cYV8VHx/CLrrLtrkdO1W4tTs41B5CLDBNbOYdWw=; b=Z5Uge43e0i8X8+U3H8h9M+kIqk2SKpPb/3IWYP8uiUf2MI4l2xOtb8VuvJFWwGwE4Vt4uv vo6RyhsguIborYa9qQ0nhy0SCFHB8ejWUmONCfiwARVAJOt7GxRx58YFpND8Qb4xG7kh6v 5n37tIlmOTpC5g2Ih7dAEpGwxJY+U8c= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-219-Tphr3rC1OfWVYKhNE_miIw-1; Fri, 29 Nov 2019 12:40:02 -0500 Received: by mail-wr1-f70.google.com with SMTP id d8so11962467wrq.12 for ; Fri, 29 Nov 2019 09:40:02 -0800 (PST) Return-Path: Received: from ?IPv6:2001:8a0:f913:f700:56ee:75ff:fe8d:232b? ([2001:8a0:f913:f700:56ee:75ff:fe8d:232b]) by smtp.gmail.com with ESMTPSA id v188sm3807236wma.10.2019.11.29.09.40.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 29 Nov 2019 09:40:00 -0800 (PST) Subject: Re: [PATCH] Simplify the IPA parts of the gdbserver Makefile To: Christian Biesinger References: <20191126191029.10514-1-cbiesinger@google.com> <1fb3d076-99d4-c8f8-8d43-a4f2aff5072f@redhat.com> Cc: gdb-patches From: Pedro Alves Message-ID: <99f2e2e4-d3ae-6066-9538-4839eed7dcea@redhat.com> Date: Fri, 29 Nov 2019 17:40:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: X-Mimecast-Spam-Score: 0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2019-11/txt/msg01134.txt.bz2 On 11/26/19 9:05 PM, Christian Biesinger wrote: > On Tue, Nov 26, 2019 at 2:56 PM Pedro Alves wrote: >> >> What bothers me is that this moves in the direction of having to >> handle portability ourselves, effectively undoing the benefits >> of gnulib. It seems to me to walk in the opposite direction of >> the ideal, which would be for the IPA to also use gnulib. >> It doesn't use gnulib today, because the IPA is a shared library, >> so we'd need to link with a build of gnulib built with -fPIC. > > Oh, is that the only reason? That seems like it should be fixable > reasonably easily, just build gdbserver's gnulib with -fPIC. And if we > move to a single Gnulib build we can just build all of it with -fPIC, > I would think, not much of a downside. I thought there may be codesize > concerns. Yeah, code size concerns went out the window when the IPA started using std::vector/std::string along with gdbserver... > >> The UNDO_GNULIB_CFLAGS stuff at least gives us normalized headers >> between gdb / gdbserver / IPA, which for simple header portability >> fixes and defines seems good enough, though not ideal, of course. > > OK, I'll update that other patch to use that. > > Do you think https://sourceware.org/ml/gdb-patches/2019-11/msg00908.html > is still worth having or should I withdraw that too? That seems still worth it for being more direct to the point / precise. Thanks, Pedro Alves