From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 061EF38930CB for ; Wed, 29 Apr 2020 15:44:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 061EF38930CB Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=simark.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca Received: from [10.0.0.193] (unknown [192.222.164.54]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 5D12C1E581; Wed, 29 Apr 2020 11:44:06 -0400 (EDT) Subject: Re: [PATCH v2] Add basic event handling in the NetBSD target To: Kamil Rytarowski Cc: gdb-patches@sourceware.org References: <20200417144508.6366-1-n54@gmx.com> <2eaea1b8-215c-c628-bedc-4b70900c18f9@simark.ca> From: Simon Marchi Message-ID: <99cd90c9-d392-6ff3-249b-958086b19978@simark.ca> Date: Wed, 29 Apr 2020 11:44:04 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: tl Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-9.8 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Apr 2020 15:44:08 -0000 On 2020-04-29 7:08 a.m., Kamil Rytarowski wrote: > Hello, > > Please review new version submitted as an attachment. > > I've applied all the requested changes and used a nonexited inferior iterator in ::resume(), whenever we receive PTID -1. > I think that makes sense. Only thing it that you should probably use `all_non_exited_inferiors (this)`, to avoid trying to resume inferiors of other targets. Simon