From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18713 invoked by alias); 31 Mar 2003 23:15:07 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18690 invoked from network); 31 Mar 2003 23:15:07 -0000 Received: from unknown (63.119.183.65) by sources.redhat.com with QMTP; 31 Mar 2003 23:15:07 -0000 Received: (qmail 30120 invoked from network); 31 Mar 2003 23:16:58 -0000 Received: from cpe-24-221-209-215.co.sprintbbd.net (HELO doc.com) (24.221.209.215) by external1 with SMTP; 31 Mar 2003 23:16:58 -0000 Date: Mon, 31 Mar 2003 23:15:00 -0000 Subject: Re: [RFA] Compile objc-lang.c, objc-exp.tab.c [1/5] Content-Type: text/plain; charset=US-ASCII; format=flowed Mime-Version: 1.0 (Apple Message framework v551) Cc: GDB Patches , Daniel Jacobowitz , Andrew Cagney To: David Carlton From: Adam Fedor In-Reply-To: Message-Id: <99FCC0F2-63CE-11D7-9F75-000A277AC1A4@doc.com> Content-Transfer-Encoding: 7bit X-SW-Source: 2003-03/txt/msg00623.txt.bz2 On Monday, March 31, 2003, at 03:53 PM, David Carlton wrote: > On Sun, 30 Mar 2003 19:23:08 -0700, Adam Fedor said: > >> Here's my crack at doing [language-specific demangling]. > > This patch bothers me: it doesn't handle Java cleanly, and I'm not > sure about the 'options' argument to language_demangle. It seems to > me that, at the very least, there should be a java_demangle function > defined that takes the options passed in, applies '| DMGL_JAVA' to it, > and calls cplus_demangle. > Sure. That makes sense. > But I also wanted to double-check: does 'options' really make sense > for all language types? If I'm reading the patch correctly, it looks > like Objective C just throws it away. If that's the case, then I > don't think that 'options' should be part of the language vector: if > C++ needs it for internal purposes, then C++ could have its own more > flexible demangler with that option (which Java could also use), but > the version in the language vector should be more restricted. > > Then I should go back to the case where if we know the language is cplus or java, then call cplus_demangle(/java_demangle), otherwise use language_demangle?