From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by sourceware.org (Postfix) with ESMTPS id 0D4373877039 for ; Tue, 17 Mar 2020 09:39:27 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1584437963; bh=Dps/zkRIS7hG00Muanp0rW8Xvd0U1OmMmiTj3faWSs8=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=NwTNng23TjEg2hrru17jZgVp1dUTc/FDgX2Nu5dSRHtLti0cGoHTccc8LG5yEXlFZ ACjSXEitffj2+X1gvgxB95OSIuLUfLV5FozJjHRSb4+Ype0m9oCG6Dd71KWF1/wbE2 CYQ/iGEoWkosfFNc5J0kyxppRmjNLDqGv9Hief68= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.79.191.25]) by mail.gmx.com (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1Mlf0U-1jeyvw0BUo-00ioJM; Tue, 17 Mar 2020 10:39:22 +0100 Subject: Re: [PATCH] Add support for NetBSD threads in sparc-nat.c To: Christian Biesinger Cc: gdb-patches References: <20200314182710.11396-1-n54@gmx.com> From: Kamil Rytarowski Autocrypt: addr=n54@gmx.com; prefer-encrypt=mutual; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCdLYW1pbCBSeXRh cm93c2tpIChOZXRCU0QpIDxuNTRAZ214LmNvbT6JAjwEEwEIACYCGyMHCwkIBwMCAQYVCAIJ CgsEFgIDAQIeAQIXgAUCVbKGFwIZAQAKCRBLswjpsC52bIVpD/9i8npieI91xMIVvAHIUMeo cQO0IrNb+b/PuTj2qNemdwU7dhVJ7tVU5O1H2hI2M4rHGzjzDTxYzdxka0+A8CVEuvFdf6sF lXlXF0wM7rC6MoaB0QLAKxkZB5OtCILxLx7Bl2Y4cTPMU9v+qSL6yrdmhxogkufa4d6O9Zl/ FCWO2kH/BphKOiDtbyvdo2WULSLWP2IXN+0rCpNL4wbTfYLgV9JtMf8f0naGsdy7BFuDWsIE vtHh8dkQZP7dz6Qy67kx8negZaehSEgXwiae0HwQIn3xTQrFmBDALDsCgXuLWPTvglSkqTak uG+8X5fyTy0cU10TNKsU+rFBO+/xsUoIQOGrARwfWOIfJNPelzh/qigSnyNQNH8u5vFRPg9n fqB/AcvvAvtOYOo8EN9Ofx11gNj397NXc5HBQTrX6k5GNAeBWE3Ng1uO6scIwAS7qGnqGezU ABmQKLN37gmJiiGwhQAnSE6HILLBC5Z2b0S2rQsPKg8WgUmPa1YIcDkDtNB/LJcDsdU4Fm+r U2ksKU7tGD2ZfBt8H2nqfPKKeB+Uv/TBigjRvx/m70vjhqVxwCZA9Fqr9vkQkZroNfqP+3dp Z5V5fjmxO5abE2+IikSvFagwMtgx56i8Yrr2BzE8P5/S4cKq1kgyQoF+lVGDKRkUKCv1i4Fo aftnSxN8jTFZDbkCDQRVcFBfARAAutbzb8wAHGL5FPPWKErQ3Bsrp9RDTVqRzp7kBMOtd/14 MrOsWWyiml4XnvBYsJuhZWomFoeulcOXAPoTJ2vTw6erWYtdOiZymfQ3GMWpxzgkOVeNjsFF 9AQ38FCMKmIDs9dgn+KXSIXlZA34khKLd163SN5U/KHfYlnnocec31u+7rVa1hlF5DBSSpoi s8cs41foBYC5NsB/i+yqGIlfzHy7pC2u5kyQCuJotLH4y0rT5X+YBC7z7cqKChtILNDGw0ht qps29fwOGBE/FWmu8CbpSHj8pvg7uUyQcKbZbNChBfWtOJKdjnNs5VHf2ec95SwYmWl6Xz66 G892HY4ODtvl05/kh0qtdJd2oI4gJBsBx/N1585/3JYN4k78GIHTnML3xJydRRs9wwM3AXf/ iDGrMyY7qHQVXJLdO5nPe7LHg48vryCMkBnTMw5iNFPVCu5w1BaZyHxuS2HvpsgUtQoBa2QE P1jYNI+2qgoiIG4VQDhYtrD0WJaYdi/C2UVDxRy07dt73SV3RQ7ijOiUrz4g3/deFKY16/1k sE+N5Sc5Tjt84ChjO3nJRbHrQxd6dCOElR70e3R2yAuSB4m7LJpO20IB9CtWhlF/0AtfL91W O8GGGqLWB0Z04hmwRs/l8T4WWIlykLshbunWN6jsP1Y27FeilTZ+Pc9mYOEUFfEAEQEAAYkC HwQYAQgACQUCVXBQXwIbDAAKCRBLswjpsC52bPayD/9jE8mdNudrudSxbDB2vf8pU8r5flCq vIkfOdpZGV/Wx/Zx+HFHHp+b2aNBGSNyFTnph1Ku9bvg06vD0o+b7SdA1vrBgRG41t0OCIyf vejz65Xpin2EtCllcBM8zUCxHo43blON8fNw70P1Ec0loBp4TAal1MiXbB8kxRTRcEPVO9YF 9NPsFxycoWl0ZSvu4ESrQlrjRbVv+W0Fy/XqcQwEtDziFQHQXNRbTy8INPD49CsB7BkKRK+f 1vMmw7SxfsyEhyCgo9ZWfHb/+w9T5h+UhF87L/m287z7W+s4aCAPBzjbIWhtngGJJwIgiWdI I9J6YJLcHLvVZLw7xzA/flcjc0VfzOgJOJw3hBukHnEz7/CKgnABwyNu52P+PQbxVTiTjMKm 06eV732u9ZLD9ZgEazfmyGDHzsuzoXwsRnmcnbwYYAiynS+vfGl5oMtMa5qzsPhlzuvRlXHm zr8VjF8c9RThvyZyyHtWYAqNmBecMvM0whigjMeoAMJ5LtpyZgxjbHj1XnVdNBZgfJkOzsc/ twffi7RYphRx0d9z5UZ1Yl5Rvl05vTaJ7YhhNC7xuE8yGOQmDUsPDwWqO/eXUDErJjCOBR5b 0yILqRPYNT0Fj/th9gtEbZy1Gp0TVBkZM3tfjDRu43Pn6iSKObO/j0rNuq1LwN/EMxDifeZO 4XSbcg== Message-ID: <999a1d37-ecba-a700-df82-236bbbb8ff9f@gmx.com> Date: Tue, 17 Mar 2020 10:38:00 +0100 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="wybshMCcuAEx1n62Zkr4SCmgQSktEjRoY" X-Provags-ID: V03:K1:JyKCx5DaKmdwaKKQ+afPRKKnJbP7Y0jAflirp3DpAbi0uyh8NAw YOFRZRy3Lz0qQR/3VkWl1Et10v0Pe7CgFNG97+lOmghlnTlPB+OuJ+LX8Mx4PVHBMpjHe6Q 3kvgcLgIGPaokIdR3LewzW8wlZMeaLq3Yjw6gJpHsUa7AoYB1eFyTP7KiCrPflqY3aGnbH3 c2vIGJvTi2QQxlseGL6ZQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:e65CxJp3wjE=:Znl4V771/Ah4o7loIpfkSZ LsYF8tYrZWy1nGjfe3bFeBCw5ll99ningsgKVk5yf9VeYXTPJo8kLipDQ8wVn2K6lXncK3y53 ABViPl7WA7AZAepME4TsLV4zVeazSOAIY4N1vg+4RQ3x5fYoaSfUiwzgsZ+ber+Tcm1YyZU9S rO0FT23vXoCidmwD7Zpt6aBvDKYmQfUQduy6cDmrvjEvV8nLSJ4CSpafFJ73hMmx8IG6U9/FG gTXv4R/H3+eaOvB7w7Z77shVhRZ7l32Fj2pZBDNxnU9aS5ZEvhnjeH9SELevs/sj+IKJPOIb2 xVd5TyjhWPePJUgJewBpTqeCi2Dl66noyEBPCnSzxFxw/q8tNVreaxa+FCMjwIzG0Va9CZQPT rCkge6Gvwi7t5wKWjty/HfNRAJlFm8lIF0ha0zmcuMtmw29H3X0htAhFW0XlU0oaANHw2GeHF 4q1NfvGnABCJdyNicnN+cGh+i4t17ximwYciTaTV3FikowaR9NX6tUp6CfdMCtRb7lbRIXoMk beD7gbrQn0Uob3ie7SmterdiCKFDOMvWLVmJBXy0+pXL7Yms66wYYY5M9IbY0je0aJm7d0N4e spXu99ZU8lZsgk30o2PvWD4y0YqcY2NBQnxpDOyvbw4SNirBpCOxgBsnhoQ2it6AnrLprb9vR PrjXkwfF1hemlAAVCNMqtZEHtJwpNCK0ADEblTAzQLGDj6TG2LslVuULl37w4QFUbHBEozyUl HpFelqAI0ShQImygUIqldbuWJ1tbc8mmCihg+5Dag2yPX5D4O+f1eC20dyzK+mT/d7Xf8sIQ2 YgHOQewP5pXozW6Ye1FIhGiYf8eBl8eKyHyf4fe9vMBGYX9N5PzSx5x92b6781Lcc+Ghuzojj mHLCzGyRmc8YN+8x5Wq0mFwi53IIlya3gtB4WNPMwl8dApVOAfeP0abSj+J0yOPvV+Gjv2akA f2ApvtRtfC5nMViuArdhWVqWbMGwJDh98Y3oCEBwx8i7ioKRlJSNnNrV0wMSj9DUVrhJ/DHAj 9tognZNFDcbzh3KcvHky3xoDUmsMGLIcPfDja+Msyv4GFeo9dphbRoufKD1GDhZIMNB986JOn DFGdSpc8yjD8+nlSOBGi9XkkB9Yy+I8qiqcQBeT7qIsY3dSYsN1Rnh7fh4yA+vHYZtaL59fHa pZTDAjzkUaVDCXnryU5mkMIbWG3N22j3cIPIkeVnkahmMt0PEUCrhVXmfTKhJi45bNFxY= X-Spam-Status: No, score=-25.4 required=5.0 tests=DKIM_SIGNED, DKIM_VALID, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, GIT_PATCH_0, GIT_PATCH_1, GIT_PATCH_2, GIT_PATCH_3, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Mar 2020 09:39:29 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --wybshMCcuAEx1n62Zkr4SCmgQSktEjRoY Content-Type: multipart/mixed; boundary="7vvny7F5VHo763QYczJw5RAKbEoBKxcIK"; protected-headers="v1" From: Kamil Rytarowski To: Christian Biesinger Cc: gdb-patches Message-ID: <999a1d37-ecba-a700-df82-236bbbb8ff9f@gmx.com> Subject: Re: [PATCH] Add support for NetBSD threads in sparc-nat.c References: <20200314182710.11396-1-n54@gmx.com> In-Reply-To: --7vvny7F5VHo763QYczJw5RAKbEoBKxcIK Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 16.03.2020 22:35, Christian Biesinger wrote: > On Sat, Mar 14, 2020 at 1:28 PM Kamil Rytarowski wrote: >> >> NetBSD ptrace(2) accepts thread id (LWP) as the 4th argument for threa= ds. >> >> This file is still shared with other targets that use different 4th ar= gument >> type. >=20 > I wonder if it would be less ugly to have a function that handles this:= >=20 > inline int gdb_ptrace (...) { > #ifdef __NetBSD__ > return ptrace (..., lwp); > #else > return ptrace (..., (PTRACE_TYPE_ARG4) 0); > #endif > } >=20 > Then call gdb_ptrace in this file. >=20 > Thoughts? >=20 >=20 I will propose a similar approach, but using a preprocessor define. >=20 > Christian >=20 >> --- >> gdb/sparc-nat.c | 19 +++++++++++++++++-- >> 1 file changed, 17 insertions(+), 2 deletions(-) >> >> diff --git a/gdb/sparc-nat.c b/gdb/sparc-nat.c >> index dff0f521565..1e890bd8613 100644 >> --- a/gdb/sparc-nat.c >> +++ b/gdb/sparc-nat.c >> @@ -154,6 +154,12 @@ sparc_fetch_inferior_registers (struct regcache *= regcache, int regnum) >> registers can be written. */ >> pid =3D get_ptrace_pid (regcache->ptid ()); >> >> +#ifdef __NetBSD__ >> +# define lwp regcache->ptid ().lwp () >> +#else >> +# define lwp (PTRACE_TYPE_ARG4) 0 >> +#endif >> + >> if (regnum =3D=3D SPARC_G0_REGNUM) >> { >> gdb_byte zero[8] =3D { 0 }; >> @@ -166,7 +172,7 @@ sparc_fetch_inferior_registers (struct regcache *r= egcache, int regnum) >> { >> gregset_t regs; >> >> - if (ptrace (PTRACE_GETREGS, pid, (PTRACE_TYPE_ARG3) ®s, 0) =3D= =3D -1) >> + if (ptrace (PTRACE_GETREGS, pid, (PTRACE_TYPE_ARG3) ®s, lwp)= =3D=3D -1) >> perror_with_name (_("Couldn't get registers")); >> >> sparc_supply_gregset (sparc_gregmap, regcache, -1, ®s); >> @@ -178,11 +184,13 @@ sparc_fetch_inferior_registers (struct regcache = *regcache, int regnum) >> { >> fpregset_t fpregs; >> >> - if (ptrace (PTRACE_GETFPREGS, pid, (PTRACE_TYPE_ARG3) &fpregs, = 0) =3D=3D -1) >> + if (ptrace (PTRACE_GETFPREGS, pid, (PTRACE_TYPE_ARG3) &fpregs, = lwp) =3D=3D -1) >> perror_with_name (_("Couldn't get floating point status")); >> >> sparc_supply_fpregset (sparc_fpregmap, regcache, -1, &fpregs); >> } >> + >> +#undef lwp >> } >> >> void >> @@ -195,6 +203,12 @@ sparc_store_inferior_registers (struct regcache *= regcache, int regnum) >> about threaded assumptions. */ >> pid =3D get_ptrace_pid (regcache->ptid ()); >> >> +#ifdef __NetBSD__ >> +# define lwp regcache->ptid ().lwp () >> +#else >> +# define lwp (PTRACE_TYPE_ARG4) 0 >> +#endif >> + >> if (regnum =3D=3D -1 || sparc_gregset_supplies_p (gdbarch, regnum))= >> { >> gregset_t regs; >> @@ -245,6 +259,7 @@ sparc_store_inferior_registers (struct regcache *r= egcache, int regnum) >> if (regnum !=3D -1) >> return; >> } >> +#undef lwp >> } >> >> >> -- >> 2.25.0 >> --7vvny7F5VHo763QYczJw5RAKbEoBKxcIK-- --wybshMCcuAEx1n62Zkr4SCmgQSktEjRoY Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAl5wmnkACgkQS7MI6bAu dmxczw/+LWrRrOp0ngAV+aXCrocTdERMQi8Mm+90HEIwSkzlmCsbMneyhl39bArm rA0LaCKF2V/XZCjJKNmakHG4X7VAMVSa9FY1F3fFid/4NoEz0Zh6NI97rSPlU0BE lTGi5Fhxy2bP1OKU9KEQkq4bVoaDcWRnls/+82qJaxoj4wY/7YmiL0ii7k0jrAaz 9pVXYQoBu7CmqWZzsyx3j5iJW6yh19XTTcQOsANyOcQMKNAzkfnOnRZm1xVFgtNV wk3n7h+boLdUexHHO8XJ+IriiUR7/LzjZ9Faqj9gt88juyIxtQFqDdXVcR48hoYg 0wnEPmDcjPZKldm4abtmDuiGz7X7P/+stLie9+W+jM31VKJi6/naGXaK0LZ50/l4 35+M7qahSWbQf5wOJaLn9BPzyZusavjwj99jl7o1H67d1XATjsrRXfRqO7C6ddOS XIBQfxGHZil6NwoKdUpHL4VzEr9NdL4C/S0E2fYP/ecMK92EuNHj+Iv44QdFhkuT odBjf4RmWs0bRlj63rZVgBTnjueWldkxtOUoZyqExKnk+UIjwBtdoIIhIPseriZB rvQfo8aULeO5lK+zmTzq8F69ic+lx9u+eczaIQ1RPyaKTEZgBKwUtGZW/IKbP3cN JLNdiYMwU8czPuz9gmTxziHKIddfjyrw04WkHLdezpzWIQGdAAw= =fnj3 -----END PGP SIGNATURE----- --wybshMCcuAEx1n62Zkr4SCmgQSktEjRoY--