From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id sUOTN59FD2o0GQ0AWB0awg (envelope-from ) for ; Thu, 21 May 2026 13:49:19 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=X1ztqlUU; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id DFC861E024; Thu, 21 May 2026 13:49:19 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 32C751E024 for ; Thu, 21 May 2026 13:49:19 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B1FFB48F66DA for ; Thu, 21 May 2026 17:49:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B1FFB48F66DA Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=X1ztqlUU Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 5996248F66D5 for ; Thu, 21 May 2026 17:48:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 5996248F66D5 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=polymtl.ca Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=polymtl.ca ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 5996248F66D5 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=132.207.4.11 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779385736; cv=none; b=h5FxidCMRkVbu320gCSrXfJPsTET+VsOnV+mJ1b4wfzVkmHTnwmBi4Qu24kq88so8Ioo/ndGtnHKxLbLS7HFNyi34FWagTYkm2jwPjucC5IHLMiBYxhGm7Y6IGVm0paOvlXzwgYK9iwShzEONTh81ZfRgLFUhhEHGmfQmOWqC2Y= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1779385736; c=relaxed/simple; bh=Xw6AN2xMPVolGyq5fL6LljBLBDR23KolrESHfBnXf30=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=MX1Zy2+9tYhckzVtCH/NiF9wNPC7VVBoSFSo0CPQvm9CPmyMlr7jUJU8Q66ivFozRL40Qd3DMvI3kMPZMzPQVl7ICoHI5V06PVww3NAy7Iww3Exzq2w5w1KU3gxcWH2m8+E6b3ebyAf/E7fI9gLOUDDIwTsl1hq9eHLlH1ZHKXU= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=polymtl.ca header.i=@polymtl.ca header.a=rsa-sha256 header.s=oct2025 header.b=X1ztqlUU DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 5996248F66D5 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 64LHmosA068891 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Thu, 21 May 2026 13:48:55 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 64LHmosA068891 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=polymtl.ca; s=oct2025; t=1779385735; bh=B/5gLLZx3J5GV63XXlk4VypHUwtR8Z/EzzWTO5QQVHA=; h=Date:Subject:To:Cc:From:In-Reply-To:From; b=X1ztqlUUBbF9aMkN7XTj5hXZQLGfHwoxa0dIr4TKPJRi/rfw8BMcl0/+bC9X7oOrq TcoZUAP0Ny8BReN5zW27AHJ4QU/gyXrh54k2hu9tx9Wyk7iR67uDWChibOWvLjQFH2 v/DPBaSzelO2pz/nHE0rW2V9i0WfEis3qyTIsq6R87cNNjwk0p5Y9ngX6/crV1RI9L VrbopmipfevmDEqlE+pkGtjaqQoxh2h0nS94JPORM0lMl26rsi3Os5+e4tMYCxP81S SevTNggYq9zT4nfOUqilsb1nhrty/a2tYCVRUxzJRr1mvYhHjqUKnTKUFqPsLMLnfQ wY44BKxlsXcnw== Received: by simark.ca (Postfix) id 378EF1E024; Thu, 21 May 2026 13:48:50 -0400 (EDT) Message-ID: <99959b59-5fd8-4a28-bb29-178de31c6db1@polymtl.ca> Date: Thu, 21 May 2026 13:48:49 -0400 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/dwarf: make dwarf2_per_bfd::get_unit return a reference To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260520181610.4066987-1-simon.marchi@polymtl.ca> <87o6i8alzm.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87o6i8alzm.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Thu, 21 May 2026 17:48:50 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 5/21/26 10:14 AM, Tom Tromey wrote: >>>>>> "Simon" == simon marchi writes: > > Simon> From: Simon Marchi > Simon> This method can't return nullptr, switch it to return a reference. > Simon> Change all_units_iterator::operator* too. > > Ok. > Approved-By: Tom Tromey > > Tom Thanks, pushed. Simon